Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#2077 closed Bug (Fixed)

_GuiRichEdit_Create Bad HWnd Check

Reported by: wraithdu Owned by: AdmiralAlkex
Milestone: 3.3.9.0 Component: Standard UDFs
Version: 3.3.8.0 Severity: None
Keywords: guirichedit rich edit Cc:

Description

In this function, the first line checks if the window handle passed matches the rich edit classname. It should not do this as the window handle passed to this function should never be a rich edit control, rather the parent window. It also has the dubious problem of calling this function with a blank classname on the first call to _Create (the variable is not yet initialized) so it SUCCEEDS. Only subsequent calls fail, return a handle of 0, and an undocumented error code of 1. To fix, revert this handle check to something sane, like IsHWnd() or WinExists(), and document the error code.

Attachments (0)

Change History (2)

comment:1 Changed 8 years ago by AdmiralAlkex

  • Milestone set to 3.3.9.0
  • Owner set to AdmiralAlkex
  • Resolution set to Fixed
  • Status changed from new to closed

Fixed by revision [6572] in version: 3.3.9.0

comment:2 Changed 8 years ago by AdmiralAlkex

This ticket is referenced in revision: [6573]

Guidelines for posting comments:

  • You cannot re-open a ticket but you may still leave a comment if you have additional information to add.
  • In-depth discussions should take place on the forum.

For more information see the full version of the ticket guidelines here.

Add Comment

Modify Ticket

Action
as closed The owner will remain AdmiralAlkex.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.