Modify

Opened 7 years ago

Closed 6 years ago

#2305 closed Bug (Fixed)

_ScreenCapture_Capture() - Width & Heigth wrong

Reported by: KaFu Owned by: guinness
Milestone: 3.3.9.5 Component: Standard UDFs
Version: 3.3.8.1 Severity: None
Keywords: Cc:

Description

Local $iW = ($iRight - $iLeft) + 1
Local $iH = ($iBottom - $iTop) + 1

should be

Local $iW = ($iRight - $iLeft)
Local $iH = ($iBottom - $iTop)

I don't see the necessity for the +1, makes all my captures 1px too large.

Attachments (0)

Change History (5)

comment:1 Changed 7 years ago by guinness

This change was introduced in Revision: 5671 because of this ticket #1446

Last edited 7 years ago by guinness (previous) (diff)

comment:2 Changed 7 years ago by anonymous

Well, a really philosophical question... Capturing the full screen starts at 0,0 and thus the +1 results in a pic of 801x601 on a 800x600 screen.

comment:3 Changed 7 years ago by anonymous

So maybe leave the +1 untouched and replace

If $iRight = -1 Then $iRight = _WinAPI_GetSystemMetrics($SCREENCAPTURECONSTANT_SM_CXSCREEN)
If $iBottom = -1 Then $iBottom = _WinAPI_GetSystemMetrics($
SCREENCAPTURECONSTANT_SM_CYSCREEN)

with

If $iRight = -1 Then $iRight = _WinAPI_GetSystemMetrics($SCREENCAPTURECONSTANT_SM_CXSCREEN) - 1 ; -1 to correct 0,0 initial screen-pos
If $iBottom = -1 Then $iBottom = _WinAPI_GetSystemMetrics($
SCREENCAPTURECONSTANT_SM_CYSCREEN) - 1 ; -1 to correct 0,0 initial screen-pos

?

comment:5 Changed 6 years ago by guinness

  • Milestone set to 3.3.9.5
  • Owner set to guinness
  • Resolution set to Fixed
  • Status changed from new to closed

Fixed by revision [7693] in version: 3.3.9.5

Guidelines for posting comments:

  • You cannot re-open a ticket but you may still leave a comment if you have additional information to add.
  • In-depth discussions should take place on the forum.

For more information see the full version of the ticket guidelines here.

Add Comment

Modify Ticket

Action
as closed The owner will remain guinness.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.