Modify

Opened 8 years ago

Closed 16 months ago

Last modified 16 months ago

#2375 closed Feature Request (Completed)

Change default return value for SetError and SetExtended

Reported by: MHz Owned by: Jpm
Milestone: 3.3.15.4 Component: AutoIt
Version: Severity: None
Keywords: Cc:

Description

Functions default to a 0 return value. Use of SetError or SetExtended sets a return value of 1 unless the return value parameter is used. The difference between 0 and 1 has always been ill behavior and always will be ill behavior until both return values use 0 by default.

People use all of the parameters to avoid the unpleasent default of 1 set by SetError and SetExtended. Anyone, which I have not seen, who uses the default of 1 needs to review their code as relying on 1 is not good especially since the help file states none as returned in 3.3.8.1 .

A 0 return by default has and always will be preferred and 1 is a usability bug.

$var = _Test()
MsgBox(0, 'Expect 1 returned', $var)

Func _Test()
	Return SetError(1)
EndFunc

Note that I have done a quick review of STD UDFs for compliance and I have submitted the bugs for 4 of them. So hopefully little to no affect will happen when the change is made.

Attachments (0)

Change History (4)

comment:1 Changed 8 years ago by Jon

  • Type changed from Bug to Feature Request

comment:2 Changed 8 years ago by TicketCleanup

  • Version 3.3.9.13 deleted

Automatic ticket cleanup.

comment:3 Changed 16 months ago by Jpm

  • Milestone set to 3.3.15.4
  • Owner set to Jpm
  • Resolution set to Completed
  • Status changed from new to closed

Added by revision [12370] in version: 3.3.15.4

comment:4 Changed 16 months ago by Jpm

to avoid SCRIPT BREAKING only doc is clarified

Guidelines for posting comments:

  • You cannot re-open a ticket but you may still leave a comment if you have additional information to add.
  • In-depth discussions should take place on the forum.

For more information see the full version of the ticket guidelines here.

Add Comment

Modify Ticket

Action
as closed The owner will remain Jpm.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.