Modify

#2444 closed Bug (No Bug)

GUICtrlCreateMenuItem -- should the 2nd param be a default?

Reported by: Jaber <jaberwocky6669@…> Owned by: guinness
Milestone: Component: AutoIt
Version: 3.3.9.20 Severity: None
Keywords: Cc:

Description

The helpfile says this:

GUICtrlCreateMenuItem ( "text", menuID = -1 [, menuentry = -1 [, menuradioitem = 0]] )

It seems like menuID should be a default parameter.

Attachments (0)

Change History (8)

comment:1 by guinness, on Sep 7, 2013 at 9:12:55 PM

Milestone: 3.3.9.21
Owner: set to guinness
Resolution: Completed
Status: newclosed

Removed by revision [8970] in version: 3.3.9.21

comment:2 by mlipok, on Sep 7, 2013 at 9:48:41 PM

you talk about this:

GUICtrlCreateMenuItem ( "text" [, menuID = -1 [, menuentry = -1 [, menuradioitem = 0]]] )

If the answer is yes
then I wait too long -- it was on my list.

comment:3 by J-Paul Mesnage, on Sep 8, 2013 at 8:54:04 AM

Resolution: Completed
Status: closedreopened

Changing the doc is not enough. AutoIt code want really 2 parameters.

What is the menuID you expect to use by default?

I reopen the ticket as doc change is not enough

comment:4 by TicketCleanup, on Sep 8, 2013 at 9:00:02 AM

Milestone: 3.3.9.21

Automatic ticket cleanup.

comment:5 by guinness, on Sep 8, 2013 at 9:08:26 AM

It was a mistake from the previous commit 7893. The "default" parameter should have never been added.

comment:6 by Jaber <jaberwocky6669@…>, on Sep 8, 2013 at 12:45:44 PM

Yes Mlipok that is what I mean and I meant make it a default in both the au source and doc.

Jpm, I guess it should stay -1 but it should be such that it can be written like this:

GUICtrlCreateMenuItem("MyMenuItemText")

comment:7 by Jaber <jaberwocky6669@…>, on Sep 8, 2013 at 12:51:28 PM

But of course I now see the reason why it isn't a default parameter.

GuiCtrlCreateMenu("MyMenu")
GuiCtrlCreateMenuItem("MyMenuItem1")
GuiCtrlCreateMenuItem("MyMenuItem2") ; now -1 refers not to the menu but the 1st menu item.
GuiCtrlCreateMenuItem("MyMenuItem3") ; now -1 refers not to the menu but the 2nd menu item. 

Sorry for wasting time.

comment:8 by J-Paul Mesnage, on Sep 8, 2013 at 1:53:41 PM

Resolution: No Bug
Status: reopenedclosed

no problem

Modify Ticket

Action
as closed The owner will remain guinness.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.