Modify

Opened 10 years ago

Closed 10 years ago

#872 closed Bug (Rejected)

Re-Fix BugTrac #850: _ExcelReadSheetToArray()

Reported by: PsaltyDS Owned by:
Milestone: Component: AutoIt
Version: 3.3.0.0 Severity: None
Keywords: Cc:

Description

The bug described and fixed in Track #850, was previously reported and fixed in the original ExcelCOM_UDF topic: http://www.autoitscript.com/forum/index.php?s=&showtopic=34302&view=findpost&p=491640

The original fix was:

    ; Extract integer last row and col
    Local $avLastCell = StringRegExp($sLastCell, "\d+", 3)
    Local $iLastRow = Number($avLastCell[0])
    Local $iLastColumn = Number($avLastCell[1])

The proposed fix arrived at in #850 uses:

    ; Extract integer last row and col
    $sLastCell = StringRegExp($sLastCell,"\A[^0-9]*(\d+)[^0-9]*(\d+)\Z",3)
    Local $iLastRow = $sLastCell[0]
    Local $iLastColumn = $sLastCell[1]

The original fix is simpler, and doesn't mis-name the the array variable with '$s' prefix.

I propose the original fix apply vice the new one in #850.

Also, regardless of which fix is applied, that we get some more non-English testers before finally closing the ticket.

Attachments (0)

Change History (1)

comment:1 Changed 10 years ago by Gary

  • Resolution set to Rejected
  • Status changed from new to closed

Guidelines for posting comments:

  • You cannot re-open a ticket but you may still leave a comment if you have additional information to add.
  • In-depth discussions should take place on the forum.

For more information see the full version of the ticket guidelines here.

Add Comment

Modify Ticket

Action
as closed The ticket will remain with no owner.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.