New file line count script UDF

[Frozenyam]

#Include-Once

Func _CountLines (ByRef $File)
   Global $Count = 0

   FileOpen ($File, 0)

   Do
      $Count = $Count + 1
      $CountLine = FileReadLine ($File, $Count)
   Until @Error = -1

   Return $Count - 1
EndFunc

Will count the lines in a file without problems and will output it to a variable.

Use Of Function:

#Include <_CountLines.au3>

$File = "Path\Name.Extention"
$NumOfLines = _CountLines ($File)

_CountLines.au3

Edited August 12, 2005 by Frozenyam

[w0uter]

make the variabels LOCAL.

you didnt open the file. you also didnt close the file.

and why a byref ?

Edited August 12, 2005 by w0uter

[Josbe]

#Include-Once

Func _CountLines (ByRef $File)
   Global $Count = 0

   FileOpen ($File, 0)

   Do
      $Count = $Count + 1
      $CountLine = FileReadLine ($File, $Count)
   Until @Error = -1

   Return $Count - 1
EndFunc

Will count the lines in a file without problems and will output it to a variable.

Use Of Function:

#Include <_CountLines.au3>

$File = "Path\Name.Extention"
$NumOfLines = _CountLines ($File)

<{POST_SNAPBACK}>

Nice try, but too late. This function was improved by Tylo, and included in the standard UDF. >> File.au3 <<

To improve your code, look the w0uter remarks also.

[Jos]

Frozenyam PMed me with this update and i mentioned the same, but he claimed that the current version is broken.

Its better to report the BUG when current UDF's don't work then to come up with a modified version, because this gives the original author of a UDF to fix or update the UDF.

Edited August 12, 2005 by JdeB

[Josbe]

Frozenyam PMed me with this update and i mentioned the same, but he claimed that the current version is broken.

Its better to report the BUG when current UDF's don't work then to come up with a modified version, because this give the original writer of a UDF to fix or update the UDF.

<{POST_SNAPBACK}>

http://www.autoitscript.com/fileman/users/Josbe/_sforum/smilies/yes.gif I agree completely.