valkn Posted May 23, 2013 Posted May 23, 2013 I am a newbie with Autoit - the following script works for me but I just wanted to find out if there was anything wrong with it (I skipped pasting some of the additional registry key settings in the middle of the script): #Region ;**** Directives created by AutoIt3Wrapper_GUI **** #AutoIt3Wrapper_Icon=C:ICONSReceiver.ico #AutoIt3Wrapper_Outfile=Receiver_3_4.exe #AutoIt3Wrapper_Res_requestedExecutionLevel=requireAdministrator #EndRegion ;**** Directives created by AutoIt3Wrapper_GUI **** $M = MsgBox(68,"Citrix Receiver 3.4.0.295 Install","The 32 bit Citrix Receiver version 3.4.0.295 will be installed. Do you want to continue?") If $M = 7 Then Exit ElseIf $M = 6 Then $U = MsgBox(52,"Citrix Receiver 3.4.0.295 Install","Have all previous Citrix clients been uninstalled?") If $U = 7 Then Exit Else RegDelete("HKEY_CURRENT_USERSOFTWARECitrixICAClient") RegDelete("HKEY_LOCAL_MACHINESOFTWARECitrixICAClient") SplashTextOn('Citrix Receiver 3.4.0.295 Install', 'Please wait.....installation in progress. Upon completion, a reboot screen will appear', 300, 80) Sleep(8000) FileInstall("U:CitrixClientsReceiver_3_4CitrixReceiver.exe", @TempDir & "") FileInstall("U:CitrixClientsReceiver_3_4ProgressNotification.dll", @TempDir & "") RunWait(@TempDir & "" & "CitrixReceiver.exe /silent /noreboot /includeSSON /ALLOWADDSTORE=N ADDLOCAL=ReceiverInside,ICA_Client,SSON ENABLE_DYNAMIC_CLIENT_NAME=Yes ENABLE_SSON=Yes") FileMove("C:Program FilesCitrixICA ClientProgressNotification.dll", "C:Program FilesCitrixICA ClientProgressNotification.dll.old") FileMove("C:Program FilesCitrixICA ClientReceiverProgressNotification.dll", "C:Program FilesCitrixICA ClientReceiverProgressNotification.dll.old") FileCopy(@TempDir & "*.dll", "C:Program FilesCitrixICA Client", 1) FileCopy(@TempDir & "*.dll", "C:Program FilesCitrixICA ClientReceiver", 1) SplashOff() EndIf EndIF # *** Connection Center Settings ***** RegWrite("HKEY_LOCAL_MACHINESOFTWARECitrixICA ClientEngineConfigurationAdvancedModulesWFClient", "TWISeamlessFlag", "REG_SZ", "1") RegWrite("HKEY_LOCAL_MACHINESOFTWARECitrixICA Client", "NotificationDelay", "REG_DWORD", "00000000") RegWrite("HKEY_LOCAL_MACHINESOFTWARECitrixICA ClientClient Selective TrustoidInternetRegion", "className", "REG_SZ", "Region") RegWrite("HKEY_LOCAL_MACHINESOFTWARECitrixICA ClientClient Selective TrustoidInternetRegion", "isRoot", "REG_SZ", "true") RegWrite("HKEY_LOCAL_MACHINESOFTWARECitrixICA ClientClient Selective TrustoidInternetRegion", "stereotype", "REG_SZ", "DbObject") FileDelete(@TempDir & "" & "CitrixReceiver.exe") FileDelete(@TempDir & "" & "ProgressNotification.dll") $E = MsgBox(36,"Citrix Receiver 3.4.0.295 Install","32 bit Citrix Receiver version 3.4.0.295 installation requires a reboot. Do you want to reboot now?") If $E = 6 Then Shutdown(6) ;Force a reboot ElseIf $E = 7 Then Exit EndIf Thanks in Advance!
Moderators JLogan3o13 Posted May 23, 2013 Moderators Posted May 23, 2013 If it works for you, then what is your question? "Profanity is the last vestige of the feeble mind. For the man who cannot express himself forcibly through intellect must do so through shock and awe" - Spencer W. Kimball How to get your question answered on this forum!
valkn Posted May 24, 2013 Author Posted May 24, 2013 A couple of guys I work with stated that the FileInstall should not appear in the package (I advised that it was used to add the files to the package) (They think that when the user launches the exe package that it's going to look to the users U drive for something) and that the script should not start out with deleting registry keys etc. etc. and they don't understand how the package even works so much is wrong with it. Being a newbie, I just wasn't sure if everything was correct even though it worked for me. Might just be their male ego since I created the package. FileInstall("U:CitrixClientsReceiver_3_4CitrixReceiver.exe", @TempDir & "") FileInstall("U:CitrixClientsReceiver_3_4ProgressNotification.dll", @TempDir & "") Thanks, Valerie
BrewManNH Posted May 24, 2013 Posted May 24, 2013 (edited) The FileInstall isn't going to look for the U drive, that's the source folder, it's the Temp folder it's going to "install" the files to. The thing I'm wondering is why you're deleting registry keys and renaming files/folders for a program that is supposed to be uninstalled? Edited May 24, 2013 by BrewManNH If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now