Chimaera Posted September 15, 2014 Share Posted September 15, 2014 (edited) Ive been trying to get this to work for a while and i cant get it to function properly Ive editied it down as the what to do within each case of the function works its the selection process thats flawed The CleanupRars bit function fine and ive tried taking off archivefile as well Ive tried select and if and etc etc round and round till im dizzy Ive tried with the ContinueCase and without but it doesn't give a consistent result or gives part when it should give rar I wish i could preselect the type before the case then it would be easier i guess as the $aRarFile = _FileListToArr etc etc dont seem to trigger Maybe it needs a comparison between the $aArchiveFile and each Case? So a little help if i may please Func _UnRar() ; Unpack all files $aCleanUpRars = _FileListToArrayRec(@ScriptDir, "*.rar;*.7z;*.001;*.zip;* samp*;*.samp*;*-samp*;*_samp*;*.bmp;*.jpg;*.png|*im(*).exe;*.au3;*packer Log.txt", 1, 0) ; Find the files and exclude ;~ _ArrayDisplay($aCleanUpRars, "Cleanup Files Available") $aArchiveFile = _FileListToArrayRec(@ScriptDir, "*.rar;*.7z;*.001;*.zip", 1, 0) ; Search for archive files _ArrayDisplay($aArchiveFile, "Archive Files available") If IsArray($aArchiveFile) Then ;~ If IsArray($aArchiveFile) Then Switch IsArray($aArchiveFile) Case IsArray($aArchiveFile) $aRarFile = _FileListToArrayRec(@ScriptDir, "*.part1.rar;*.part01.rar;*.part001.rar;*.001", 1, 0) _ArrayDisplay($aRarFile, ".Part/.001 Files") ConsoleWrite('part' & @CRLF) ;~ ContinueCase Case IsArray($aArchiveFile) $aRarFile = _FileListToArrayRec(@ScriptDir, "*.rar;*.r00|*.part*", 1, 0) _ArrayDisplay($aRarFile, ".Rar/.r00 Files") ConsoleWrite('rar' & @CRLF) ;~ ContinueCase Case IsArray($aArchiveFile) $aRarFile = _FileListToArrayRec(@ScriptDir, "*.7z;*.zip", 1, 0) _ArrayDisplay($aRarFile, ".zip/.7z Files") ConsoleWrite('7z' & @CRLF) ;~ ContinueCase EndSwitch Else TrayTip("Missing Archive Files", " No Archive To Extract " & @CRLF & @CRLF & _ " ( Unpack Code = NoF )", 8, 16) FileWriteLine($hErrorLog, "Missing Archive Files - No Archive To Extract | Unpack Code = NoF") Sleep(3000) Exit EndIf EndFunc ;==>_UnRar Edited September 15, 2014 by Chimaera If Ive just helped you ... miracles do happen. Chimaera CopyRobo() * Hidden Admin Account Enabler * Software Location From Registry * Find Display Resolution * _ChangeServices() Link to comment Share on other sites More sharing options...
jaberwacky Posted September 16, 2014 Share Posted September 16, 2014 I think of your switch statement like this: Switch True Case True ; only this will fire unless there is a continue case ;ContinueCase Case True ;ContinueCase Case True EndFunc Helpful Posts and Websites: AutoIt3 Variables and Function Parameters MHz | AutoIt Wiki | Using the GUIToolTip UDF BrewManNH | Can't find what you're looking for on the Forum? Link to comment Share on other sites More sharing options...
BrewManNH Posted September 16, 2014 Share Posted September 16, 2014 Your Switch won't work as written because it only runs the code under the first Case that matches, if they're all checking for the same thing, why do you put them in different case statements, just put them all under the first Case and it will work as intended. Also, as written, you're mixing the syntax of Switch and Select, reread the help file on how to use Switch/Case. If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
Chimaera Posted September 16, 2014 Author Share Posted September 16, 2014 They are seperate cases because they do different tasks with different programs If Ive just helped you ... miracles do happen. Chimaera CopyRobo() * Hidden Admin Account Enabler * Software Location From Registry * Find Display Resolution * _ChangeServices() Link to comment Share on other sites More sharing options...
BrewManNH Posted September 16, 2014 Share Posted September 16, 2014 They are seperate cases because they do different tasks with different programs But you're checking for the same thing, so it's pointless to put them in different case statements. Also, as mentioned, it's written wrong so it's not going to work as expected anyways. If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way! I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from. Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Link to comment Share on other sites More sharing options...
mikell Posted September 16, 2014 Share Posted September 16, 2014 Anyway If IsArray($aArchiveFile) Then ; assuming the answer is "true" ... Switch IsArray($aArchiveFile) ; this is useless Case IsArray($aArchiveFile) ; and also this Why not do it like this ? Func _UnRar() ; Unpack all files $aArchiveFile = _FileListToArrayRec(@ScriptDir, "*.rar;*.7z;*.001;*.zip", 1, 0) ; Search for archive files ; _ArrayDisplay($aArchiveFile, "Archive Files available") If IsArray($aArchiveFile) Then $aRarFile = _FileListToArrayRec(@ScriptDir, "*.part1.rar;*.part01.rar;*.part001.rar;*.001", 1, 0) If not @error Then ... ; _ArrayDisplay($aRarFile, ".Part/.001 Files") EndIf $aRarFile = _FileListToArrayRec(@ScriptDir, "*.rar;*.r00|*.part*", 1, 0) If not @error Then ... ; _ArrayDisplay($aRarFile, ".Rar/.r00 Files") EndIf $aRarFile = _FileListToArrayRec(@ScriptDir, "*.7z;*.zip", 1, 0) If not @error Then ... ; _ArrayDisplay($aRarFile, ".zip/.7z Files") EndIf EndIf EndFunc Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now