Problem with "If <expression> And <expression> Then" statement

[Vadersapien]

I have the following code which is working incorrectly:

If $Custom_Time_Value[4] = 'PM' And Not $Custom_Time_Value[1] = '12' Then
    $Custom_Hour = $Custom_Time_Value[1] + '12'
Else
    $Custom_Hour = $Custom_Time_Value[1]
EndIf

Even though $Custom_Time_Value[1] does not equal 12...any idea why?

Edited November 17, 2009 by Vadersapien

[Mison]

line 1;

If $Custom_Time_Value[4] = 'PM' And Not^

Error type:bad logic...

Question... what if $Custom_Time_Value[1] equal to 12?? Does it return the desired results??

Edited November 17, 2009 by Mison

[Vadersapien]

If it's equal to 12 it executes the code under "Else"

[Mison]

If it's equal to 12 it executes the code under "Else"

While it's supposed to do otherwise? It's in your logical comparison.. remove NOT operator in line 1.

[Vadersapien]

No it's doing the correct thing if it equals 12...

I'm trying to convert normal time to military time...

Edited November 17, 2009 by Vadersapien

[Mison]

Then I guessed it right. This is my code for a task similar to yours:

$pm = 1 ; it's noon here... 
If $pm And @HOUR < 12 Then
    MsgBox(0,"","Military time: "&@HOUR+12)
Else
    MsgBox(0,"","Military time: "&@HOUR)
EndIf

[Vadersapien]

A simple < instead of an =...why didn't I think of that!

Edited November 17, 2009 by Vadersapien

[Vadersapien]

What about midnight(0:00)?

[Mison]

pm [false] And @hour < 12 [true] = false

[Richard Robertson]

The reason it wasn't working was because it was performing the Not on the value directly to the right of it. It compared (Not $Custom_Time_Value[1]) = '12'. You should just use <> for not equal.