Help making this more efficient

[helpplx]

This does what it needs to do. But whilst it runs it uses about 20+% of the cpu.. and when you press 2 to start the pixelsearch it gets even worse.

My knowledge of autoit is nonexistent so I was wondering if it's possible to make this do what it does without taking up a 5th of my cpu?

Thanks in advance.

expandcollapse popup

Func _IsPressed($hexKey)

  
  Local $aR, $bO
  
  $hexKey = '0x' & $hexKey
  $aR = DllCall("user32", "int", "GetAsyncKeyState", "int", $hexKey)
  If Not @error And BitAND($aR[0], 0x8000) = 0x8000 Then
     $bO = 1
  Else
     $bO = 0
  EndIf
  
  Return $bO
EndFunc 



$colorred = 0xEE405A
$colorgold = 0xFCFB52
$colorblue = 0x42B5F9
$color = 0xEE405A


While 1
    
      If _IsPressed('61') = 1 Then $color = $colorblue
      If _IsPressed('62') = 1 Then $color = $colorred
      If _IsPressed('63') = 1 Then $color = $colorgold
    
    
         If _IsPressed('32') = 1 Then 
          while 1
            $coord = PixelSearch(555, 928, 588, 965, $color, 40, 2)
            If IsArray($coord) = 1 Then
                send ("2")
                sleep (100)
                exitloop
            endif
        wend
        endif
        wend

[Yoriz]

Hey, welcome to the forum, if you was to put a Sleep(100) in your main While loop it would give your cpu chance to have a breather.

[Zibit]

you can manipulate cpu usage using memory...

[NinjaGeek]

The reason it is using so much memory is that you are opening and closing the DLL every time _IsPressed is called - instead use DllOpen before your loop and then pass in the handle returned from that function:

expandcollapse popup

Func _IsPressed($hexKey,$dll)
    Local $aR, $bO
  
  $hexKey = '0x' & $hexKey
  $aR = DllCall($dll, "int", "GetAsyncKeyState", "int", $hexKey)
  If Not @error And BitAND($aR[0], 0x8000) = 0x8000 Then
     $bO = 1
  Else
     $bO = 0
  EndIf
  
  Return $bO
EndFunc 



$colorred = 0xEE405A
$colorgold = 0xFCFB52
$colorblue = 0x42B5F9
$color = 0xEE405A

$dll = DllOpen("user32.dll")
While 1
    
      If _IsPressed('61',$dll) = 1 Then $color = $colorblue
      If _IsPressed('62',$dll) = 1 Then $color = $colorred
      If _IsPressed('63',$dll) = 1 Then $color = $colorgold
    
    
         If _IsPressed('32') = 1 Then 
          while 1
            $coord = PixelSearch(555, 928, 588, 965, $color, 40, 2)
            If IsArray($coord) = 1 Then
                send ("2")
                sleep (100)
                exitloop
            endif
        wend
        endif
        wend

You may also want to replace IsArray($coord) = 1 with simply @error, as it is set to 1 if the pixelsearch fails.