Attribute setting problem

[saywell 3]

I've written a script to change file attributes, which sounds simple - and I've used something less complex without problems.

This one lets you choose what to change in terms of attributes and folders, but i keep getting a failure to change attributes message and i can't work out why!

expandcollapse popup

#Region ;**** Directives created by AutoIt3Wrapper_GUI ****
#AutoIt3Wrapper_icon=U:\Icons\Print602_233.ico
#EndRegion ;**** Directives created by AutoIt3Wrapper_GUI ****




Global $flag, $path 
Global $att = InputBox ("Select Attributes", "Enter attributes to change in standard format eg:"  & @CR & "+A, +RA-SH" & @CR & @CR & "Options are:" &  @CR & "R = READONLY  A = ARCHIVE   S = SYSTEM   H = HIDDEN   N = NORMAL" & @CR &   "O = OFFLINE   T = TEMPORARY "," ","",400,200)

Global $params = '"' & $att & '"'
$params = StringUpper ($params)
$params = StringStripWS ($params, 8)

Global $Extension = InputBox ("Choose File extension", "Enter file extension without dot eg bmp" & @CR & @CR & "* for all files")


Global $folder = FileSelectFolder ("Select Folder", @HomeDrive,6)

$path = '"'& $folder & '\*.' & $Extension & '"'

Global $Recurse = MsgBox (35, "Recursive?", "Apply to all subfolders?" & @CRLF & "YES to recurse, NO to apply to selected folder only")
; yes = 6, no = 7, cancel = 2
Select
    Case $Recurse = 6
        $flag = 1
    Case $Recurse = 7
        $flag = 0
    Case $Recurse = 2
        Exit
EndSelect



MsgBox (4096, "Command", $path & "," & $params & ","  & $flag)

If Not FileSetAttrib ($path, $params, $flag) Then
  MsgBox(4096,"Error", "Problem setting attributes.")
EndIf

Grateful to anyone who can spot my silly mistake!

Thanks,

William

[PsaltyDS 41]

Drop the double quotes around things you are passing to AutoIt functions:

Global $params = $att

; ...

$path = $folder & '\*.' & $Extension

[saywell 3]

Thanks, PSaltyDS!

I thought it was something silly. I thought the parameters that had " around them in the 'written' version would need them in the programmed version, but obviously that's not the case. Another lesson learned...

Regards,

William