net use - getting status of network drives

[gcue]

hmm sometimes i run it and i get "status" as the top result - which is the column heading of the first column.. if i run it again ont he same computer 1 second later without making any changes - it looks good..

weeeeird... could it be that the output is captured too quickly?

still shouldnt capture that heading tho:

bc of this

If $line <> "" And StringInStr($line, "") <> @error Then

[BrewManNH]

I have the same issue when I run it sometimes. I put an _ArrayDisplay after the While...Wend loop and I see in $array that some of the lines that have been read are in the same element with other lines instead of in their own element, that's why the check fails because the "" is in the string returned, it's just in the wrong place. The lines aren't being split correctly when doing the StdOutRead for some reason.

[gcue]

tried this.. seems to be faster

havent seen the issue anymore..

expandcollapse popup

#include <Constants.au3>
#include <array.au3>
#include <file.au3>

$std_output = Run(@ComSpec & " /c net use", @SystemDir, @SW_HIDE, $STDOUT_CHILD)

Local $line, $array[1], $array2[1]
$temp_file = @TempDir & "differentiate_mappings.txt"

If FileExists($temp_file) Then
    FileDelete($temp_file)
EndIf

While 1
    $line = StdoutRead($std_output)
    If @error Then ExitLoop

    If $line <> "" Then
        FileWriteLine($temp_file, $line)
    EndIf
WEnd

$line_count = _FileCountLines($temp_file)

For $x = 1 To $line_count
    $line = FileReadLine($temp_file, $x)

    If StringInStr($line, "") <> 0 Then
        ReDim $array[UBound($array) + 1]
        $array[UBound($array) - 1] = $line
    EndIf
Next

If FileExists($temp_file) Then
    FileDelete($temp_file)
EndIf

For $x = 1 To UBound($array) - 1
    $line = StringStripWS($array[$x], 1 + 4)

    $split = StringSplit($line, Chr(32))

    ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') : $split[2] = ' & $split[2] & @CRLF & '>Error code: ' & @error & @CRLF) ;### Debug Console
    If StringInStr($split[2], ":") <> 0 Then
        ReDim $array2[UBound($array2) + 1][2]

        $array2[UBound($array2) - 1][0] = $split[2]
        $array2[UBound($array2) - 1][1] = "CUSTOM MAPPING"
    Else
        ReDim $array2[UBound($array2) + 1][2]

        $array2[UBound($array2) - 1][0] = $split[1]
        $array2[UBound($array2) - 1][1] = "GPO MAPPING"
    EndIf
Next

_ArrayDisplay($array2)

[BrewManNH]

Below is some modified code that will greatly speed up the file read process. Change the section of your script that uses FileReadLine with this and see if it's any faster for you.

;~ $line_count = _FileCountLines($temp_file) ; VERY slow with large files or slow drives
$File = FileOpen($temp_file) ; Open file in read mode
While 1
    $line = FileReadLine($File) ; reads the next line in the file, instead of opening the file every time and reading each line until it gets to the line you want
    If @error = -1 Then ExitLoop
    If StringInStr($line, "") <> 0 Then
        ReDim $array[UBound($array) + 1]
        $array[UBound($array) - 1] = $line
    EndIf
WEnd
FileClose($File)

[gcue]

the file is never that large and @tempdir is local

i measured both processes and both were under 1 second =)

[storme]

Seeing as I already commented on this thread I thought I'd add my version to the mix. Main difference is there is no external file.

expandcollapse popup

#include <Constants.au3>
#include <array.au3>

$netUsePID = Run(@ComSpec & " /c net use", @SystemDir, @SW_HIDE, $STDOUT_CHILD)

Local $cmdOut, $cmdoutlast, $buffer, $aLines, $aMappings[1]

;Collect ALL output from Net Use
While 1
    $cmdOut = StdoutRead($netUsePID)
    If @error Then ExitLoop

    If $cmdOut <> $cmdoutlast And $cmdOut <> "" Then
        $cmdoutlast = $buffer
        $buffer &= $cmdOut ; Stores all data for processing
    EndIf

    Sleep(10) ; allows the program to return some characters
WEnd

;Split into lines
$aLines = StringSplit($buffer, @CRLF)
_ArrayDisplay($aLines) ; if you're interested uncomment this line

For $x = 1 To $aLines[0]
    $line = StringStripWS($aLines[$x], 1 + 4)
    If StringInStr($line, "") <> 0 Then
        ;Line contains mapping
        $split = StringSplit($line, Chr(32))
        ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') : $split[2] = ' & $split[2] & @CRLF & '>Error code: ' & @error & @CRLF) ;### Debug Console
        If StringInStr($split[2], ":") <> 0 Then
            ReDim $aMappings[UBound($aMappings) + 1][2]

            $aMappings[UBound($aMappings) - 1][0] = $split[2]
            $aMappings[UBound($aMappings) - 1][1] = "CUSTOM MAPPING"
        Else
            ReDim $aMappings[UBound($aMappings) + 1][2]

            $aMappings[UBound($aMappings) - 1][0] = $split[1]
            $aMappings[UBound($aMappings) - 1][1] = "GPO MAPPING"
        EndIf
    EndIf
Next

_ArrayDisplay($aMappings) ; if you're interested uncomment this line

Have Fun!

John Morrison