Kill process hourly

[cfdgm]

Hello all, I am a hobbyist programmer and new to the auto it scene, I currently am studying C++ and C# and wish to further expand my abilities with autoit, but I am struggling with learning this language.

#include <Date.au3> ;
Dim $proc1 = "manager.exe"
$HourCounter = 00
While 1
If @Hour = 00 Then
$HourCounter = 00
EndIf
If @Hour <> $HourCounter Then
If ProcessExists($proc1) Then
ProcessClose($proc1)
endif
If @Hour - $HourCounter <> 0 Then
$HourCounter = @HOUR
EndIf
Sleep(5000)
WEnd

I am receiving this error.

(17) : ==> "Wend" statement with no matching "While" statement.:

WEnd

I have concluded that I am simply making some rookie mistake here.

The goal of this project is to kill another process (manager.exe) at an hourly rate. Feel free to critique the efficiency of this script, while I am still learning I will appreciate pointers that will lead to stronger programming skills.

Thank you for your time.

[Melba23]

cfdgm,

Welcome to the AutoIt forum.

You were not closing the outer If...EndIf structure:

#include <Date.au3> ;
Global $proc1 = "manager.exe"
$HourCounter = 00
While 1
    If @HOUR = 00 Then
        $HourCounter = 00
    EndIf
    If @HOUR <> $HourCounter Then
        If ProcessExists($proc1) Then
            ProcessClose($proc1)
        EndIf
        If @HOUR - $HourCounter <> 0 Then
            $HourCounter = @HOUR
        EndIf
        Sleep(5000)
    EndIf ; <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
WEnd

Other tips:

- Indent the code - it makes it easier to spot mistakes like that.

- Do not use Dim[/]i - the Variables - using Global, Local and ByRef tutorial in the Wiki explains why.

You might want to install the full SciTE4AutoIt3 package that you will find here - it has a whole bunch of extra utilities to help you ciode in AutoIt, and particularly one called Tidy which does the indenting for you.

M23

[cfdgm]

thank you sir, i know it was something stupid on my part

[Reg2Post]

Feel free to critique the efficiency of this script, while I am still learning I will appreciate pointers that will lead to stronger programming skills.

I will start of with this:

Your code will kill the process (if it is running) every 5 seconds or so (depending on how fast the host machine is) and not at an hourly interval.

Also, I think there is a few if statements you could remove.

[Spiff59]

Since you invited us to comment on efficiency...

You have the following 2 tests, one nested within the other...

If @HOUR <> $HourCounter Then...
        If @HOUR - $HourCounter <> 0 Then...

If the first test is true , then we know the second will also always be true.

I would think you could get by with just this...

#include <Date.au3>
Global $proc1 = "manager.exe"

$HourCounter = @HOUR ; wait an hour before first process kill
;$HourCounter = @HOUR - 1 ; force first process kill immediately upon script execution
While 1
    If $HourCounter <> @HOUR Then
        If ProcessExists($proc1) Then ProcessClose($proc1)
        $HourCounter = @HOUR
    EndIf
    Sleep(5000)
WEnd

typo

Edited May 15, 2012 by Spiff59

[ripdad]

Or, instead of polling for the hour, one could do something like this...

Local $iMilliseconds = _MillisecondsToNextHour()
AdlibRegister('_MyFunction', $iMilliseconds)

MsgBox(0, '_MillisecondsToNextHour()' , $iMilliseconds);<-- just for show

While 1

    ; Loop Code goes here, if needed

    Sleep(10)
WEnd

Func _MillisecondsToNextHour()
    Local $time = 3600000
    $time -= @MIN * 60000
    $time -= @SEC * 1000
    Return $time
EndFunc

Func _MyFunction()
    MsgBox(0, '', 'Time is: ' & @HOUR & ':' & @MIN & ':' & @SEC);<-- just for show

    ; Function Code goes here
    ; If ... Then ...

    AdlibRegister('_MyFunction', _MillisecondsToNextHour())
EndFunc

Edited May 16, 2012 by ripdad