Im a little stuck with a backup script

[Chimaera]

Ok as part of a backup script im doing i needed it to backup the usernames individually with data

So i borrowed this from BrewmanNH and adapted it

expandcollapse popup

#RequireAdmin
#include
#include
Global $Os

_OsDetect($Os)

Local $Users = _UserList()


Func _UserList() ;BrewmanNH origanal author
Local $UserList, $aUserList, $X, $aUserList[10], $UserList[10], $sUserList[10]
If $Os = "V-" Then
$UserList = _FileListToArray("C:\Documents and Settings", "*.*", 2)
For $I = 1 To $UserList[0]
Select
Case $UserList[$I] = "All Users"
Case $UserList[$I] = "Default User"
Case $UserList[$I] = "NetworkService"
Case $UserList[$I] = "LocalService"
Case $UserList[$I] = "Administrator"
Case Else
$aUserList[$X] = $UserList[$I]
$X += 1
If $X >= UBound($aUserList) Then
ReDim $aUserList[UBound($aUserList) + 10]
EndIf
EndSelect
Next
Else
$UserList = _FileListToArray("C:\Users", "*.*", 2)
For $I = 1 To $UserList[0]
Select
Case $UserList[$I] = "All Users"
Case $UserList[$I] = "Default"
Case $UserList[$I] = "Default User"
Case $UserList[$I] = "Public"
Case Else
$aUserList[$X] = $UserList[$I]
$X += 1
If $X >= UBound($aUserList) Then
ReDim $aUserList[UBound($aUserList) + 10]
EndIf
EndSelect
Next
EndIf
ReDim $aUserList[$X]
_ArrayDisplay($aUserList)
$sUserList = _ArrayToString($aUserList, "|")
ConsoleWrite($sUserList & @CRLF)
Return $sUserList
EndFunc ;==>_UserList


Func _OsDetect(ByRef $Os)
If @OSVersion = "WIN_2000" Or @OSVersion = "WIN_2003" Or @OSVersion = "WIN_XP" Or @OSVersion = "WIN_XPe" Then
$Os = "V-"
Else
$Os = "V+"
EndIf
;~ ConsoleWrite($Os & @CRLF)
Return $Os
EndFunc ;==>_OsDetect

Now im using this to backup the files which works fine but only backs up the current user

$iRB_PID = Run("robocopy.exe" & " " & @DesktopDir & " " & $sDestination & "\Desktop" & " " & $sRoboFilesAll & " " & $sRoboSettings, "", @SW_HIDE)
While ProcessExists($iRB_PID)
If $fInterrupt Then
$fInterrupt = False
ProcessClose($iRB_PID)
Return
EndIf
WEnd

But im trying to adapt it like this but it doesnt seem to work

For $loop = 1 To $aUserList[0]
$iRB_PID = Run("robocopy.exe" & " " & '"' & $Users & "\" & @DesktopDir & '"' & " " & '"' & $sDestination & '"' & $Users & "\Desktop" & " " & $sRoboFilesAll & " " & $sRoboSettings, "", @SW_HIDE)
While ProcessExists($iRB_PID)
If $fInterrupt Then
$fInterrupt = False
ProcessClose($iRB_PID)
Return
EndIf
WEnd
Next

I need it to use the first script to get the names then cycle through them performing the backup for each name it finds to the given destination

Any thoughts where im going wrong?

[BrewManNH]

Where are you putting that last snippet of code? Because if it's outside the userlist function, $aUserlist will be empty and undeclared. You declare it as local inside the Userlist function (you actually declare it twice in there).

[Chimaera]

Yes its lower down in the backup section outside of the userlist function

I thought calling this set the function ready

Local $Users = _UserList()

then it would make it available for the backup section lower down

[BrewManNH]

That function returns the string $sUserlist so $Users is going to equal that string after it's called. Any variables declared local inside a function cease to exist after the function ends/returns.

[storme]

G'day M8

I think this is what you maybe looking for. It isn't totally working but it will print out the robocopy command line for you to check.

Let me know how it goes.

expandcollapse popup

#RequireAdmin
#include <Array.au3>
#include <File.au3>

Global $Os = _OsDetect()
Local $aUsers = _UserList()
_ArrayDisplay($aUsers)
Local $sDestination = "*destination*"
Local $sRoboFilesAll = "*$sRoboFilesAll*"
Local $sRoboSettings = "*$sRoboSettings*"
Local $loop
 ConsoleWrite('@@ Debug(' & @ScriptLineNumber & ') : $aUsers[0] = ' & $aUsers[0] & @crlf & '>Error code: ' & @error & @crlf) ;### Debug Console
For $loop = 0 To UBound($aUsers)-1
 ConsoleWrite("robocopy.exe" & " " & '"C:Documents and Settings' & $aUsers[$loop] & 'desktop" "' & $sDestination & $aUsers[$loop] & 'Desktop"' & " " & $sRoboFilesAll & " " & $sRoboSettings & @cr)
 #cs
 $iRB_PID = Run("robocopy.exe" & " " & '"' & $Users & "" & @DesktopDir & '"' & " " & '"' & $sDestination & '"' & $Users & "Desktop" & " " & $sRoboFilesAll & " " & $sRoboSettings, "", @SW_HIDE)
 While ProcessExists($iRB_PID)
  If $fInterrupt Then
   $fInterrupt = False
   ProcessClose($iRB_PID)
   Return
  EndIf
 WEnd
 #ce
Next

Func _UserList() ;BrewmanNH origanal author
 Local $UserList, $aUserList, $X, $aUserList[10], $UserList[10], $sUserList[10]
 If $Os = "V-" Then
  $UserList = _FileListToArray("C:Documents and Settings", "*.*", 2)
  For $I = 1 To $UserList[0]
   Select
    Case $UserList[$I] = "All Users"
    Case $UserList[$I] = "Default User"
    Case $UserList[$I] = "NetworkService"
    Case $UserList[$I] = "LocalService"
    Case $UserList[$I] = "Administrator"
    Case Else
     $aUserList[$X] = $UserList[$I]
     $X += 1
     If $X >= UBound($aUserList) Then
      ReDim $aUserList[UBound($aUserList) + 10]
     EndIf
   EndSelect
  Next
 Else
  $UserList = _FileListToArray("C:Users", "*.*", 2)
  For $I = 1 To $UserList[0]
   Select
    Case $UserList[$I] = "All Users"
    Case $UserList[$I] = "Default"
    Case $UserList[$I] = "Default User"
    Case $UserList[$I] = "Public"
    Case Else
     $aUserList[$X] = $UserList[$I]
     $X += 1
     If $X >= UBound($aUserList) Then
      ReDim $aUserList[UBound($aUserList) + 10]
     EndIf
   EndSelect
  Next
 EndIf
 ReDim $aUserList[$X]
 _ArrayDisplay($aUserList)
 ;$sUserList = _ArrayToString($aUserList, "|")
 ;ConsoleWrite($sUserList & @CRLF)
 Return $aUserList
EndFunc   ;==>_UserList

Func _OsDetect()
 If @OSVersion = "WIN_2000" Or @OSVersion = "WIN_2003" Or @OSVersion = "WIN_XP" Or @OSVersion = "WIN_XPe" Then
  Return "V-"
 Else
  Return "V+"
 EndIf
;~ ConsoleWrite($Os & @CRLF)
 ;Return $Os
EndFunc   ;==>_OsDetect