Infinite loop ... do not want :-)

[PDowning]

While the other guys are figuring out my other thread, here's a new one. I seem to have created an infinite loop, something I haven't done since high school using Assembly, now that required talent  .   Here is the code:

#include <GUIConstantsEX.au3>
#include <EditConstants.au3>


GUICreate('Application Launcher',400,100) ;Create 'Please Wait' window
GUISetState(@SW_SHOW)
$wasabi=GUICtrlCreateLabel ('Installing Kaspersky Anti-Virus - Please Wait',95,45)

$KASProcess = "setup.exe"
While 1
    If Not ProcessExists($KASProcess) Then

        If FileExists("C:\Program Files\Kaspersky Lab\Kaspersky Endpoint Security 10 for Windows\avp.exe") Then
            MsgBox(0, "kas", "installed")
            ExitLoop
        Else
            ;MsgBox(0, "Installing Kaspersky Anti-Virus", " Please wait while KAS Installs ..... ")
            RunWait("\\tar-fs01\KLSHARE\PkgInst\NetAgent_10.0.3361_KES_10.1.0.867\setup.exe")
        EndIf
    EndIf
WEnd

Basically, check to see if the process "setup.exe" is running, if not see if the program is installed, if not, install it. If it is installed exit the loop(that part works if it's installed), otherwise install it before continuing the script.  This script will do this for several programs, not just this AV program.  Yet somehow I managed to get it to install itself over and over  .   Failed logic again?

[Blue_Drache]

I don't see anything wrong with this loop or the logic. 

Cosmetically, I'd use GuiSetState(@SW_SHOW) inside your Else statement instead of the custom msgbox.

[JLogan3o13]

The only thing that strikes me is if your path to the avp.exe is incorrect.

[jdelaney]

Or, you are looking for the wrong dir...try using @ProgramFilesDir instead of C:program files

[PDowning]

Then why does it loop. When it gets to the end, the process setup.exe is no longer valid, so it SHOULD end. But it ends the If Not section, not the While 1 section. But even then, when it loops back around, doesn't see the process running, it checks to see if the file exists to show that it's been installed, and SHOULD exit the while loop. But it's not.

[JLogan3o13]

So you need to do some error checking - put in a couple of MsgBoxes to figure out where your logic is failing.

[jdelaney]

Yep, so either the file does not exist after the instal, or the installer is not there, or the installer is present, and no action is being performed on it...you are not passing silent install switches.

Do logging to see what's up...get the return of runwait, and log it...do a file check on the installer prior to running it...maybe the drive is not visible to the station?  Do some checking on that also.

[Mat]

If the setup program doesn't exist, then the setup will never be run, and so the loop will continue. Likewise if the path to the final file is incorrect then it will keep trying to run the setup.

There's a few things you should do:

  * Check whether the setup actually runs

  * Make sure the setup doesn't run more than once.

[PDowning]

added a few strategically placed msgbox's and we'll see where it gets me

Edit: spelling errors

Edited June 11, 2013 by PDowning

[PDowning]

got it sorted out.   Turns out the install was failling when running it from the server for some reason. Copied the file to c: and ran from there and it works like a charm.