Critical end of the program when using @ GUI_CtrlId.

[AndreyS]

Found one fatal mistake.

If you have not pressed any control, the condition:

If @ GUI_CtrlId = $ Button1 Then ...

leads to a critical conclusion of the program.

 

Fix it in the next version of auto and when?

And how to get around it now?

[Melba23]

AndreyS,

The GUI_CtrlId macro is only filled once a control has been actioned - it is designed to distinguish between controls that fire the same function. Can you post a reproducer script where you need to access this macro outside of an "Event fired" function? Then perhaps we can help you restructure your code to avoid the problem.

M23

[Edano]

@ GUI_CtrlId is only used in on event mode in the event functions. it cannot fail, if properly scripted.

[BrewManNH]

What error do you get, and does your script actually have those spaces between the @ and GUI_CtrlID, and between the $ and the word Button1?

[FireFox]

Well, the helpfile says "Only valid in an event Function." if it's called elsewhere don't be surprised it crashes.

[AndreyS]

I understand that the code is meaningless, but nonetheless I Owned need a check in my real program. 

#include <Date.au3>
#include <GUIConstantsEx.au3>
Opt("GUIOnEventMode", 1)

$Form1=GUICreate("main", 200,200,100,100)
$Time=GUICtrlCreateLabel("00:00",90,90)
Dim $b1=GUICtrlCreateButton("Start",10,10)

GUISetOnEvent($GUI_EVENT_CLOSE, "Quit")

GUISetState(@SW_SHOW, $Form1)

While 1
Sleep(2000)
If @GUI_CtrlId=$b1 Then MsgBox(0,0,0)
WEnd

Func Quit()
Exit
EndFunc

Edited August 15, 2013 by AndreyS

[FireFox]

Yeah, seems like the Au3Check does not check where is placed the macro.

You can do this :

ConsoleWrite(@GUI_CtrlId & @CrLf)

But still, it's a useless check.

[Melba23]

AndreyS,

As has been explained above the macro is meaningless outside an "Event-fired" function. Recast your code into the correct syntax and it works as it should:

#include <GUIConstantsEx.au3>

Opt("GUIOnEventMode", 1)

$Form1=GUICreate("main", 200,200,100,100)
GUISetOnEvent($GUI_EVENT_CLOSE, "Quit")

$Time=GUICtrlCreateLabel("00:00",90,90)
$b1=GUICtrlCreateButton("Start",10,10)
GUICtrlSetOnEvent($b1, "_Button")

GUISetState(@SW_SHOW, $Form1)

While 1
    Sleep(10)
WEnd

Func _Button()
    MsgBox(0,0,0)
EndFunc

Func Quit()
Exit
EndFunc

AutoIt's various checking tools cannot cover every eventuality - the coder must take some responsibilty for using the correct syntax.

M23

[Edano]

you have on event mode, so the button must have guictrlsetonevent

[AndreyS]

))) I know that this can be! But I need to check to check the function called it a combination of keys or buttons.

The worst thing that the program falls out completely. (( If just returned an error.

Edited August 15, 2013 by AndreyS

[AndreyS]

  On 8/15/2013 at 7:04 PM, Edano said:

you have on event mode, so the button must have guictrlsetonevent

I have a program running in both the interface and through the combination. A function I use the same.

[Melba23]

AndreyS,

Then you can check within the function like this:

#include <GUIConstantsEx.au3>

Opt("GUIOnEventMode", 1)

$Form1=GUICreate("main", 200,200,100,100)
GUISetOnEvent($GUI_EVENT_CLOSE, "Quit")

$Time=GUICtrlCreateLabel("00:00",90,90)
$b1=GUICtrlCreateButton("1",10,10)
GUICtrlSetOnEvent($b1, "_Button")
$b2=GUICtrlCreateButton("2",10,50)
GUICtrlSetOnEvent($b2, "_Button")
$b3=GUICtrlCreateButton("3",10,90)
GUICtrlSetOnEvent($b3, "_Button")

GUISetState(@SW_SHOW, $Form1)

While 1
    Sleep(10)
WEnd

Func _Button()
    Switch @GUI_CtrlId
        Case $b1
            MsgBox(0,0,1)
        Case $b2
            MsgBox(0,0,2)
        Case $b3
            MsgBox(0,0,3)
    EndSwitch
EndFunc

Func Quit()
    Exit
EndFunc

Clear now?
 
M23

Edit:

I have just seen your edit above. If by "combination" you mean HotKey then you can do something like this:

expandcollapse popup

#include <GUIConstantsEx.au3>

HotKeySet("^q", "_HotKey")

Opt("GUIOnEventMode", 1)

$Form1=GUICreate("main", 200,200,100,100)
GUISetOnEvent($GUI_EVENT_CLOSE, "Quit")

$Time=GUICtrlCreateLabel("00:00",90,90)
$b1=GUICtrlCreateButton("1",10,10)
GUICtrlSetOnEvent($b1, "_Button")
$b2=GUICtrlCreateButton("2",10,50)
GUICtrlSetOnEvent($b2, "_Button")
$b3=GUICtrlCreateButton("3",10,90)
GUICtrlSetOnEvent($b3, "_Button")

GUISetState(@SW_SHOW, $Form1)

While 1
    Sleep(10)
WEnd

Func _Function($iIndex)
    MsgBox(0, 0, $iIndex)
EndFunc

Func _HotKey()
    _Function(0)
EndFunc

Func _Button()
    Switch @GUI_CtrlId
        Case $b1
            _Function(1)
        Case $b2
            _Function(2)
        Case $b3
            _Function(3)
    EndSwitch
EndFunc

Func Quit()
    Exit
EndFunc

Does that help?

M23

Edited August 15, 2013 by Melba23

[AndreyS]

It's not that. Function needs to check whether a button is pressed or a keyboard shortcut, and depending on it to carry out the following instructions. And it falls out when checking the condition.

And whatever it was, should not such a simple condition leads to crash. Do you agree?

Moreover, I know how to get around this error. But I know the importance fix it in future versions of AutoIt and when? My code will then become much easier.

Edited August 15, 2013 by Melba23
Merged posts

[Edano]

AndreyS, believe me. there is nothing wrong with autoit. your code is wrong.

[Melba23]

AndreyS,

Look at the edit I made to my post above - it shows how to use the same function when fired by a HotKey and controls.

 

  Quote

should not such a simple condition leads to crash. Do you agree?

Not at all. In your example you are going against the Help file which clearly states:

 

"@GUI_CtrlId Last click GUI Control identifier. Only valid in an event Function. See the GUICtrlSetOnEvent function"

You can hardly expect AutoIt to fail gracefully when you so blatantly ignore the required syntax.

 

  Quote

fix it in future versions of AutoIt and when?

Never. As I said, you cannot expect AutoIt to fail gracefully on every error - you have a responsibility to write code which respects the syntax rules as explained in the Help file.

M23

[AndreyS]

As it turns out too many functions! It's uncomfortable. Function to function.

 

Easier to use then there is a variable that will mean that indicating if the interface, or a combination of work and check it first.

 

Here's what to me is really the ideal:

#include <GUIConstantsEx.au3>
Opt("GUIOnEventMode", 1)

$Form1=GUICreate("main", 200,200,100,100)
Dim $b1=GUICtrlCreateButton("Start",10,10)

HotKeySet("^q", "Msg")

GUISetOnEvent($GUI_EVENT_CLOSE, "Quit")

GUISetState(@SW_SHOW, $Form1)

While 1
  Sleep(2000)
WEnd

Func Msg()
 If @GUI_CtrlId=$b1 Then 
   MsgBox(0,0,1)
 Else
   MsgBox(0,0,2)
 EndIf
EndFunc

Func Quit()
  Exit
EndFunc

Edited August 15, 2013 by AndreyS

[BrewManNH]

You have completely missed the point of what @GUI_CtrlID is supposed to be for.

[AndreyS]

Yes, all I had realized that it does not work. But the problem would be if the variable returns an error and does not lead to collapse.

It is not always the same, even working with the interface, I need to press the button first. And check if I have to press a button or any other way performed the action.

Well thank you for nothing you all for the sympathy and help!

[Melba23]

AndreyS,

For the last time - AutoIt cannot do what you are trying to do and it is clearly stated in the Help file that such an approach is not possible. So stop complaining about AutoIt crashing when you ask it to run horribly incorrect, non-syntactic code and write your scripts correctly rather than seeking changes to elements which are perfectly well-understood and used correctly by everyone else.

 

  Quote

Well thank you for nothing you all for the sympathy and help!

Not the best way to get help from us "all" in future - but on your head be it.

M23

[Edano]

  On 8/15/2013 at 7:50 PM, AndreyS said:

Well thank you for nothing

.

i can't believe it.