Help Fixing A Loop

[JohnnyVolcom5]

Hi All,

I am having some troubles.  I have a loop that moves the mouse until it finds a Hand cursor, OR moves more than 50 pixels.  If it finds a hand, it clicks the link and then does some stuff and returns to the same page it clicked only 15 pixels down (So now the hand is an arrow again).  It continues the loop and finds the next link if there is another one, but if there isnt another link the mouse travels more than 50 pixels but the loop doesnt exit.  

Hope i explained that well enough.  Here is the code.  

expandcollapse popup

Global  $MousePosy, $x=701, $y= 657 ,$MouseCur, $s= 1700

MouseMove ($x, $y,0); Move right above where the units are listed.
Do
$y= MouseGetPos (1) ;Set $y to current Mouse Pos, x position is static

$MousePosy = MouseGetPos (1) ;Set $MousePosy to current Mouse Pos.

$MouseCur = MouseGetCursor () ;See if cursor is a hand or arrow

MouseMove ($x, $MousePosy + 1,1) ;move mouse down one pixel at a time

$MouseCur = MouseGetCursor () ;get cursor type

Until $MouseCur = 16 Or $MousePosy >= $y + 50 ;determine if cursor is now a Hand or mouse traved more than 50 pixels

    If $MouseCur = 16 Then ;it found a hand, click link and close RMA
 $y= MouseGetPos (1) ;set $y to where it found the link
MouseClick ("Left", $x, $y ) ;Click the link to close RMA
Sleep ($s) ;wait for load, going to change this to search for pixel color change instead of set sleep time
MouseClick ( "Left" , 910, 1261, 1,0) ;CLick Close
MouseClick ( "Left" , 1021, 1288, 1,0) ;Save and Submit
Sleep ($s)
MouseClick ( "Left" , 910, 648, 1,0);HotSwap Click
MouseClick ( "Left" , 1021, 1288, 1,0) ;Save and Submit
Sleep ($s)
MouseClick ( "Left" , 1400, 343, 1,0); This will return to the first page where the link was clicked
Sleep ($s)
MouseMove ($x, $y +15,0) ;move to where it clicked the link before, but go down 15 pixels to get off the perviously clicked link
$y= MouseGetPos (1) ;Set $y to new mouse pos
MsgBox (0,"",$y)
ContinueLoop ;now it looks for another link

Elseif $MousePosy >= $y + 50 Then ; if while searchign for link mouse travels 50 pixels or more, EXIT LOOP.  <<<<<<<<<<<<<<<<THIS PART DOESNT EVER HAPPEN

MsgBox (0,"","Done"); WHY YOU NO WORK, ARRRRRRGH!!!
ExitLoop
EndIf

It finds and clicks all the links like it should, but it will not exit loop if it didnt find a link within 50 pixels.  

Sorry if code is poorly organized, i am noob. 

[BrewManNH]

Are you using this to automate a webpage? Have you tried the _IE* functions to do it?

[JohnnyVolcom5]

Are you using this to automate a webpage? Have you tried the _IE* functions to do it?

 

Yes for some webpage automation.  Unfortunately this page doesnt work very well with IE.  The site is poorly designed which is why i need to script this in the first place. xD

Thanks for your input though! 

[JohnnyVolcom5]

Well never mind, i managed to figure it out. 

Here is the fixed code in case anyone is wondering what i ended up with.  

expandcollapse popup

Global  $MousePosy, $x=701, $y= 657 ,$MouseCur, $s= 1700
MouseMove ($x, $y,0); Move right above where the units are listed.
$z= $y +50 ;<<<<<<<<<<<<<<<<<<<<<<<<<<<<<This is fix
Do

$y= MouseGetPos (1) ;Set $y to current Mouse Pos, x position is static

$MousePosy = MouseGetPos (1) ;Set $MousePosy to current Mouse Pos.

$MouseCur = MouseGetCursor () ;See if cursor is a hand or arrow

MouseMove ($x, $MousePosy + 1,1) ;move mouse down one pixel at a time

$MouseCur = MouseGetCursor () ;get cursor type


Until $MouseCur = 16 Or $MousePosy = $z ;determine if cursor is now a Hand or mouse traved more than 50 pixels  <<<<other part of fix

    If $MouseCur = 16 Then ;it found a hand, click link and close RMA
 $y= MouseGetPos (1) ;set $y to where it found the link
MouseClick ("Left", $x, $y ) ;Click the link to close RMA
Sleep ($s) ;wait for load, going to change this to search for pixel color change instead of set sleep time
MouseClick ( "Left" , 910, 1261, 1,0) ;CLick Close
MouseClick ( "Left" , 1021, 1288, 1,0) ;Save and Submit
Sleep ($s)
MouseClick ( "Left" , 910, 648, 1,0);HotSwap Click
MouseClick ( "Left" , 1021, 1288, 1,0) ;Save and Submit
Sleep ($s)
MouseClick ( "Left" , 1400, 343, 1,0); This will return to the first page where the link was clicked
Sleep ($s)
MouseMove ($x, $y +15,0) ;move to where it clicked the link before, but go down 15 pixels to get off the perviously clicked link
$y= MouseGetPos (1) ;Set $y to new mouse pos
MsgBox (0,"",$y)
ContinueLoop ;now it looks for another link

Elseif $MousePosy = $z Then ; if while searchign for link mouse travels 50 pixels, then there are no more unit<<<<<other part of fix

ExitLoop
EndIf
Next


MsgBox (0,"","Done")

Edited August 30, 2013 by JohnnyVolcom5