tk1 0 Posted November 6, 2014 Hello, This might be more of a best practice question than a functional one. If I put two FileInstall statements inside an If Then, will both files still be included at compile time? For example: Global $sBitness = $sBase_x32 Global $sInstaller64 = "Installer-v5.12-x64.msi" Global $sInstaller32 = "Installer-v5.12-x86.msi" ;Set bitness of OS and get external file necessary for the install file, to be included when the script is compiled. If Not @OSArch = "X86" Then $sBitness = $sBase_x64 FileInstall("C:\Installer\" & $sInstaller64, @TempDir & "\" & $sInstaller64, 1) Else FileInstall("C:\Installer\" & $sInstaller32, @TempDir & "\" & $sInstaller32, 1) EndIf Thanks in advance, tk1 Share this post Link to post Share on other sites
BrewManNH 1,254 Posted November 6, 2014 Yes Hide BrewManNH's signature Hide all signatures If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way!I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Share this post Link to post Share on other sites
tk1 0 Posted November 6, 2014 Thank you for the quick reply, BrewManNH! Share this post Link to post Share on other sites
Exit 110 Posted November 7, 2014 (edited) If I put two FileInstall statements inside an If Then, will both files still be included at compile time? No Fileinstall() will fail with message Invalid FileInstall() function during compile. Helpfile says: The source path of the file to compile. This must be a literal string; it cannot be a variable or the result of a function call. Here a working code FileInstall("C:\Installer\Installer-v5.12-x64.msi", @TempDir & "\Installer-v5.12-x64.msi", 1) FileInstall("C:\Installer\Installer-v5.12-x86.msi", @TempDir & "\Installer-v5.12-x86.msi", 1) ShellExecute(@TempDir & "\Installer-v5.12-" & @OSArch & ".msi") Edited November 7, 2014 by Exit Hide Exit's signature Hide all signatures UDF: _SingleScript() If you like my post, just click the like button here --> Share this post Link to post Share on other sites
BrewManNH 1,254 Posted November 7, 2014 Exit is correct, I missed the fact you're using a variable in the FileInstall function. But if properly written, both files will be installed. I really need to proofread what's posted better. Hide BrewManNH's signature Hide all signatures If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag GudeHow to ask questions the smart way!I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays. - ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script. - Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label. - _FileGetProperty - Retrieve the properties of a file - SciTE Toolbar - A toolbar demo for use with the SciTE editor - GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI. - Latin Square password generator Share this post Link to post Share on other sites
tk1 0 Posted November 7, 2014 (edited) Yes, and it seemed to work in my testing, but not in practice. As stated many places here, the source cannot have a variable so I changed it to be explicit and now that works. DOH! Edited November 11, 2014 by tk1 Share this post Link to post Share on other sites
