_TCPIpToName

[antmar904]

Hi

When reading a file with 26 ip addresses it can take up to two minutes to complete.  Is there a way to make this faster?  Am I doing something wrong?

expandcollapse popup

#include <Array.au3>
#include <AutoItConstants.au3>
#include <Timers.au3>
#include <Constants.au3>
#include <Inet.au3>

Local $IPList = @ScriptDir & "\IPList.txt", $LogFile = @ScriptDir & "\" & @MON & "" & @MDAY & "" & @YEAR & "_" & @HOUR & "_" & @MIN & "_LogFile.txt", $sIPs = FileReadToArray($IPList)

;_ArrayDisplay($sIPs) ;Debug

Local $StartTime = _Timer_Init()

If Not FileExists($IPList) Then
    MsgBox(48, "Error", "Missing the IPLIST.txt file : " & @CRLF & $IPList & @CRLF & @CRLF & "Please make sure it exist then run the script again.")
    Exit
EndIf

FileWriteLine($LogFile, @CRLF)
FileWriteLine($LogFile, @MON & "/" & @MDAY & "/" & @YEAR & " - " & @HOUR & ":" & @MIN & ":" & @SEC & " DNS Lookup Started" & @CRLF)

_NSLookup()

Func _NSLookup()
    For $i = 0 To UBound($sIPs) - 1
        TCPStartup()
        Local $aResult = _TCPIpToName($sIPs[$i], 0)
        If @error Then
            FileWriteLine($LogFile, $sIPs[$i] & "," & "does not exist." & @CRLF)
        Else
            FileWriteLine($LogFile, $sIPs[$i] & "," & $aResult & @CRLF)
        EndIf
    Next
EndFunc   ;==>_NSLookup

FileWriteLine($LogFile, @MON & "/" & @MDAY & "/" & @YEAR & " - " & @HOUR & ":" & @MIN & ":" & @SEC & " DNS Lookup Ended." & @CRLF)

Local $DiffTime = _Timer_Diff($StartTime)
Local $EndTime = $DiffTime / 60000
Local $sTime = StringTrimRight($EndTime, 12)
FileWriteLine($LogFile, @MON & "/" & @MDAY & "/" & @YEAR & " - " & @HOUR & ":" & @MIN & ":" & @SEC & " Total script runtime: " & $sTime & " Minutes.")

Exit

 

[BrewManNH]

Try taking the TCPStartUp out of the loop, put it before the start of the For loop. Also, after the loop put a TCPShutdown function call to close it.

Func _NSLookup()
    TCPStartup()
    For $i = 0 To UBound($sIPs) - 1
        Local $aResult = _TCPIpToName($sIPs[$i], 0)
        If @error Then
            FileWriteLine($LogFile, $sIPs[$i] & "," & "does not exist." & @CRLF)
        Else
            FileWriteLine($LogFile, $sIPs[$i] & "," & $aResult & @CRLF)
        EndIf
    Next
    TCPShutdown()
EndFunc   ;==>_NSLookup

 

[antmar904]

49 minutes ago, BrewManNH said:

Try taking the TCPStartUp out of the loop, put it before the start of the For loop. Also, after the loop put a TCPShutdown function call to close it.

Func _NSLookup()
    TCPStartup()
    For $i = 0 To UBound($sIPs) - 1
        Local $aResult = _TCPIpToName($sIPs[$i], 0)
        If @error Then
            FileWriteLine($LogFile, $sIPs[$i] & "," & "does not exist." & @CRLF)
        Else
            FileWriteLine($LogFile, $sIPs[$i] & "," & $aResult & @CRLF)
        EndIf
    Next
    TCPShutdown()
EndFunc   ;==>_NSLookup

 

Thanks @BrewManNH but that did not make any difference.  Ill try other options.

Edited January 26, 2018 by antmar904

[Subz]

Place a ping into the loop for example:

Func _NSLookup()
    TCPStartup()
    For $i = 0 To UBound($sIPs, 500) - 1
        If Ping($sIPs[$i]) = 0 Then ContinueLoop
        Local $aResult = _TCPIpToName($sIPs[$i], 0)
        If @error Then
            FileWriteLine($LogFile, $sIPs[$i] & "," & "does not exist." & @CRLF)
        Else
            FileWriteLine($LogFile, $sIPs[$i] & "," & $aResult & @CRLF)
        EndIf
    Next
    TCPShutdown()
EndFunc   ;==>_NSLookup

 

Edited January 26, 2018 by Subz
Added Ping ms

[BrewManNH]

If neither of these help,then there's probably not a lot to do to speed it up. It's calling Microsoft DLLs to do the work, so it's a Microsoft issue at that point.