_GUICtrlTreeView_Sort

[Andreik]

Is this the intended behavior of this function or this is a bug? At least a check should be performed in case there is just an item to return without sorting anything.

Func _GUICtrlTreeView_Sort($hWnd)
    If Not IsHWnd($hWnd) Then $hWnd = GUICtrlGetHandle($hWnd)

    Local $iItemCount = _GUICtrlTreeView_GetCount($hWnd)    ; <------------- if $iItemCount = 1
    If $iItemCount Then
        Local $aTreeView[$iItemCount], $i = 0               ; <------------- this array has just an index
        ; get only A child at each level
        Local $hHandle = _GUICtrlTreeView_GetFirstItem($hWnd)
        $aTreeView[1] = $hHandle                            ; <------------- and this would fail
        $aTreeView[0] = 2
        __GUICtrlTreeView_SortGetFirstChild($hWnd, $hHandle, $aTreeView)
        ReDim $aTreeView[$aTreeView[0]]
        $aTreeView[0] = 0

        For $i = 0 To UBound($aTreeView) - 1
            _SendMessage($hWnd, $TVM_SORTCHILDREN, 0, $aTreeView[$i], 0, "wparam", "handle") ; Sort the items in root
        Next
    EndIf

EndFunc   ;==>_GUICtrlTreeView_Sort

 

[BrewManNH]

If $iItemcount is 1 then the array only has an element at 0, not at 0 and 1 so you can't put anything into the array at 0 and 1 because there is no 1.

[Andreik]

That's exactly what I said, there should be at least a basic validation if $iItemCount = 1 and return. For an UDF function it's quite strange to throw an error that array variable has incorrect number of subscripts or subscript dimension range exceeded.

[BrewManNH]

1 hour ago, Andreik said:

For an UDF function it's quite strange to throw an error that array variable has incorrect number of subscripts or subscript dimension range exceeded.

Yes it's a bug, they happen even in UDFs. Most people aren't trying to sort empty treeviews, which is probably why this error never came up before.