_ValidUserPass - when password has %

[gcue]

Hello.

See many examples of folks using this function

Func _ValidUserPass($username, $computer, $password)

    Local $valid = True
    RunAs($username, $computer, $password, 0, @ComSpec & " /c echo test", @SystemDir, @SW_HIDE)
    If @error Then $valid = False
    Return $valid

EndFunc   ;==>_ValidUserPass

Been working great for me for years - thanks to original poster (not sure who it was).

I've seen an issue when password has the following characters "%%%"

I've tried putting double quotes and single quotes around the password variable but no luck.

Any other thoughts or ideas?

Thanks in advance! 

Edited September 19, 2020 by gcue

[pseakins]

This sounds a bit like the issue of a DOS batch argument requiring the percent character to be escaped by adding an additional percent.

Have you tried adding a leading "%" to every "%" in the arguments?

[gcue]

i tried the following and it didnt work 

$password = stringreplace($password, "%", "%%")

thanks for the suggestion - seemed promising. 

not sure what else to try 

[jerem488]

Func _ValidUserPass($username, $computer, $password)

    Local $valid = True
    RunAs($username, $computer, "'" & $password & "'", 0, @ComSpec & " /c echo test", @SystemDir, @SW_HIDE)
    $a_Password = StringSplit($password, "")
    For $i = 1 To $a_Password[0]
        If Asc($a_Password[$i]) = "&" Then
            ; Your code here
        EndIf
    Next
    If @error Then $valid = False
    Return $valid

EndFunc   ;==>_ValidUserPass

 

[Exit]

4 hours ago, gcue said:

$password = stringreplace($password, "%", "^%")$password = stringreplace($password, "%", "%%")

 

or perhaps 

$password = stringreplace($password, "%", "^%")

 

[pseakins]

17 hours ago, jerem488 said:

If Asc($a_Password[$i]) = "&" Then

This expression can never be true as the ASCII value of any character is always numeric.

Also, if the value of @error is to be used to assign a value to a variable it should be assigned immediately after the function or statement that was used to set it. @error is somewhat dynamic and the value can change with every statement. You can't just arbitrarily grab its value and expect it to be representative of what you are testing.

[gcue]

neither worked.  i know dos uses % to declare a %variable% so i would have thought quotes would have been read differently.  but single or double quotes didnt fix the issue

[seadoggie01]

I don't have the ability to test this, so have you seen this issue elsewhere? It seems strange that the RunAs function would use the command line to run our programs internally. Are you sure you have the right password? (As stupid as it sounds, I've been there)

Edited September 21, 2020 by seadoggie01

[gcue]

other passwords work fine.  i do have the right password for sure

[pseakins]

I would run tests to prove that it is the "%" causing the problem. Setup an account with a plain alphanumeric password and run a script that does work. Then add a single percent to the password and see what happens. You need a definitive pass/fail benchmark. If it fails you should change the position of the percent, beginning, middle, end to see if that changes anything.

[gcue]

good idea ill try that - thanks!

[Atrax27]

In some cases I've found {%}{%}{%} to work.