GUIDarkTheme UDF

[UEZ]

3 hours ago, WildByDesign said:

I notice that you quite often use StringLower in your switches when comparing class names in a few areas. Is this a choice specifically for improving performance of running through the switches?

It started with copy / paste and continued without the need of StringLower because string compare is not case sensitive in Autoit -> can be removed to improve performance.

3 hours ago, WildByDesign said:

Regarding window procedure functions. We can have many individual window procedure functions for different controls or we can have one big window procedure function for all subclassed controls. Would there be any difference in overall performance?

I would say use a hybrid approach using one shared function for controls that behave identically and dedicated functions for complex controls like the ListView, TreeView, etc.

Messages like WM_MOUSEMOVE or WM_NCHITTEST fire constantly and it doesn't make sense regarding performance to have huge different Case statements for every pixel the mouse moves, Also drawing complex GDI+ functions in WM_PAINT or WM_ERASEBKGND may reduce the overall performance.

 

[bladem2003]

Running the code below results in an error in GUIDarkTheme.au3.

Func _GUIDarkTheme_GUICtrlAllSetDarkTheme($g_hGuiWnd, $bEnableDarkTheme = True, $bPreferNewTheme = False)

 

#include <WindowsConstants.au3>
#include <GUIConstantsEx.au3>
#include <StaticConstants.au3>
#include <File.au3>
#include <String.au3>
#include <Array.au3>
#include "GuiCtrls_HiDpi.au3"
#include "GUIDarkTheme.au3"


$hGui = GUICreate("", 300, 200)

#Region MENU
Local $idMenu1 = GUICtrlCreateMenu("Menu &One")
Local $idMenu2 = GUICtrlCreateMenu("Menu &Two")
#EndRegion MENU

_GUIDarkTheme_ApplyDark($hGui)
GUISetState()

While 1
    Sleep(10)
    $msg = GUIGetMsg()
    If $msg = $GUI_EVENT_CLOSE Then Exit
WEnd

 

An @error check fixes the error.

 

Func _GUIDarkTheme_GUICtrlAllSetDarkTheme($g_hGuiWnd, $bEnableDarkTheme = True, $bPreferNewTheme = False)
    Local $aCtrls = __WinAPI_EnumChildWindows($g_hGuiWnd, False)
    If @error = 0 Then
        For $i = 1 To $aCtrls[0][0]
            _GUIDarkTheme_GUICtrlSetDarkTheme($aCtrls[$i][0], $bEnableDarkTheme, $bPreferNewTheme)
        Next
    EndIf
    Local $aCtrlsEx = __WinAPI_EnumProcessWindows(0, False) ; allows getting handles for tooltips_class32, ComboLBox, etc.
    For $i = 1 To $aCtrlsEx[0][0]
        _GUIDarkTheme_GUICtrlSetDarkTheme($aCtrlsEx[$i][0], $bEnableDarkTheme, $bPreferNewTheme)
    Next
    Return $aCtrls
EndFunc   ;==>_GUIDarkTheme_GUICtrlAllSetDarkTheme

 

Edited Thursday at 08:06 PM by bladem2003

[WildByDesign]

38 minutes ago, bladem2003 said:

An @error check fixes the error.

Nice work and thank you for the fix.

I knew that there was a crash when there were no controls added but I had no idea exactly where the crash was coming from. So I appreciate that you figured it out.

By the way, should there be an @error check on the second loop as well?

[argumentum]

17 minutes ago, WildByDesign said:

...should there be an @error check..

..just passing by.
@error checking should be done everywhere.
We add it only after we experience and error but somebody else may crash because of "that didn't happen to me when..." and I call BS !
So yes, do add @error checking everywhere, or at least where the failure would crash the script.

[bladem2003]

That can't be wrong, so do it. 😉

PS: Thanks for your excellent work!

It's incredible that you have so much time and manage to accomplish all of this.

 

I'd like to mention that almost all of my posts are translated by Google Translate. Sorry.

 

Edited Thursday at 10:10 PM by bladem2003

[WildByDesign]

I seem to have a bit of a roadblock in the overhauling/reorganizing of the window procedures used for subclassing. I am trying to organize things better but also make it so that it can support multiple of the same control types (eg. 2 or 3 ListViews, etc.). If this UDF is to be used on any AutoIt GUI, it would need to support multiple of any control type.

EDIT: I have resolved this issue now.

Edited 5 hours ago by WildByDesign