whats wrong with this script?

[ReaImDown]

this script only works sometimes, its odd and picky lol

$Sleep = Random(1 * 1000, 20 * 1000, 1)
$RSleep = ($Sleep + Random(1 * 1000, 20 * 1000, 1))
$i = 1
Do
    If WinActive("Mozilla") Then
        If WinActive("Facebook") Then
            ;Sleep($RSleep)
            WinClose("Facebook")
            msgbox(0 , "Error,", "Firefox has detected an error in the sites scripting")
        ElseIf WinActive("MySpace") Then
            ;Sleep($RSleep)
            WinClose("MySpace")
            msgbox(0 , "Error,", "Firefox has detected an error in the sites scripting")
        EndIf
    EndIf
    If WinActive("Internet Explorer") Then
        If WinActive("Facebook") Then
            ;Sleep($RSleep)
            WinClose("Facebook")
            msgbox(0 , "Error,", "Firefox has detected an error in the sites scripting")
        ElseIf WinActive("MySpace") Then
            ;Sleep($RSleep)
            WinClose("MySpace")
            msgbox(0 , "Error,", "Firefox has detected an error in the sites scripting")
        EndIf
    EndIf
Until $i = 0

[Zedna]

This is strange:

If WinActive("Mozilla") Then
        If WinActive("Facebook") Then

If first If is true then second never be true!

[ReaImDown]

This is strange:

If WinActive("Mozilla") Then
        If WinActive("Facebook") Then

If first If is true then second never be true!

figured, but how would I go about making it work? lol

[Zedna]

figured, but how would I go about making it work? lol

Look at AdlibEnable()

[1905russell]

That Do.. Until seems to be the problem.

This works for me.

Opt("WinTitleMatchMode", 2)
$Sleep = Random(1 * 1000, 20 * 1000, 1)
$RSleep = ($Sleep + Random(1 * 1000, 20 * 1000, 1))
HotKeySet("{PAUSE}", "Doit")
$i = 1
Do 
Until $i = 0

Func Doit()
    If WinActive("Mozilla") Then
        If WinActive("Facebook") Then
    ;Sleep($RSleep)
            WinClose("Facebook")
            MsgBox(0, "Error,", "Firefox has detected an error in the sites scripting")
        ElseIf WinActive("MySpace") Then
    ;Sleep($RSleep)
            WinClose("MySpace")
            MsgBox(0, "Error,", "Firefox has detected an error in the sites scripting")
        EndIf
    EndIf
    If WinActive("Internet Explorer") Then
        If WinActive("Facebook") Then
    ;Sleep($RSleep)
            WinClose("Facebook")
            MsgBox(0, "Error,", "Firefox has detected an error in the sites scripting")
        ElseIf WinActive("MySpace") Then
    ;Sleep($RSleep)
            WinClose("MySpace")
            MsgBox(0, "Error,", "Firefox has detected an error in the sites scripting")
        EndIf
    EndIf
EndFunc ;==>Doit

Edited June 1, 2007 by 1905russell

[ReaImDown]

ty...this works, guess I needed the opt

Opt("WinTitleMatchMode", 2)
$Sleep = Random(1 * 1000, 20 * 1000, 1)
$RSleep = ($Sleep + Random(1 * 1000, 20 * 1000, 1))
$i = 1
Do
    If WinActive("Mozilla") Then
        If WinActive("Facebook") Then
            ;Sleep($RSleep)
            WinClose("Facebook")
            msgbox(0 , "Error,", "Firefox has detected an error in the sites scripting")
        ElseIf WinActive("MySpace") Then
            ;Sleep($RSleep)
            WinClose("MySpace")
            msgbox(0 , "Error,", "Firefox has detected an error in the sites scripting")
        EndIf
    EndIf
    If WinActive("Internet Explorer") Then
        If WinActive("Facebook") Then
            ;Sleep($RSleep)
            WinClose("Facebook")
            msgbox(0 , "Error,", "Internet Explorer has detected an error in the sites scripting")
        ElseIf WinActive("MySpace") Then
            ;Sleep($RSleep)
            WinClose("MySpace")
            msgbox(0 , "Error,", "Internet Explorer has detected an error in the sites scripting")
        EndIf
    EndIf
Until $i = 0

Edited June 1, 2007 by ReaImDown