i need help with a script

[the_lord_mephy]

Alrite well this is a semi-pointless script but i just made it for fun.

$dir = InputBox("Enter Directory Name", "Please enter a directory. If it does not exist it will be created", "C:\")
If @error = 1 Then
   Exit
EndIf
If FileExists($dir) Then
   MsgBox(0, "Directory Existed", "Directory: " &$dir& " was found.")
EndIf
If NOT FileExists($dir) then 
   DirCreate($dir)
   MsgBox(0, "Directory Created", "Directory: " &$dir& " created.")
EndIf
$goto = MsgBox(4, "Go there?", "Would you like to go there now?")
Sleep("200")
If $goto = 6 Then
   Run("Explorer " & $dir)
EndIf
$makefile = MsgBox(4, "Create files", "Would you like to create a file in this directory")
$dirend = StringRight($dir, 1)
If $makefile = 6 Then
   $filename = InputBox("File Name", "Please select a name for the follow (including the extention)")
   $filecontent = InputBox("File Content", "Please include the content to go into the file")
   If $dirend = "\" Then
      FileWrite($dir & $filename, $filecontent)
   EndIf
   If Not $dirend = "\" Then
      FileWrite($dir & "\" & $filename, $filecontent)
   EndIf
EndIf

What i dont understand is, if someone makes the source of the directory without a \ at the end, the script wont create the file. the code i wrote for it seems pretty logical :

If Not $dirend = "\" Then
      FileWrite($dir & "\" & $filename, $filecontent)
   EndIf

but i guess theres something wrong with it. plz help

Also i have another question. Does auto it unzip files?

Edited September 9, 2004 by the_lord_mephy

[Matt @ MPCS]

You are correct, this is a VERY worthless script. Are you new to programming?

Well here is the solution to your request:

$dir = InputBox("Enter Directory Name", "Please enter a directory. If it does not exist it will be created", "C:\")
If @error = 1 Then
   Exit
EndIf
If FileExists($dir) Then
   MsgBox(0, "Directory Existed", "Directory: " &$dir& " was found.")
EndIf
If NOT FileExists($dir) then 
   DirCreate($dir)
   MsgBox(0, "Directory Created", "Directory: " &$dir& " created.")
EndIf
$goto = MsgBox(4, "Go there?", "Would you like to go there now?")
Sleep("200")
If $goto = 6 Then
   Run("Explorer " & $dir)
EndIf
$makefile = MsgBox(4, "Create files", "Would you like to create a file in this directory")
$dirend = StringRight($dir, 1)
If $makefile = 6 Then
   $filename = InputBox("File Name", "Please select a name for the follow (including the extention)")
   $filecontent = InputBox("File Content", "Please include the content to go into the file")
   If $dirend = "\" Then
      FileWrite($dir & $filename, $filecontent)
   Else
      FileWrite($dir & "\" & $filename, $filecontent)
   EndIf
EndIf

This works, but I don't understand why you had 2 if statements in the first place. For future reference, the Else command picks up all instances where the If and elseif conditions are not met. This could also be written:

$dir = InputBox("Enter Directory Name", "Please enter a directory. If it does not exist it will be created", "C:\")
If @error = 1 Then
   Exit
EndIf
If FileExists($dir) Then
   MsgBox(0, "Directory Existed", "Directory: " &$dir& " was found.")
EndIf
If NOT FileExists($dir) then 
   DirCreate($dir)
   MsgBox(0, "Directory Created", "Directory: " &$dir& " created.")
EndIf
$goto = MsgBox(4, "Go there?", "Would you like to go there now?")
Sleep("200")
If $goto = 6 Then
   Run("Explorer " & $dir)
EndIf
$makefile = MsgBox(4, "Create files", "Would you like to create a file in this directory")
$dirend = StringRight($dir, 1)
If $makefile = 6 Then
   $filename = InputBox("File Name", "Please select a name for the follow (including the extention)")
   $filecontent = InputBox("File Content", "Please include the content to go into the file")
   If $dirend = "\" Then
      FileWrite($dir & $filename, $filecontent)
   ElseIf NOT( $dirend = "\" ) Then
      FileWrite($dir & "\" & $filename, $filecontent)
   EndIf
EndIf

But the extra code is not needed, and the way you had it written had the potential of writting the file twice, or not at all. You may consider revisiting the basics before writting anymore code. Thanks!

*** Matt @ MPCS

[the_lord_mephy]

yes, im new to programming. its realy hard to do this but i am just writing a bunch of scripts that use like everything to get to know what everything does. i have no idea how you guys make big programs but iguess i will learn