RegWrite function

[Iuli]

Hi,

I'm quite new to AutoIT programming.

Here's my problem : When i try to compile a program i wrote i get the following error :

D:\Unlimited Projects\temp\XtraApps\ViApply.au3(8,115) : ERROR: syntax error (illegal character)
    RegWrite("HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run","ViOrb","REG_SZ",@ProgramFilesDir & "\ViStart\ViStart.exe")

What have i did wrong ?

Edited September 7, 2007 by Iuli

[silvano]

Hi,

I'm quite new to AutoIT programming.

Here's my problem : When i try to compile a program i wrote i get the following error :

D:\Unlimited Projects\temp\XtraApps\ViApply.au3(8,115) : ERROR: syntax error (illegal character)
    RegWrite("HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run","ViOrb","REG_SZ",@ProgramFilesDir & "\ViStart\ViStart.exe")

What have i did wrong ?

hi and welcome,

post yuor code until line 8

regwrite is correct and work fine

Edited September 7, 2007 by silvano

[PsaltyDS]

hi and welcome,

post yuor code until line 8

regwrite is correct and work fine

I think he's got an unpaired single or double quote, or an open paren with no close.. etc., on a line above that one.

[Iuli]

Ok, here's my code:

$mem = MemGetStats() 
;MsgBox(0, " The ammount of memory", "You have " & $mem[1] & " KB of RAM")
DirCopy(@ScriptDir & "\Movie Maker",@ProgramFilesDir & "\Movie Maker",1)
If $mem[1] > 510000 Then
    DirCopy(@ScriptDir & "\ViStart",@ProgramFilesDir & "\ViStart",1)
    RegWrite("HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run","ViStart","REG_SZ", @ProgramFilesDir & "\ViStart\ViStart.exe")
    DirCopy(@ScriptDir & "\ViOrb",@ProgramFilesDir & "\ViOrb",1)
    RegWrite("HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run","ViOrb","REG_SZ", @ProgramFilesDir & "\ViOrb\ViOrb.exe')
    DirCopy(@ScriptDir & "\LClock",@ProgramFilesDir & "\LClock",1)
    RegWrite("HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run","LClock","REG_SZ", @ProgramFilesDir & "\LClock\LClock.exe')
    DirCopy(@ScriptDir & "\Sidebar",@ProgramFilesDir & "\Sidebar",1)
    RegWrite("HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run","Sidebar","REG_SZ", @ProgramFilesDir & "\Sidebar\Sidebar.exe')
    DirCopy(@ScriptDir & "\ToolTip",@ProgramFilesDir & "\ToolTip",1)
    RegWrite("HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run","ToolTip","REG_SZ", @ProgramFilesDir & "\ToolTip\VisualToolTip.exe')
    DirCopy(@ScriptDir & "\Yodm3D",@ProgramFilesDir & "\Yodm3D",1)
    RegWrite("HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run","Yodm3D","REG_SZ", @ProgramFilesDir & "\Yodm3D\Yodm3D.exe')
    DirCopy(@ScriptDir & "\GlassToast",@ProgramFilesDir & "\GlassToast",1)
    RegWrite("HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run","GlassToast","REG_SZ", @ProgramFilesDir & "\GlassToast\GlassToas.exe')
    DirCopy(@ScriptDir & "\Madotate",@ProgramFilesDir & "\Madotate",1)
    RegWrite("HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run","Madotate","REG_SZ", @ProgramFilesDir & "\Madotate\Madotate.exe')
    Run(@ScriptDir & "\TopDesk\TopDesk153Setup.exe" & " /S /NCRC",@SW_HIDE)
    WinWaitClose("TopDesk 1.5.3 Setup")
Else
    DirCopy(@ScriptDir & "\WinFlip",@ProgramFilesDir & "\WinFlip",1)
    RegWrite("HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run","WinFlip","REG_SZ", @ProgramFilesDir & "\WinFlip\WinFlip.exe')
    Run(@ScriptDir & "VisualPatch.exe" & " /S /NCRC",@SW_HIDE)
EndIf   
Exit

Edited September 8, 2007 by Iuli

[MHz]

Welcome,

And here is fixed code.

$mem = MemGetStats()
;MsgBox(0, " The ammount of memory", "You have " & $mem[1] & " KB of RAM")
DirCopy(@ScriptDir & "\Movie Maker", @ProgramFilesDir & "\Movie Maker", 1)
If $mem[1] > 510000 Then
    DirCopy(@ScriptDir & "\ViStart", @ProgramFilesDir & "\ViStart", 1)
    RegWrite("HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Run", "ViStart", "REG_SZ", '"' & @ProgramFilesDir & '\ViStart\ViStart.exe"')
    DirCopy(@ScriptDir & "\ViOrb", @ProgramFilesDir & "\ViOrb", 1)
    RegWrite("HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Run", "ViOrb", "REG_SZ", '"' & @ProgramFilesDir & '\ViOrb\ViOrb.exe"')
    DirCopy(@ScriptDir & "\LClock", @ProgramFilesDir & "\LClock", 1)
    RegWrite("HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Run", "LClock", "REG_SZ", '"' & @ProgramFilesDir & '\LClock\LClock.exe"')
    DirCopy(@ScriptDir & "\Sidebar", @ProgramFilesDir & "\Sidebar", 1)
    RegWrite("HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Run", "Sidebar", "REG_SZ", '"' & @ProgramFilesDir & '\Sidebar\Sidebar.exe"')
    DirCopy(@ScriptDir & "\ToolTip", @ProgramFilesDir & "\ToolTip", 1)
    RegWrite("HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Run", "ToolTip", "REG_SZ", '"' & @ProgramFilesDir & '\ToolTip\VisualToolTip.exe"')
    DirCopy(@ScriptDir & "\Yodm3D", @ProgramFilesDir & "\Yodm3D", 1)
    RegWrite("HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Run", "Yodm3D", "REG_SZ", '"' & @ProgramFilesDir & '\Yodm3D\Yodm3D.exe"')
    DirCopy(@ScriptDir & "\GlassToast", @ProgramFilesDir & "\GlassToast", 1)
    RegWrite("HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Run", "GlassToast", "REG_SZ", '"' & @ProgramFilesDir & '\GlassToast\GlassToas.exe"')
    DirCopy(@ScriptDir & "\Madotate", @ProgramFilesDir & "\Madotate", 1)
    RegWrite("HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Run", "Madotate", "REG_SZ", '"' & @ProgramFilesDir & '\Madotate\Madotate.exe"')
    Run('"' & @ScriptDir & '\TopDesk\TopDesk153Setup.exe /S /NCRC"', '', @SW_HIDE)
    WinWaitClose("TopDesk 1.5.3 Setup")
Else
    DirCopy(@ScriptDir & "\WinFlip", @ProgramFilesDir & "\WinFlip", 1)
    RegWrite("HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Run", "WinFlip", "REG_SZ", '"' & @ProgramFilesDir & '\WinFlip\WinFlip.exe"')
    Run('"' & @ScriptDir & '\VisualPatch.exe" /S /NCRC', '', @SW_HIDE)
EndIf
Exit

If you open a string with a double quote, then you need close the string with a double quote i.e. "string". Same goes for single quotes i.e 'string'. Single quotes can help retain double quotes as in the fixed code above so your paths with spaces will not error when executed from the registry.

Edit:

Your Run() funcs were missing the workingdir parameter also.

Edited September 8, 2007 by MHz

[Iuli]

Thnx for the fix. As i said, i'm new to AutoIT !