Need Help with Script!

[Xonos]

I am lost! I cannot add a 3rd menu item. Basically I want to add one more function but I cannot get it to work.

expandcollapse popup

; Group Policy : QuickPolicy Installer v1.0 DR-1
; Author: Timothy A. Wood
; Date: 06/01/08
; Lexen802@gmail.com
#include <GUIConstants.au3>

GUICreate("QuickPolicy Installer", 255, 110, 255, 255)
GUICtrlCreateLabel("Please select which GroupPolicy you wish to install.", 5, 5)
$buttonInstall = GUICtrlCreateButton("Install", 95, 75, 60)
$comboInstallType = GUICtrlCreateCombo("Staff", 93, 40, 65, $CBS_DROPDOWN)
GUICtrlSetData($comboInstallType, "Lab", "Staff")
GUISetState()
GUISetState(@SW_SHOW)

While 1
$msg = GUIGetMsg()
Select
Case $msg = $GUI_EVENT_CLOSE
ExitLoop
Case $msg = $buttonInstall
If GUICtrlRead($comboInstallType) = "Staff" Then
_StudentInstall()
Else
_MasterInstall()
EndIf
ExitLoop
EndSelect
WEnd

Func _StudentInstall()
$Staff = IniRead("gpconfig.ini", "Configuration", "Staff", "NotFound")
$StaffDest = IniRead("gpconfig.ini", "Configuration", "StaffDest", "NotFound")
DirCopy($Staff, $StaffDest, 1)
MsgBox(4096, "QuickPolicy Installer", "Staff Group Policy Installed Successfully!", 10)
EndFunc

Func _MasterInstall()
$Lab = IniRead("gpconfig.ini", "Configuration", "Lab", "NotFound")
$LabDest = IniRead("gpconfig.ini", "Configuration", "LabDest", "NotFound")
DirCopy($Lab, $LabDest, 1)
MsgBox(4096, "QuickPolicy Installer", "Lab Group Policy Installed Successfully!", 10)
EndFunc

This is what I am trying but it does not work.

expandcollapse popup

; Group Policy : QuickPolicy Installer v1.0 DR-1
; Author: Timothy A. Wood
; Date: 06/01/08
; Lexen802@gmail.com
#include <GUIConstants.au3>

GUICreate("QuickPolicy Installer", 255, 110, 255, 255)
GUICtrlCreateLabel("Please select which GroupPolicy you wish to install.", 5, 5)
$buttonInstall = GUICtrlCreateButton("Install", 95, 75, 60)
$comboInstallType = GUICtrlCreateCombo("Staff", 93, 40, 65, $CBS_DROPDOWN)
GUICtrlSetData($comboInstallType, "Lab", "Staff", "Laptop")
GUISetState()
GUISetState(@SW_SHOW)

While 1
$msg = GUIGetMsg()
Select
Case $msg = $GUI_EVENT_CLOSE
ExitLoop
Case $msg = $buttonInstall
If GUICtrlRead($comboInstallType) = "Staff" Then
_StudentInstall()
If GUICtrlRead($comboInstallType) = "Laptop" Then
_LaptopInstall()
Else
_MasterInstall()
EndIf
ExitLoop
EndSelect
WEnd

Func _LaptopInstall()
MsgBox(4096, "QuickPolicy Installer", "Laptops!!!!", 10)
EndFunc

Func _StudentInstall()
$Staff = IniRead("gpconfig.ini", "Configuration", "Staff", "NotFound")
$StaffDest = IniRead("gpconfig.ini", "Configuration", "StaffDest", "NotFound")
DirCopy($Staff, $StaffDest, 1)
MsgBox(4096, "QuickPolicy Installer", "Staff Group Policy Installed Successfully!", 10)
EndFunc

Func _MasterInstall()
$Lab = IniRead("gpconfig.ini", "Configuration", "Lab", "NotFound")
$LabDest = IniRead("gpconfig.ini", "Configuration", "LabDest", "NotFound")
DirCopy($Lab, $LabDest, 1)
MsgBox(4096, "QuickPolicy Installer", "Lab Group Policy Installed Successfully!", 10)
EndFunc

Can anyone show me how to fix this?

[Airwolf]

You're missing an EndIf in your loop. There were a few issues with your combo box declaration as well. I tested this and it works:

expandcollapse popup

; Group Policy : QuickPolicy Installer v1.0 DR-1
; Author: Timothy A. Wood
; Date: 06/01/08
; Lexen802@gmail.com
#include <GUIConstants.au3>

GUICreate("QuickPolicy Installer", 255, 110, 255, 255)
GUICtrlCreateLabel("Please select which GroupPolicy you wish to install.", 5, 5)
$buttonInstall = GUICtrlCreateButton("Install", 95, 75, 60)
$comboInstallType = GUICtrlCreateCombo("", 93, 40, 65, $CBS_DROPDOWN)
GUICtrlSetData($comboInstallType, "Lab|Staff|Laptop")
GUISetState(@SW_SHOW)

While 1
    $msg = GUIGetMsg()
    Select
        Case $msg = $GUI_EVENT_CLOSE
            ExitLoop
        Case $msg = $buttonInstall
            If GUICtrlRead($comboInstallType) = "Staff" Then
                _StudentInstall()
            EndIf
            If GUICtrlRead($comboInstallType) = "Laptop" Then
                _LaptopInstall()
            Else
                _MasterInstall()
            EndIf
            ExitLoop
    EndSelect
WEnd

Func _LaptopInstall()
MsgBox(4096, "QuickPolicy Installer", "Laptops!!!!", 10)
EndFunc

Func _StudentInstall()
    $Staff = IniRead("gpconfig.ini", "Configuration", "Staff", "NotFound")
    $StaffDest = IniRead("gpconfig.ini", "Configuration", "StaffDest", "NotFound")
    DirCopy($Staff, $StaffDest, 1)
    MsgBox(4096, "QuickPolicy Installer", "Staff Group Policy Installed Successfully!", 10)
EndFunc

Func _MasterInstall()
    $Lab = IniRead("gpconfig.ini", "Configuration", "Lab", "NotFound")
    $LabDest = IniRead("gpconfig.ini", "Configuration", "LabDest", "NotFound")
    DirCopy($Lab, $LabDest, 1)
    MsgBox(4096, "QuickPolicy Installer", "Lab Group Policy Installed Successfully!", 10)
EndFunc

[Xonos]

Thanks a Lot!!!!!!! Hey, i'm trying to add "Staff" back as the default item. I added it but it doesn't exactly have a function declared for it so it doesn't work.

Edited June 2, 2008 by Richardo

[Airwolf]

Thanks a Lot!!!!!!! Hey, i'm trying to add "Staff" back as the default item. I added it but it doesn't exactly have a function declared for it so it doesn't work.

Change this:

$comboInstallType = GUICtrlCreateCombo("", 93, 40, 65, $CBS_DROPDOWN)
GUICtrlSetData($comboInstallType, "Lab|Staff|Laptop")

To this:

$comboInstallType = GUICtrlCreateCombo("Staff", 93, 40, 65, $CBS_DROPDOWN)
GUICtrlSetData($comboInstallType, "Lab|Laptop")