Having a problem with "Random()"

[Valuater]

I would think this should return a "1"

$Number = Random(1,1,1)

MsgBox(0x0,"", $Number)

but...not!!!...???

I am looping though an array and it gets down to $x being a 1..

$Number = Random(1,$x,1)

then it errors by returning a "0"

8)

v3.2.12.0

win xp sp3

Edited June 3, 2008 by Valuater

[Airwolf]

$Number = Random(1,1,1)
MsgBox(0x0,"", $Number)

This does return a 1... at least, it did for me. Are you sure the value of $x is 1 when you have the problem?

Edited June 3, 2008 by Airwolf123

[herewasplato]

What version of AutoIt are your two using...

I always get a 0 using Val's code using v3.2.12.0

Edit: or this code...

ConsoleWrite(@CR)
For $i = 1 To 10
    $Number = Random(1, 1, 1)
    ConsoleWrite($Number & @CR)
Next
ConsoleWrite(@CR)

Edited June 3, 2008 by herewasplato

[Valuater]

What version of AutoIt are your two using...

I always get a 0 using Val's code using v3.2.12.0

Edit: or this code...

ConsoleWrite(@CR)
For $i = 1 To 10
    $Number = Random(1, 1, 1)
    ConsoleWrite($Number & @CR)
Next
ConsoleWrite(@CR)oÝ÷ Ûú®¢×­+&mmæ¥Ûezj+z·©­ëÖ­÷¨~Ø^¦ºjëh×6For $x = 5 To 1 Step -1

    $Number = Random(1, $x, 1)
    MsgBox(0x0, $x, $Number, 2)

Next

thx

8)

[herewasplato]

this might be a little more representative of the prob...

For $x = 5 To 1 Step -1

    $Number = Random(1, $x, 1)
    MsgBox(0x0, $x, $Number, 2)

Next

thx

8)

I know that is like the code that you are having problems with but you only get Random(1, $x, 1) to be Random(1, 1, 1) one time in that code.

I was going for a repetition of Random(1, 1, 1)

I get zero 10 out of 10 times with my little loop :-(

What version of AutoIt are you using Val?

[nikink]

works fine for me with 3.2.10

How odd!

[Valuater]

I see.... 3.2.12.0

For $x = 5 To 1 Step -1

$Number = Random(1, $x, 1)

ConsoleWrite( "x=" & $x & " Num=" & $Number & @CRLF)

Next

Example output

x=5 Num=2

x=4 Num=3

x=3 Num=3

x=2 Num=2

x=1 Num=0

8)

[herewasplato]

Yep - a 1000 1s using v3.2.10.0

ConsoleWrite(@CR)
For $i = 1 To 1000
    $Number = Random(1, 1, 1)
    ConsoleWrite($Number & @CR)
Next
ConsoleWrite(@CR)

...Hmmmmm

[enaiman]

Weird,

ConsoleWrite(@CR)
For $i = 1 To 10
    $Number = Random(1, 1, 1)
    ConsoleWrite($Number & @CR)
Next
ConsoleWrite(@CR)

3.2.10.0 always returns 1

3.2.11.1 always returns 0

(tested 1000)

[herewasplato]

...and a 1000 0s using v3.2.12.0

Nothing in the changelog for Random() that I saw.

Edit: Correction - the full changelog does show two "fixes" to Random:

http://www.autoitscript.com/autoit3/docs/a...t_changelog.txt

- Fixed: AutoIt crash in Random() when range exceeds 2^31.

- Fixed: Random(Min,Max,1). Previously this would never actually return Max,

so if Max was artificially incremented by one the script will now need to be changed.

Edited June 3, 2008 by herewasplato

[Valuater]

this looks strange too

.99 min but an an integer result will be returned...

it should not be "0" here either..AFAIK

For $x = 5 To 1 Step -1

    $Number = Random(.99, $x, 1)
    ConsoleWrite( "x=" & $x & "   Num=" &  $Number & @CRLF)
    
Next

8)

Edited June 3, 2008 by Valuater

[therks]

This has been reported and rejected (no bug): http://svn.autoitscript.com/trac/ticket/296

[Valuater]

...and a 1000 0s using v3.2.12.0

Nothing in the changelog for Random() that I saw.

Edit: Correction - the full changelog does show two "fixes" to Random:

http://www.autoitscript.com/autoit3/docs/a...t_changelog.txt

- Fixed: AutoIt crash in Random() when range exceeds 2^31.

- Fixed: Random(Min,Max,1). Previously this would never actually return Max,

so if Max was artificially incremented by one the script will now need to be changed.

I remember seeing that before, it may have "created" another bug area...

thx

8)

[Valuater]

This has been reported and rejected (no bug): http://svn.autoitscript.com/trac/ticket/296

Thanks Saunders....

But what about this

For $x = 5 To 1 Step -1

$Number = Random(.99, $x, 1)

ConsoleWrite( "x=" & $x & " Num=" & $Number & @CRLF)

Next

x=5 Num=3

x=4 Num=3

x=3 Num=3

x=2 Num=0

x=1 Num=1

I dont think there should be a 0 in there???

8)

[Valuater]

Well..., I guess I can just do this

Func _FreeText_Random($T_GUI)
    If Not IsArray($T_GUI) Then Return 0
    If UBound($T_GUI) - 1 = 1 Then Return 1
    $rand = Random(1, UBound($T_GUI) - 1, 1)
    Return $rand ; $T_GUI[$rand][0]
EndFunc   ;==>_FreeText_Random

return 1 if there is only 1 left...

lol

thx guys

8)

[herewasplato]

x=5 Num=5

x=4 Num=1

x=3 Num=0

x=2 Num=1

x=1 Num=1

???

[Valuater]

x=5 Num=5

x=4 Num=1

x=3 Num=0

x=2 Num=1

x=1 Num=1

???

yea... thats kinda funny

Random(.99, $x, 1)

will return a zero

Dunno!!...???

8)

[PsaltyDS]

yea... thats kinda funny

Random(.99, $x, 1)

will return a zero

Dunno!!...???

8)

It sets @error = 1 also, indicating invalid parameters:

For $x = 5 To 1 Step -1
    ConsoleWrite(@LF & "Debug: $x = " & $x & @LF)
    For $y = 1 To 5
        $n = Random(1, $x, 1)
        ConsoleWrite("Debug: $n = " & $n & "  @error = " & @error & @LF)
    Next
Next

So it may be as intended and just needs a update to the help file description that Min cannot equal Max. This does the same:

For $x = 5 To 2 Step -1
    ConsoleWrite(@LF & "Debug: $x = " & $x & @LF)
    For $y = 1 To 5
        $n = Random(2, $x, 1)
        ConsoleWrite("Debug: $n = " & $n & "  @error = " & @error & @LF)
    Next
Next