Function problem with GUI

[Appie78]

Hi all,

I'm having some problems with starting a function for the second time thru a while loop.

The first time the function works fine, if I want to start it for the second time nothing happens!

Does anyone have any idea's?

Thanks

[sandin]

part of the script, or the script itself would be most useful...

[Appie78]

This is the code!!

CODE

While 1

$msg = GUIGetMsg()

Select

Case $msg = $holder1

Holder1()

Case $msg = $recall

Recall()

Case $msg = $Version

MsgBox(0, "Custom Service", "Version 1.4.5")

Case $msg = $Help

File()

Case $msg = $GUI_EVENT_CLOSE or $msg = $exit

Exit

EndSelect

WEnd

Func Recall()

$Recall = FileOpen("c:\Positions.log", 0);

If $recall = -1 Then

Return MsgBox(0, "Error", "No file with positions.")

Exit

EndIf

$line = FileRead($recall)

$avArray = StringSplit($line, ";",1);

_ArrayTrim($avArray, 2, 0, 2)

_ArrayDisplay($avArray)

$tel = UBound($avArray)

$coor = $tel - 2; posities - 2.

If $coor < 3 Then

Return MsgBox(0,"JEOL Custom Service", "No data in file or corrupted file.")

Exit

EndIf

For $i = 1 To $coor Step 3

$x = $avArray[$i]

$y = $avArray[$i+1]

$r = $avArray[$i+2]

WinActivate("JEOL Scanning Electron Microscope")

Sleep(200)

ControlClick ("JEOL Scanning Electron Microscope", "", 95 , "left" , 1 , 20 , 20); view25

Sleep(1000)

ControlClick("JEOL Scanning Electron Microscope", "", 89, "left", 1, 20, 20)

Sleep(500)

WinActivate("Stage Control")

Sleep(200)

send("!p")

Send($x)

Send("{Tab}")

Send($y)

Send("{Tab}")

Send($r)

Sleep(200)

ControlClick("Positioning", "", 1, "left", 1, 20, 20)

Sleep(1000)

ControlClick ("JEOL Scanning Electron Microscope", "", 95 , "left" , 1 , 20 , 20)

Sleep(500)

If $i = $coor - 2 Then

$msg = MsgBox(0,"JEOL Custom Service", "Finished")

Else

$msg = MsgBox(1, "JEOL Custom Service", "Continue or Cancel?")

If $msg = 2 Then

ExitLoop

Else

MsgBox(0,"JEOL Custom Service", "Moving to next position",3)

EndIf

EndIf

Next

FileClose($Recall)

EndFunc

[sandin]

no issue there.

issue must be in one of your functions (holder1, recall, or other...)

-you forgot wend, but I assume you have it in your full script.

[Appie78]

Thanks Sandin,

But this function is stand alone and it's always the same even when I start the script and immediatly start this function. So no interference of an other function!!

Greetz

[sandin]

one of your functions must have infinite loop, like While 1, or Do which is never ended, that's why you can run your functions only for the 1st time

[Melba23]

Pokerface,

Although you have not shown your GUI creation code, from the While...WEnd loop, it is obvious that you created a control in your GUI and stored its ControlID in variable $recall. Becasue it was created in the main script and not in a function, it is automatically Global in scope.

Then in your Recall() function, you reuse the same variable to hold the file handle when you open c:\Positions.log. So when you go back to the While...WEnd loop, the value in $recall is no longer the ControlID and GUIGetMsg is most unlikely to produce the new value!

Solution: Set the $recall variable in the function as a Local variable - or better still, do not reuse variable names!

M23

[Appie78]

Pokerface,

Although you have not shown your GUI creation code, from the While...WEnd loop, it is obvious that you created a control in your GUI and stored its ControlID in variable $recall. Becasue it was created in the main script and not in a function, it is automatically Global in scope.

Then in your Recall() function, you reuse the same variable to hold the file handle when you open c:\Positions.log. So when you go back to the While...WEnd loop, the value in $recall is no longer the ControlID and GUIGetMsg is most unlikely to produce the new value!

Solution: Set the $recall variable in the function as a Local variable - or better still, do not reuse variable names!

M23

You where spot on!!!

Thanks I was using $recall in my GUI aswell!!!

Thanks again,

Pokerface