Array troubles again

[PcExpert]

Hi all,

I got some trouble with the following.

I'll first post my code:

Dim $docent_array[1]

$docent_array = _FileListToArray("Docenten", "*.ini", 1)

For $t = 0 To $docent_array[0]
ReDim $docent_array[$docent_array[0]]
Next

 $left = 45
    For $u = 0 To 5
        $top2 = 210
        For $o = 1 To 5
            $l = $u * 5 + $o
           ; If StringLen($docent_array[$l]) > 2 Then
                $dcCheckBox[$l] = GUICtrlCreateCheckbox("dc" & $l, $left, $top2, 50, 20) 
                $count2 += 1
                $top2 += 20
            ;EndIf
        Next
        $left += 65
    Next

    For $a = 1 To $count2
        If $docent_array[$a] <> "" Then
            GUICtrlSetData($dcCheckBox[$a], $docent_array[$a])
        EndIf
    Next

As you see, its not the full code just the part this is about, I am getting errors about the array:

'Array variable has incorrect number of subscripts or subscript dimension range exceeded.:

If $docent_array[$a] <> "" Then

If ^ ERROR'

Its probably because of the subscripts, as you can see its currently 1. I thought to fix the error by redimming the array, But didnt get me much further. I know that the array contains information (tested with _ArrayDisplay()).

Does somebody know how to solve this issue?

Thank you!

[Authenticity]

I don't yet understand some parts of the code but I believe that these are the root of the problem:

For $t = 0 To $docent_array[0]
ReDim $docent_array[$docent_array[0]]
Next

I don't see the point why you're using this loop, and by the way it's ReDim $docent_array[$docent_array[0]+1] unless you want to resize it to one less than the original array size.

Also, I think it's required to see if $count2 is bigger than $docent_array[0] before processing this loop.

At last, you don't need to use declare $docent_array as an array, let _FileListToArray do that for you.

-Just my notes. ;]

[PcExpert]

Thanks Authenticity. $count2 was much bigger than it should be, going to fix it:).

Edited March 17, 2009 by PcExpert

[Melba23]

PcExpert,

Hello again!

The problem is that your $l loop is running from 1 to $u * 5 + $o which means 1 to 30. But your $docent_array could well be less than that. So as soon as $l is higher than the top value of $docent_array > error.

You need to put another If to stop this:

For $o = 1 To 5
    $l = $u * 5 + $o
    If $l < $docent_array[0] + 1 Then 
        ConsoleWrite("Here " & $l & @CRLF)
        If StringLen($docent_array[$l]) > 2 Then
            $dcCheckBox[$l] = GUICtrlCreateCheckbox("dc" & $l, $left, $top2, 100, 20) 
            $count2 += 1
            $top2 += 20
        EndIf
    EndIf
Next

Try that and see if it works. You can definitely remove the entire ReDim looping stuff, by the way!

M23

[PcExpert]

Melba, you're great! Thanks for noticing this so fast. All the problems have gone now .

[Melba23]

PcExpert,

The first reply was from Authenticity - you might like to edit your post #3!

M23

[PcExpert]

Thanks for the suggestions Melba, I knew something was wrong with that post. FIXED! Sorry Authenticity

Edited March 17, 2009 by PcExpert