Scripts locks up

[Fire69]

Hello,

I'm new to AutoIt, so I'm probably doing something wrong.

I adapted the sample Calculator-script so it opens a program, simulates some keypresses, waits 1 minute, then closes the program again.

After that, a web-page is opened.

But 9 times out of 10, the script just 'hangs'. I tried running it as au3 and as an exe, no difference.

Could somebody check if I did something wrong in the (very simple) code?

expandcollapse popup

;
; AutoIt Version: 3.0
; Language:    English
; Platform:    Win9x/NT
; Author:        Jonathan Bennett (jon@hiddensoft.com)
; Author2:      Fire69
;
; Script Function:
;   Lets Media Companion scrape newly added TV Shows
;   Starts XBMC Library Update


; Run Media Companion
Run("C:\Program Files\Media Companion\Media Companion.exe")


; Wait for Media Companion to become active - it is titled "Media Companion"
WinWaitActive("Media Companion")


; Now that the Media Companion window is active, change it to TV Show mode
Send("{LALT}")
Send("{RIGHT}")
Send("{Down 2}") 
Send("{Enter}")

; Now that the mode is changed, let it scrape newly added episodes
Send("{LALT}")
Send("{RIGHT 2}")
Send("{Down 4}")
Send("{Enter}")

; Wait 1 minute for Media Companion to finish scraping
Sleep(60000)

; Now quit by sending a "close" request to Media Companion
WinClose("Media Companion")

; Now wait for Media Companion to close before continuing
WinWaitClose("Media Companion")

; Send URL to XBMC Webserver to start update of Video Library
ShellExecute("http://localhost/xbmcCmds/xbmcHttp?command=ExecBuiltIn&parameter=XBMC.updatelibrary(video)")


; Finished!

Edited April 14, 2009 by Fire69

[Melba23]

Fire69,

First, welcome to the AutoIt forums. A good start - some code to work on and a clear question. I wish some other newcomers would do the same. :-)

Try adding some debugging lines to check whether the script arrives at particular points:

ConsoleWrite("Got here: " & @ScriptLineNumber & @CRLF)

and see if you can pinpoint the location where the script hangs. Nothing jumps out of the script as posted - but I would hazard a guess that it is the application not closing.

M23

[Fire69]

Fire69,

First, welcome to the AutoIt forums. A good start - some code to work on and a clear question. I wish some other newcomers would do the same. :-)

Try adding some debugging lines to check whether the script arrives at particular points:

ConsoleWrite("Got here: " & @ScriptLineNumber & @CRLF)

and see if you can pinpoint the location where the script hangs. Nothing jumps out of the script as posted - but I would hazard a guess that it is the application not closing.

M23

I have over 12K post on another tech-forum so I know what kind of posts some people can throw at you!

I'll try adding the code, thanks for the great tip.

The application does disappear, so I guess it's just after it closes that the script hangs. Maybe it's not detecting correctly that the program closed. Am I using the best way to detect this?

[FinalVersion]

; Now that the Media Companion window is active, change it to TV Show mode
Send("{LALT}")
Send("{RIGHT}")
Send("{Down 2}")
Send("{Enter}")

Does this happen? Are they all suppose to be pushed at once? Or One after the other?

[Fire69]

Yes, this does happen. All the buttons should be pressed one after the other. It just simulates opening the menu, going right and down.

Is there a way to simulates function-keypresses? F2 and so? I couln't really find that.

@Melba23: I added the code in several places, but where should the message with the linenumbers appear? What is considered as the console in AutoIt?

Edited April 14, 2009 by Fire69

[Melba23]

Fire69,

If you run from SciTE, ConsoleWrite results appear in the lower window.

Godly has made a good point - I often add a short Sleep() between menu commands to allow time for menus (particularly cascading ones!) to open.

And yes, you can Send F keys - from the Help file: Send("{F1} - {F12}")

M23

[Fire69]

Fire69,

If you run from SciTE, ConsoleWrite results appear in the lower window.

Godly has made a good point - I often add a short Sleep() between menu commands to allow time for menus (particularly cascading ones!) to open.

And yes, you can Send F keys - from the Help file: Send("{F1} - {F12}")

M23

Ah, OK, got it

>"C:\Program Files\AutoIt3\SciTE\..\autoit3.exe" /ErrorStdOut "C:\Program Files\SABnzbd\scripts\ScrapeMCAndUpdateXBMC.au3"  
Got here: 21
Got here: 30
Got here: 39
Got here: 48
Got here: 54
>Exit code: 0   Time: 63.393

Everything seems normal.

The thing is, this script runs everytime Sabnzbd finishes downloading a new episode.

So when I queue up 10 episodes, it should run 10 times.

However, the most I got it to run consecutively is 3 or 4 times.

Then it hangs. The Media Companion program is closed so it got that far, but then nothing happens anymore.

If have to kill ScrapeMCAndUpdateXBMC.au3 (or .exe) through the Task Manager.

After that, Sabnzbd continues and the scripts functions again a couple of times.

Then it hangs again...

Must have missed the function keys in the Help. I know I looked for it!

I'll change that already, so the consecutive keypresses are already eliminated from the script.

Edited April 14, 2009 by Fire69

[Fire69]

Okay, little update.

I've been messing around a bit and disovered something.

First some backgroundinfo:

Sabnzbd starts a batch-file:

REM Rename .nfo to .info

cd /d %1
if exist %3.nfo ren %3.nfo %3.info


REM Lets MC scrape the episode and updates XBMC's Library

call "C:\Program Files\SABnzbd\scripts\ScrapeMCAndUpdateXBMC.au3"

So first an existing .nfo-file is renamed, then the au3-file is started.

I just started this batch-file myself about 5 times.

What happened? All 5 times Media Companion opened and closed again, as it should.

But 2 times the dos-box stayed open with this in it:

C:\Program Files\SABnzbd\scripts>REM Rename .nfo to .info

C:\Program Files\SABnzbd\scripts>echo.


C:\Program Files\SABnzbd\scripts>cd /d

C:\Program Files\SABnzbd\scripts>if exist .nfo ren .nfo .info

C:\Program Files\SABnzbd\scripts>echo.


C:\Program Files\SABnzbd\scripts>REM Lets MC scrape the episode and updates XBMC's Library

C:\Program Files\SABnzbd\scripts>call "C:\Program Files\SABnzbd\scripts\ScrapeMCAndUpdateXBMC.au3"

So it hangs there. DOS doesn't see the AutoIt-script finished and just keeps waiting for it.

And that's why Sabnzb doesn't continue, it's waiting for this to end.

Apparently, Sabnzb turns off the dos-output, so that's why I hadn't noticed this before.

Any ideas?

[edit]

I just commented out the line that sends the url to Internet Explorer and put it in the batch-file itself (through a .url-file).

After that, I ran the batch-file 15 times. Worked like a charm every time!

So sometimes the script doesn't exit correctly after the ShellExecute-command.

Had a look at the help-file, and there's an Exit-command (who would have thought! )

Added that to the end of the script, put the ShellExecute back in and tested the whole thing. Ran fine every time! Yeah!

Thanks for your time guys.

Edited April 15, 2009 by Fire69