_VersionCompare error (Solved)

[muncherw]

I have the same compiled script on my desktop and on a network drive. When I use _VersionCompare it always returns a -1. If I make the local vesion newer than the network version it returns -1 instead of 1.  What am I doing wrong? Thanks.

$sVersion1 = @ScriptDir & "\Port Enabler.exe"
$sVersion2 = "O:\Network\Technicians\Muncher\Port Enabler\Port Enabler.exe"

$result = _VersionCompare($sVersion1, $sVersion2)

If $result = 0 Then
   ; Files are the same. Do nothing.
    MsgBox(0, "Up to Date", "You are using the most current version of the port enabler.")
ElseIf $result = 1 Then
   ; This version is more up-to-date. Only really possible for Muncher.
   ; Do nothing.
    MsgBox(0, "Weird", "No one should see this but me.")
ElseIf $result = -1 Then
   ;Network version is newer. Need to upgrade.
    MsgBox(0, "Newer version available", "Please run the updater.")
EndIf

Edited April 24, 2009 by muncherw

[PsaltyDS]

I have the same compiled script on my desktop and on a neetwork drive. When I use _VersionCompare it always returns a -1. If I make the local vesion newer than the network version it returns -1 instead of 1.  What am I doing wrong? Thanks.

$sVersion1 = @ScriptDir & "\Port Enabler.exe"
$sVersion2 = "O:\Network\Technicians\Muncher\Port Enabler\Port Enabler.exe"

$result = _VersionCompare($sVersion1, $sVersion2)

If $result = 0 Then
   ; Files are the same. Do nothing.
    MsgBox(0, "Up to Date", "You are using the most current version of the port enabler.")
ElseIf $result = 1 Then
   ; This version is more up-to-date. Only really possible for Muncher.
   ; Do nothing.
    MsgBox(0, "Weird", "No one should see this but me.")
ElseIf $result = -1 Then
   ;Network version is newer. Need to upgrade.
    MsgBox(0, "Newer version available", "Please run the updater.")
EndIf

The input to the function is the version string, not the path. Try:

$result = _VersionCompare(FileGetVersion($sVersion1), FileGetVersion($sVersion2))

[Melba23]

muncherw,

The arguments for _VersionCompare are the numeric version numbers - like 3.3.0.0 or 32.45.2.198.

You should be able to get these by using FileGetVersion - assuming the author has set them. ;-)

M23

[muncherw]

The input to the function is the version string, not the path. Try:

$result = _VersionCompare(FileGetVersion($sVersion1), FileGetVersion($sVersion2))

Oooooooooooooh! That does it. Thanks!

[muncherw]

muncherw,

The arguments for _VersionCompare are the numeric version numbers - like 3.3.0.0 or 32.45.2.198.

You should be able to get these by using FileGetVersion - assuming the author has set them. ;-)

M23

I am the last author..and yes I did set them. I even had some msgboxes in there to debug so when they were displaying the correct version number but I still was getting a bad comparison I was really confused. Thanks for  your help.