Sign in to follow this  
Followers 0
blum

Wrong order within listbox

5 posts in this topic

#1 ·  Posted (edited)

I want to use a listbox to display log entries. The newest entry one should be the topmost entry within the listbox, so the user can overview the last events without scrolling.

The following function displays the message strings in the wrong order within the listbox - but i don't know why. The routine puts $vMessage in front of $vLogString, so the latest message is saved before the older ones. I misaccepted that the first substring is displayed in the first line of the listbox - wrong, it will be displayed in the last line; in the order of their occurrence within the code execution. But this is not the order of this routine - can anybody help me with the logic? Have I missed a necessary command?

Version is AI 3.3.0.0 stable.

Global $vLogString=""

AddLogEntry("line1")
AddLogEntry("line2")

Func AddLogEntry($vMessage)
  $vMessage=@Hour & ":" & @MIN & ":" & @SEC & " " & $vMessage
  if $vLogString<>"" Then $vMessage = $vMessage & "|"
  $vLogString = $vMessage & $vLogString

  Dim $vData=""
  $vData=StringSplit($vLogString,"|")

  GUICtrlSetData($ListLog, "")

  For $i=1 to UBound($vData)-1
;msgbox (0,"",UBound($vData)-1 & "/" & $i & ": " & $vData[$i])
   GUICtrlSetData($ListLog, $vData[$i])
  Next

EndFunc

Output in listbox is:

10:15:05: line 1

10:15:10: line 2

...but assumed is

10:15:10:line 2

10:15:05:line 1

Edited by blum

Share this post


Link to post
Share on other sites



#2 ·  Posted (edited)

#include<array.au3>
Global $vLogString=""

AddLogEntry("line1")
AddLogEntry("line2")

Func AddLogEntry($vMessage)
  $vMessage=@Hour & ":" & @MIN & ":" & @SEC & " " & $vMessage
  if $vLogString<>"" Then $vMessage = $vMessage & "|"
  $vLogString = $vMessage & $vLogString

  Dim $vData=""
  $vData=StringSplit($vLogString,"|")
  _ArraySort($vData, 1, 1, Ubound($vData))
  GUICtrlSetData($ListLog, "")

  For $i=1 to UBound($vData)-1
;msgbox (0,"",UBound($vData)-1 & "/" & $i & ": " & $vData[$i])
   GUICtrlSetData($ListLog, $vData[$i])
  Next

EndFunc

Edited by GEOSoft

George

Question about decompiling code? Read the decompiling FAQ and don't bother posting the question in the forums.

Be sure to read and follow the forum rules. -AKA the AutoIt Reading and Comprehension Skills test.***

The PCRE (Regular Expression) ToolKit for AutoIT - (Updated Oct 20, 2011 ver:3.0.1.13) - Please update your current version before filing any bug reports. The installer now includes both 32 and 64 bit versions. No change in version number.

Visit my Blog .. currently not active but it will soon be resplendent with news and views. Also please remove any links you may have to my website. it is soon to be closed and replaced with something else.

"Old age and treachery will always overcome youth and skill!"

Share this post


Link to post
Share on other sites

blum,

When you create the listbox, I presume you did not specify any styles - in that case you get the default: $LBS_SORT, $WS_BORDER, $WS_VSCROLL. As a result, your listbox is automatically sorting the input for you.

Add the following style to your listbox: BitOr($WS_BORDER, $WS_VSCROLL) and then your function can read:

Func AddLogEntry($vMessage)
    
  $vMessage = "|" & @Hour & ":" & @MIN & ":" & @SEC & " " & $vMessage
  $vLogString = $vMessage & $vLogString
  
  GUICtrlSetData($ListLog, $vLogString)
  
EndFunc

Adding the leading "|" makes the data replace the existing data - so no need to empty the listbox first. ;-)

Works for me!

M23


Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites

What Melba23 said plus what I said.

Also I would change the line

$vMessage = "|" & @Hour & ":" & @MIN & ":" & @SEC & " " & $vMessage

To

$vMessage = StringFormat("%s:%s:%s %s", @Hour, @Min, @Sec, $vMessage)

You may find that the change comes in handy later on


George

Question about decompiling code? Read the decompiling FAQ and don't bother posting the question in the forums.

Be sure to read and follow the forum rules. -AKA the AutoIt Reading and Comprehension Skills test.***

The PCRE (Regular Expression) ToolKit for AutoIT - (Updated Oct 20, 2011 ver:3.0.1.13) - Please update your current version before filing any bug reports. The installer now includes both 32 and 64 bit versions. No change in version number.

Visit my Blog .. currently not active but it will soon be resplendent with news and views. Also please remove any links you may have to my website. it is soon to be closed and replaced with something else.

"Old age and treachery will always overcome youth and skill!"

Share this post


Link to post
Share on other sites

ahhh, i see. at first i missed the parameter to the listbox. it's right, the auto-sort was applied. the other tips are great, too.

at first i tried to generate the listbox content via the delimited string but the default sort-flag mixed up my order. the array calls are just to demonstrate the step by step addition. now the routine is such short as melba suggested.

thanx!

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0