E1M1 8 Posted November 13, 2010 (edited) I tried to convert C# conde from wiki to autoit http://en.wikipedia.org/wiki/Trial_divisionThat's what I gotFunc is_prime($number) if ($number < 2) Then return false; $d = 2 While ($d * $d <= $number)$d +=1 if (Mod($number, $d) == 0) Then return false; EndIf WEnd return true;EndFuncThis function always returns me true.. for example it returns true for 99, but you can devide 99 with 3, so it's not primenumber. Could someone help me fixing this function pleae? Edited November 13, 2010 by E1M1 edited Share this post Link to post Share on other sites
Melba23 3,456 Posted November 13, 2010 (edited) E1M1, I use this function to check primes: For $i = 1 To 100 If _IsPrime($i) Then ConsoleWrite($i & @CRLF) Next Func _IsPrime($i) If $i < 2 Then Return False ElseIf $i < 4 Then Return True ElseIf Mod($i, 2) = 0 Then Return False Else $id = 3 Do If Mod($i, $id) = 0 Then Return False $id += 2 Until $id * $id > $i Return (($id * $id) > $i) EndIf EndFunc M23 Edit: See you solved it yourself - would delete post if I could! Edited November 13, 2010 by Melba23 Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind Open spoiler to see my UDFs: Spoiler ArrayMultiColSort ---- Sort arrays on multiple columnsChooseFileFolder ---- Single and multiple selections from specified path treeview listingDate_Time_Convert -- Easily convert date/time formats, including the language usedExtMsgBox --------- A highly customisable replacement for MsgBoxGUIExtender -------- Extend and retract multiple sections within a GUIGUIFrame ---------- Subdivide GUIs into many adjustable framesGUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView itemsGUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeViewMarquee ----------- Scrolling tickertape GUIsNoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxesNotify ------------- Small notifications on the edge of the displayScrollbars ----------Automatically sized scrollbars with a single commandStringSize ---------- Automatically size controls to fit textToast -------------- Small GUIs which pop out of the notification area Share this post Link to post Share on other sites
PsaltyDS 39 Posted November 15, 2010 IsPrime functions can be horribly slow, and including a (not too long) table of initial primes speeds them up tremendously: Valuater's AutoIt 1-2-3, Class... Is now in Session!For those who want somebody to write the script for them: RentACoder"Any technology distinguishable from magic is insufficiently advanced." -- Geek's corollary to Clarke's law Share this post Link to post Share on other sites
