most efficient way to check multiple values then do something

[kor]

if I have 6 variables. I want to check all 6 variables and make sure that none of them are blank. If any of the 6 are blank then exit. What is the most efficient way to do that? Case? If with multiple OR's?

$var1 = "something"
$var2 = "awful"
$var3 = "this"
$var4 = "way"
$var5 = "comes"

If $var1 = "" Or $var2 = "" Or $var3 = "" Or $var4 = "" Or $var5 = "" Then
;exit
Else
; continue
EndIf

Is there a more efficient way to do the above?

[Melba23]

kor,

I would put the variables in an array and use a loop:

Global $var[6]

$var[1] = "something"
$var[2] = "awful"
$var[3] = "this"
$var[4] = "way"
$var[5] = "comes"

For $i = 1 To 5
    If $var[$i] = "" Then
        MsgBox(0, "Ooops", "Variable " & $i & " is blank")
        Exit
    EndIf
Next

MsgBox(0, "All OK", "All variables filled")

M23

[kor]

Perfect. The variables are already in an array so that works out.

[Zedna]

If $var1 & $var2 & $var3 & $var4 & $var5 = "" Then
  ; all empty
Else
  ; some not empty
EndIf

Edited January 19, 2011 by Zedna

[kor]

Zedna, that wouldnt work. That code says if ALL vars are empty. my code above shows that something must happen if ANY var is empty.

[Zedna]

Zedna, that wouldnt work. That code says if ALL vars are empty. my code above shows that something must happen if ANY var is empty.

Then sorry I misunderstood it.

[kylomas]

kor,

substitute "or" for the "and" and zedna's example seems like it works..

kylomas

[KaFu]

If you know the array size ahead and it's a highly repetitive task...

Global $var[6]

$var[1] = "something"
$var[2] = "awful"
$var[3] = "this"
$var[4] = "way"
$var[5] = "comes"

$timer = TimerInit()
For $i = 1 To 1000000
    If Not $var[1] Or Not $var[2] Or Not $var[3] Or Not $var[4] Or Not $var[5] Then
        For $y = 1 To 5
            If $var[$y] = "" Then
                MsgBox(0, "Ooops", "Variable " & $y & " is blank")
                Exit
            EndIf
        Next
    EndIf
Next
ConsoleWrite(TimerDiff($timer) & @CRLF)

$timer = TimerInit()
For $i = 1 To 1000000
    For $y = 1 To 5
        If $var[$y] = "" Then
            MsgBox(0, "Ooops", "Variable " & $y & " is blank")
            Exit
        EndIf
    Next
Next
ConsoleWrite(TimerDiff($timer) & @CRLF)