Having a problem with Conditional Statement

[sabbycon]

*Fixed*

Edited March 15, 2011 by sabbycon

[hannes08]

Hi sabbycon,

first, I would like to know wh you do this:

$x = 0
  Do
    $x = $x + 1
  Until $x = 1

It doesn't make sense to run a loop if you want to do it one time only anyway, right?

second, why are you checking the $Frag variable like this:

If $Frag = "0" Then
   ...

As far as I checked the helpfile, StringRegExp returns a numeric value.

You could try using Number() to make sure the expression is really a number.

[BrewManNH]

You might change this line:

$Frag = StringRegExp ($StripWS, 'Youdonotneedtodefragmentthisvolume.') ;Look for pattern; If found return 1

To this:

If $StripWS = 'Youdonotneedtodefragmentthisvolume.' Then ;Look for pattern; If found return 1
    $Frag = 1
Else
    $Frag = 0
EndIf

Because to my eyes, that's not a RegEx pattern you're looking for and will always return 0. You're trying to compare 2 strings using an invalid RegEx statement.

[sabbycon]

*fixed*

Edited March 15, 2011 by sabbycon

[GEOSoft]

There is so much wrong with that code it's difficult to know where to begin

Is there a reason why you are resticting the code to x64 systems?

If you use the proper RegEx there is no need for stripping the whitespace, the regex will handle it just fine.

Dim $std followed later by $std &= StdOutRead($foo) just isn't going to cut it.

Dim anything is bad practice unless it's an array of a known size. Use Local or Global (as required) instead.

The part where you are actually checking the drive to see if defrag is required would be better in it's own function with a return value.

When I get some time I have one that I wrote for testing a while back and I'll post it in here.

[sabbycon]

There is so much wrong with that code it's difficult to know where to begin

Is there a reason why you are resticting the code to x64 systems?

If you use the proper RegEx there is no need for stripping the whitespace, the regex will handle it just fine.

Dim $std followed later by $std &= StdOutRead($foo) just isn't going to cut it.

Dim anything is bad practice unless it's an array of a known size. Use Local or Global (as required) instead.

The part where you are actually checking the drive to see if defrag is required would be better in it's own function with a return value.

When I get some time I have one that I wrote for testing a while back and I'll post it in here.

Is there a reason why you are resticting the code to x64 systems?

Yes, the script has to run on X64 and X86 Archs

If you use the proper RegEx there is no need for stripping the whitespace, the regex will handle it just fine.

I thought it would make it more reliable to strip all of the WS out.

Dim $std followed later by $std &= StdOutRead($foo) just isn't going to cut it.

I have changed it to Local

The part where you are actually checking the drive to see if defrag is required would be better in it's own function with a return value.

Working on that now.

Thanks for the advice, again, I'm a novice at AutoIT. This is a learning experience for me and I think this is going to really help me grasp AutoIT.

[sabbycon]

*Fixed*

Edited March 15, 2011 by sabbycon

[sabbycon]

*Fixed*

Edited March 15, 2011 by sabbycon