Sign in to follow this  
Followers 0
sabbycon

Having a problem with Conditional Statement

8 posts in this topic

#1 ·  Posted (edited)

*Fixed*

Edited by sabbycon

Share this post


Link to post
Share on other sites



Hi sabbycon,

first, I would like to know wh you do this:

$x = 0
  Do
    $x = $x + 1
  Until $x = 1

It doesn't make sense to run a loop if you want to do it one time only anyway, right?

second, why are you checking the $Frag variable like this:

If $Frag = "0" Then
   ...

As far as I checked the helpfile, StringRegExp returns a numeric value.

:)

You could try using Number() to make sure the expression is really a number.


Regards,Hannes[spoiler]If you can't convince them, confuse them![/spoiler]

Share this post


Link to post
Share on other sites

You might change this line:

$Frag = StringRegExp ($StripWS, 'Youdonotneedtodefragmentthisvolume.') ;Look for pattern; If found return 1

To this:

If $StripWS = 'Youdonotneedtodefragmentthisvolume.' Then ;Look for pattern; If found return 1
    $Frag = 1
Else
    $Frag = 0
EndIf

Because to my eyes, that's not a RegEx pattern you're looking for and will always return 0. You're trying to compare 2 strings using an invalid RegEx statement.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

#4 ·  Posted (edited)

*fixed*

Edited by sabbycon

Share this post


Link to post
Share on other sites

There is so much wrong with that code it's difficult to know where to begin

Is there a reason why you are resticting the code to x64 systems?

If you use the proper RegEx there is no need for stripping the whitespace, the regex will handle it just fine.

Dim $std followed later by $std &= StdOutRead($foo) just isn't going to cut it.

Dim anything is bad practice unless it's an array of a known size. Use Local or Global (as required) instead.

The part where you are actually checking the drive to see if defrag is required would be better in it's own function with a return value.

When I get some time I have one that I wrote for testing a while back and I'll post it in here.


George

Question about decompiling code? Read the decompiling FAQ and don't bother posting the question in the forums.

Be sure to read and follow the forum rules. -AKA the AutoIt Reading and Comprehension Skills test.***

The PCRE (Regular Expression) ToolKit for AutoIT - (Updated Oct 20, 2011 ver:3.0.1.13) - Please update your current version before filing any bug reports. The installer now includes both 32 and 64 bit versions. No change in version number.

Visit my Blog .. currently not active but it will soon be resplendent with news and views. Also please remove any links you may have to my website. it is soon to be closed and replaced with something else.

"Old age and treachery will always overcome youth and skill!"

Share this post


Link to post
Share on other sites

There is so much wrong with that code it's difficult to know where to begin

Is there a reason why you are resticting the code to x64 systems?

If you use the proper RegEx there is no need for stripping the whitespace, the regex will handle it just fine.

Dim $std followed later by $std &= StdOutRead($foo) just isn't going to cut it.

Dim anything is bad practice unless it's an array of a known size. Use Local or Global (as required) instead.

The part where you are actually checking the drive to see if defrag is required would be better in it's own function with a return value.

When I get some time I have one that I wrote for testing a while back and I'll post it in here.

Is there a reason why you are resticting the code to x64 systems?

Yes, the script has to run on X64 and X86 Archs

If you use the proper RegEx there is no need for stripping the whitespace, the regex will handle it just fine.

I thought it would make it more reliable to strip all of the WS out.

Dim $std followed later by $std &= StdOutRead($foo) just isn't going to cut it.

I have changed it to Local

The part where you are actually checking the drive to see if defrag is required would be better in it's own function with a return value.

Working on that now.

Thanks for the advice, again, I'm a novice at AutoIT. This is a learning experience for me and I think this is going to really help me grasp AutoIT.

Share this post


Link to post
Share on other sites

#7 ·  Posted (edited)

*Fixed*

Edited by sabbycon

Share this post


Link to post
Share on other sites

#8 ·  Posted (edited)

*Fixed*

Edited by sabbycon

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0