[SOLVED] Simpler code please?

[Mingre 0]

$oForm = _IEGetObjById($oIE, "login_form")

$element = _IEFormElementGetObjByName($oForm, "username")
_IEFormElementSetValue($element, "sampleusername")

$element = _IEFormElementGetObjByName($oForm, "password")
_IEFormElementSetValue($element, samplepassword")

$element = _IEFormElementGetObjByName($oForm, "persistent") ; unchecks Remember Me
_IEAction($element, "click")

_IEFormSubmit($oForm)

Can this still be simplified?

Edit: Edited out the included password (first edit) and some stuffs (2nd edit).

Edited May 26, 2011 by Lilbert

[hench 0]

That look pretty much simplified already

If it works of course...

[Mingre 0]

It works fine.

Thanks for the input!

[Melba23 2,733]

Lilbert,

It's the AutoIT login form BTW.

Be careful if you are thinking of automating the Autoit forum login - take a look here first.

This prohibition has not, to my knowledge, been lifted.

M23

[Mingre 0]

Lilbert,

Be careful if you are thinking of automating the Autoit forum login - take a look here first.

This prohibition has not, to my knowledge, been lifted.

M23

Woah, didn't think it was not allowed. I can feel my warn status turning red! Thanks for the info. *Edits post*

[James 374]

Woah, didn't think it was not allowed. I can feel my warn status turning red! Thanks for the info. *Edits post*

Automating the AutoIt forum? THIS IS MADNESS!

It's not a good thing to be doing here Trust me.

[Mingre 0]

THIS IS MADNESS!

LOL. Sorry, really. Let's just say that I was trying to learn IE Management and took the wrong site to practice with.

At your sig: I can't see that button on the posting window, why's that? (I only see emoticons and some 3 checkboxes.)

Edit: 'wrong'

Edited May 26, 2011 by Lilbert

[James 374]

At your sig: I can't see that button on the posting window, why's that? (I only see emoticons and some 3 checkboxes.)

Are you using the rich text editor?

If so, you can type [ autoit ] CODE HERE [/ autoit ] without all of the spaces between the square brackets.

MsgBox(0, "", "Hey")

Like that

[Zedna 177]

For the same piece of code called many times use functions like this

$oForm = _IEGetObjById($oIE, "login_form")

FormElementSet($oForm, "username", "sampleusername")
FormElementSet($oForm, "password", "samplepassword")
FormElementAction($oForm, "persistent", "click") ; unchecks Remember Me

_IEFormSubmit($oForm)

Func FormElementSet($form, $name, $value)
    $element = _IEFormElementGetObjByName($form, $name)
    _IEFormElementSetValue($element, $value)
EndFunc

Func FormElementAction($form, $name, $action)
    $element = _IEFormElementGetObjByName($form, $name)
    _IEAction($element, $action)
EndFunc

In this simple example it has almost no sense but with more elements used it can greatly improve code readabilty and reduce code size.

Edited May 26, 2011 by Zedna

[Mingre 0]

Zedna,

Thanks for the tip!

JamesBrooks,

I only see the 'full editor' option. Hmm.