Jump to content

[SOLVED] Simpler code please?


Recommended Posts

$oForm = _IEGetObjById($oIE, "login_form")

$element = _IEFormElementGetObjByName($oForm, "username")
_IEFormElementSetValue($element, "sampleusername")

$element = _IEFormElementGetObjByName($oForm, "password")
_IEFormElementSetValue($element, samplepassword")

$element = _IEFormElementGetObjByName($oForm, "persistent") ; unchecks Remember Me
_IEAction($element, "click")

_IEFormSubmit($oForm)

Can this still be simplified?

Edit: Edited out the included password (first edit) and some stuffs (2nd edit).

Edited by Lilbert
Link to comment
Share on other sites

  • Moderators

Lilbert,

It's the AutoIT login form BTW.

Be careful if you are thinking of automating the Autoit forum login - take a look here first. :huh2:

This prohibition has not, to my knowledge, been lifted. ;)

M23

Public_Domain.png.2d871819fcb9957cf44f4514551a2935.png Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind

Open spoiler to see my UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Link to comment
Share on other sites

Lilbert,

Be careful if you are thinking of automating the Autoit forum login - take a look here first. :huh2:

This prohibition has not, to my knowledge, been lifted. ;)

M23

Woah, didn't think it was not allowed. I can feel my warn status turning red! Thanks for the info. *Edits post*
Link to comment
Share on other sites

THIS IS MADNESS!

LOL. Sorry, really. Let's just say that I was trying to learn IE Management and took the wrong site to practice with.

At your sig: I can't see that button on the posting window, why's that? (I only see emoticons and some 3 checkboxes.)

Edit: 'wrong'

Edited by Lilbert
Link to comment
Share on other sites

For the same piece of code called many times use functions like this

$oForm = _IEGetObjById($oIE, "login_form")

FormElementSet($oForm, "username", "sampleusername")
FormElementSet($oForm, "password", "samplepassword")
FormElementAction($oForm, "persistent", "click") ; unchecks Remember Me

_IEFormSubmit($oForm)

Func FormElementSet($form, $name, $value)
    $element = _IEFormElementGetObjByName($form, $name)
    _IEFormElementSetValue($element, $value)
EndFunc

Func FormElementAction($form, $name, $action)
    $element = _IEFormElementGetObjByName($form, $name)
    _IEAction($element, $action)
EndFunc

In this simple example it has almost no sense but with more elements used it can greatly improve code readabilty and reduce code size.

Edited by Zedna
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...