code review_help

[AvN]

Hi, I have some code here (part of a program) that worked well with windows xp. Now I am using windows 7, I am not sure why this is not working as expected. could some one a look and help me? Does it have to do with 64bit, 32 bit system? what to fix here and how?

Thank you.

[JLogan3o13]

Hi, AvN. Perhaps you could post your code

[AvN]

Sorry, I forgot the attachments

kl_try.au3

[JLogan3o13]

Hi, AvN. Are you receiving a specific error when you run this script on Win7? The more detail you can provide us the more quickly we can assist.

[BrewManNH]

What isn't working on this script? You never said what the problem with it was.

BTW, this code:

$location = dircreate("C:DocumentsAvul")

Are you aware of what the value of $location will be if it creates the directory? Because you use it later in your script here:

RegWrite ( "HKEY_LOCAL_MACHINESOFTWAREL toolslog","Location", "REG_SZ", $location&"L-ToolsKllg")

DirCreate returns 1 if successful, and 0 if it fails, it does not return the directory name. When you used FileSelectFolder before, it would return the directory name, now it doesn't.

[lgvlgv]

think the error maybe "HKEY_LOCAL_MACHINE"

i use this to avoid error if i have 32/64 bits machines in a mixed enviroment..

If @OSArch = "X64" Then
Global $key7 = "HKLM64"
Global $key8 = "HKCU64"
Else
Global $key7 = "HKLM"
Global $key8 = "HKCU"
EndIf
$RemoteServer = RegRead($key7 & "SOFTWAREChargeChargeDeamon", "RemoteServer")

[AvN]

There is no error message, but I noticed that " L-ToolsKllg" folder is not beeing created.

and it is not copying the file => filecopy(@ScriptFullPath,$location&"L-ToolsKllg"&@scriptname,1)

[lgvlgv]

What isn't working on this script? You never said what the problem with it was.

BTW, this code:

$location = dircreate("C:DocumentsAvul")

Are you aware of what the value of $location will be if it creates the directory? Because you use it later in your script here:

RegWrite ( "HKEY_LOCAL_MACHINESOFTWAREL toolslog","Location", "REG_SZ", $location&"L-ToolsKllg")

DirCreate returns 1 if successful, and 0 if it fails, it does not return the directory name. When you used FileSelectFolder before, it would return the directory name, now it doesn't.

correct, strange he says that it works on XP ?

[AvN]

There is no error message, but I noticed that " L-ToolsKllg" folder is not beeing created.

and it is not copying the file => filecopy(@ScriptFullPath,$location&"L-ToolsKllg"&@scriptname,1)

[BrewManNH]

There is no error message, but I noticed that " L-Tools\Kllg" folder is not beeing created.

and it is not copying the file => filecopy(@ScriptFullPath,$location&"\L-Tools\Kllg\"&@scriptname,1)

$location doesn't contain a valid path so the directory doesn't exist for the file to be copied into. Plus, you're trying to copy the current file to that location it may be locked because it's in use at the time you're trying to copy it. As I explained above, DirCreate does NOT return the path that you created, it only contains a 1 or a 0 depending upon whether it created the directory.