Sign in to follow this  
Followers 0
Zoreal

New to AutoIt - Help with an Array

8 posts in this topic

I'm getting an error - Any help diagnosing is appreciated.

Error: "Array variable has incorrect number of subscripts or subscript dimension range exceeded."

The error happens on the "$FileHandlerArray..." line when calling this function.

Func FileHandlerArray($FileNamesArray)
   Dim $FileHandlerArray[UBound($FileNamesArray) - 1]
   For $i = 0 To UBound($FileNamesArray) - 1
 $FileHandlerArray[$i] = FileOpen($FileNamesArray[$i])
   Next
   Return $FileHandlerArray
EndFunc

The helpfile stated that prior to setting array values, you must declare it using dim. I did so using the ubound expression within brackets. The helpfile also stated expressions within array brackets was supported. I'm just not sure where I've gone wrong here.

Thank you in advance for any help...

Z

Share this post


Link to post
Share on other sites



I'm not sure you can have a function and a variable named the same thing.


Whenever someone says "pls" because it's shorter than "please", I say "no" because it's shorter than "yes".

Share this post


Link to post
Share on other sites

I'm not sure you can have a function and a variable named the same thing.

I verified this isn't the cause of the issue - My function is now called "_FileHandlerArray"

Share this post


Link to post
Share on other sites

Zoreal,

Welcome to the AutoIt forum. :)

You are creating the second array with one less element that you need:

Global $FileNamesArray[10] ; UBound = 10 -> 0-9

Func FileHandlerArray($FileNamesArray)
    Local $FileHandlerArray[UBound($FileNamesArray) - 1] ; created as UBound = 9 -> 0-8
    For $i = 0 To UBound($FileNamesArray) - 1 ; Here we go from 0 - 9
        $FileHandlerArray[$i] = FileOpen($FileNamesArray[$i]) ; And here we try to open $FileHandlerArray[9] which does not exist
    Next
    Return $FileHandlerArray
EndFunc   ;==>FileHandlerArray

You need to create the second array with the same number of elements:

Local $FileHandlerArray[UBound($FileNamesArray)] ; created as UBound = 10 -> 0-9

All clear? :)

And note I used Global/Local and not Dim - read the Variables - using Global, Local and ByRef tutorial in the Wiki to see why. ;)

M23


Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites

You're declaring the $FileHandlerArray with one too few elements, you're subtracting one from the $FileNamesArray and then trying to loop through the array up to its Ubound - 1, if the incoming array has for example 175 elements, you're declaring $FileHandlerArray to 174.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

So an array declaration's number within brackets is the quantity of elements - not the highest element?

Global $Array[10] 
UBound($Array) = 10 ; True? (Elements 0-9 or 0-10)

Share this post


Link to post
Share on other sites

Correct, it's the total number of elements. Which is why you have to subtract 1 from the total when looping through an array, because in your example there are 10 elements, but they only go up to 9 (0-9).


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

Zoreal,

Correct. :)

I would have chosen a different name for the UBound function, but that is what we have got. ;)

M23


Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0