Weird FileReadLine behavior

[dmlarsen30]

I've used FileReadLine 100's of times, but for some reason, it's not working correctly on my work machine. (Home machine works fine.)

$Importfile = FileOpenDialog("Open a File", @WindowsDir & "\", "Text files (*.txt)", 3)
ConsoleWrite("Filename: " & $Importfile & @CRLF)
While (@error <> -1)
$TextLine = FileReadLine($Importfile)
ConsoleWrite($TextLine & @CRLF)

WEnd

At home, this code spits out the entire text file and exits. At work, it spits out just the first line of text and gets stuck in an infinite loop. Am I crazy? I don't understand what's going on here...

[BrewManNH]

I've used FileReadLine 100's of times, but for some reason, it's not working correctly on my work machine. (Home machine works fine.)

At home, this code spits out the entire text file and exits. At work, it spits out just the first line of text and gets stuck in an infinite loop. Am I crazy? I don't understand what's going on here...

There is no way that code works the way you say it does anywhere home or office.

For one thing the @error condition will never happen the way you're expecting because it's in the wrong place. It's reading the return value from the ConsoleWrite command and not the FileReadLine, and as far as I know, there's no error return value from ConsoleWrite.

Second, you're reading the exact same line from the file every time through the loop because you're using the filename and not using FileOpen and a handle. If you use a filename, the file is opened and closed every time you use FileReadLine, so unless you use a line number it's going to read the first line every time.

[Melba23]

dmlarsen30,

I would try using the more usual way to read the end-of-file marker:

$Importfile = FileOpenDialog("Open a File", @ScriptDir & "", "Source files (*.au3)", 3)
ConsoleWrite("Filename: " & $Importfile & @CRLF)
$hFile = FileOpen($Importfile)
While 1
    $TextLine = FileReadLine($hFile)
    If @error Then ExitLoop
    ConsoleWrite($TextLine & @CRLF)
WEnd
FileClose($hFile)

Note that I also used a file handle - from the Help file:

"If a filename is given rather than a file handle - the file will be opened and closed during the function call - for parsing large text files this will be much slower than using filehandles"

M23

[dmlarsen30]

Ugh...foolish errors on my part. I guess I'm too tired.... Thanks for setting me on the right path.