Sign in to follow this  
Followers 0
dmlarsen30

Weird FileReadLine behavior

4 posts in this topic

I've used FileReadLine 100's of times, but for some reason, it's not working correctly on my work machine. (Home machine works fine.)

$Importfile = FileOpenDialog("Open a File", @WindowsDir & "\", "Text files (*.txt)", 3)
ConsoleWrite("Filename: " & $Importfile & @CRLF)
While (@error <> -1)
$TextLine = FileReadLine($Importfile)
ConsoleWrite($TextLine & @CRLF)

WEnd

At home, this code spits out the entire text file and exits. At work, it spits out just the first line of text and gets stuck in an infinite loop. Am I crazy? I don't understand what's going on here...

Share this post


Link to post
Share on other sites



I've used FileReadLine 100's of times, but for some reason, it's not working correctly on my work machine. (Home machine works fine.)

At home, this code spits out the entire text file and exits. At work, it spits out just the first line of text and gets stuck in an infinite loop. Am I crazy? I don't understand what's going on here...

There is no way that code works the way you say it does anywhere home or office.

For one thing the @error condition will never happen the way you're expecting because it's in the wrong place. It's reading the return value from the ConsoleWrite command and not the FileReadLine, and as far as I know, there's no error return value from ConsoleWrite.

Second, you're reading the exact same line from the file every time through the loop because you're using the filename and not using FileOpen and a handle. If you use a filename, the file is opened and closed every time you use FileReadLine, so unless you use a line number it's going to read the first line every time.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

dmlarsen30,

I would try using the more usual way to read the end-of-file marker: :)

$Importfile = FileOpenDialog("Open a File", @ScriptDir & "", "Source files (*.au3)", 3)
ConsoleWrite("Filename: " & $Importfile & @CRLF)
$hFile = FileOpen($Importfile)
While 1
    $TextLine = FileReadLine($hFile)
    If @error Then ExitLoop
    ConsoleWrite($TextLine & @CRLF)
WEnd
FileClose($hFile)

Note that I also used a file handle - from the Help file: ;)

"If a filename is given rather than a file handle - the file will be opened and closed during the function call - for parsing large text files this will be much slower than using filehandles"

M23


Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites

Ugh...foolish errors on my part. I guess I'm too tired.... Thanks for setting me on the right path.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0