A better way of Randomising.

[Kamakazy]

Hey Guys.

Happy Christmas and Merry new Year and all that..

I'm currently automating our entire system for end-2-end testing. I have about 12 Complex scripts all joined together in a GUI and it all works.

But I want to bring down the amount of lines of code that I used (I Started coding these script without any knowledge of coding/scripting so bear with me..)

Currently, I am generating a random number with the following code..

IniWrite(@ScriptDir & "\Iteration.ini ", "Boat Details", "Engine" , Random(111, 999, 1) & Chr(Random(Asc("A"), _
Asc("Z"), 1)) & Chr(Random(Asc("A"), Asc("Z"), 1)) & Random(111, 999, 1) & Chr(Random(Asc("A"), Asc("Z"), 1)) & _
Chr(Random(Asc("A"), Asc("Z"), 1)) & Chr(Random(Asc("A"), Asc("Z"), 1)) & Chr(Random(Asc("A"), Asc("Z"), 1)) & _
Random(111, 999, 1) & Chr(Random(Asc("A"), Asc("Z"), 1)) & Chr(Random(Asc("A"), Asc("Z"), 1)))

Please note that the amount of characters is critical for my tests.

Now the question, Is there a better way of doing this?

Thanx for the assist.

Kama

[kylomas]

Kamakazy,

If I was going to do something like that I would structure it like this

IniWrite( @ScriptDir & "\Iteration.ini ", "Boat Details", "Engine" , _num() & _
                                                                     _chr() & _
                                                                     _chr() & _
                                                                     _num() )   ; etc for as long as you require


func _chr()
    return Chr(Random(Asc("A"), Asc("Z"), 1))
EndFunc

func _num()
    Random(111, 999, 1)
endfunc

just for readability.

kylomas

edit: it does NOT bring down the # of lines of code but it's a hell of a lot easier to read. The # of lines of source should be considered only after readability and maintainability, if at all.

Edited January 4, 2013 by kylomas

[Kamakazy]

Duly noted!

Thanx for the input dude..

Regards.

Kama

[jchd]

func _num()
Return Random(111, 999, 1)
endfunc

will work even better ;-)

[kylomas]

@jchd - Thanks!

@Kamakazy - jchd caught a mistake that I made. I forgot the "return" stmt in the _num() func.

kylomas

[jchd]

This is a pretty easy error to make and AutoIt won't bark:

Local $a = fct()

Func fct()
Random(0, 9, 1) ; or whatever without Return
EndFunc

[kylomas]

Yes, I understand. Kamakazy is a new user however and will think that he did something wrong when the code does not work. That is why I made sure to point out the error.

kylomas

[Kamakazy]

Thanx Guys.

I actually caught the missing "return".

Let's just say that I'm a very fast learner... but nothing beats asking questions...

Thanx again

Kama