Sign in to follow this  
Followers 0
EddCase

Error multi-line 'if' missing 'then'

3 posts in this topic

Hi guys i'm almost done but having a few issues, I'm writing myself a little app to run with Handbrake so that instead of always automatically running the sample it pops up a message box everything works, but I'm having an issue when I try and add some error checking, this is my code so far

#Region ;**** Directives created by AutoIt3Wrapper_GUI ****
#AutoIt3Wrapper_Icon=..\Downloads\vlc.ico
#EndRegion ;**** Directives created by AutoIt3Wrapper_GUI ****
#include <ButtonConstants.au3>
#include <GUIConstantsEx.au3>
#include <StaticConstants.au3>
#include <WindowsConstants.au3>
#Region ### START Koda GUI section ### Form=c:\program files (x86)\autoit3\forms\frmmain.kxf
$frmMain = GUICreate("VLC Launcher", 301, 111, -1, -1)
GUISetIcon("launcher.exe", -1)
$lblEddCase = GUICtrlCreateLabel("By EddCase", 220, 90, 80, 20)
GUICtrlSetState(-1, $GUI_DISABLE)
$btnLaunch = GUICtrlCreateButton("Launch VLC Player", 10, 10, 280, 80)
GUICtrlSetFont(-1, 10, 400, 0, "MS Sans Serif")
GUISetState(@SW_SHOW)
#EndRegion ### END Koda GUI section ###
While 1
$nMsg = GUIGetMsg()
Switch $nMsg
Case $GUI_EVENT_CLOSE
Exit
Case $btnLaunch
$reg = RegRead ( "HKEY_LOCAL_MACHINE\SOFTWARE\VideoLAN\VLC\", "" )
If @error = 1 Then $reg = RegRead ( "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\VideoLAN\VLC\", "" )
     If @error = 1 Then MsgBox (0, "VideoLan", "VLC is not installed, please install and rerun") & ShellExecute ("http://www.videolan.org/index.html")
WinActivate ("HandBrake")
WinWaitActive("HandBrake")
ControlFocus ("HandBrake", "", "[NAME:text_destination]")
Send("^a")
Send("^c")
$destination = ClipGet()
$short = StringTrimRight ($destination,4)
$file = $short & "_sample.mkv"
run ( '"' & $reg & '"' &" "&"-vvv"&" "& '"' & $file & '"')
Exit

EndSwitch
WEnd

the issue I'm having is with this section

$reg = RegRead ( "HKEY_LOCAL_MACHINE\SOFTWARE\VideoLAN\VLC\", "" )
If @error = 1 Then $reg = RegRead ( "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\VideoLAN\VLC\", "" )
     If @error = 1 Then MsgBox (0, "VideoLan", "VLC is not installed, please install and rerun") & ShellExecute ("http://www.videolan.org/index.html")

It gives me the Error multi-line 'if' missing 'then', I'm trying to read the 32bit registry key, if its not there then trying the 64bit registry key if that key doesn't exist either then bring up the message box and open the vlc web page.

Thanks in advance for your help

Edd

Share this post


Link to post
Share on other sites



EddCase,

What are you expecting to happen with this line: :huh:

If @error = 1 Then MsgBox (0, "VideoLan", "VLC is not installed, please install and rerun") & ShellExecute ("http://www.videolan.org/index.html")

Because it make no sense at all at present. Do you want a MsgBox and then a browser opening? If that is the case then:

If @error = 1 Then
    $reg = RegRead ( "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\VideoLAN\VLC\", "" )
    If @error = 1 Then 
        MsgBox (0, "VideoLan", "VLC is not installed, please install and rerun")
        ShellExecute ("http://www.videolan.org/index.html")
    EndIf
EndIf

might be a better bet. ;)

M23

1 person likes this

Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind._______My UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Share this post


Link to post
Share on other sites

The reason behind this is that & in AutoIt is the string concatenation operator.

Because AutoIt is dynamically typed, the action part of your If statement is a string. So it's equivaalent to the following:

If <condition> Then <string>

This is a syntax error since <string> by itself is not a valid statement.

Things are different when the action part (after the Then keyword) is indeed a valid statement. Run this by itself to see what happens:

Local $str
If @error <> 1 Then $str = MsgBox (0, "VideoLan", "VLC is not installed, please install and rerun") & ' -- ' & ShellExecute ("http://www.videolan.org/index.html")
MsgBox(0, '', $str)

Note that I've inserted ' -- ' only for readability. The internal result of both statements (MsgBox and ShellExecute) are converting to strings because the & operator which forces conversion to strings then the whole string is assigned to a variable, a valid standalone AutoIt statement.

Of course I don't advocate using such useless assignment to string (or any type whatsoever) just to use a single-line If in place of a much clearer multi-line If, but I hope this note helps you understand why you got the error in the first place.


This wonderful site allows debugging and testing regular expressions (many flavors available). An absolute must have in your bookmarks.
Another excellent RegExp tutorial. Don't forget downloading your copy of up-to-date pcretest.exe and pcregrep.exe here
RegExp tutorial: enough to get started
PCRE v8.33 regexp documentation latest available release and currently implemented in AutoIt beta.

SQLitespeed is another feature-rich premier SQLite manager (includes import/export). Well worth a try.
SQLite Expert (freeware Personal Edition or payware Pro version) is a very useful SQLite database manager.
An excellent eBook covering almost every aspect of SQLite3: a must-read for anyone doing serious work.
SQL tutorial (covers "generic" SQL, but most of it applies to SQLite as well)
A work-in-progress SQLite3 tutorial. Don't miss other LxyzTHW pages!
SQLite official website with full documentation (may be newer than the SQLite library that comes standard with AutoIt)

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0