Sign in to follow this  
Followers 0
axy108

if not working correctly

4 posts in this topic

Hi All,

I am trying to automate some websites but I am facing an issue trying to validate if the login screen is been shown or not.

Local $userName = 'user'
Local $password = 'password'
Local $oIE = _IECreate()
WinSetState("Blank Page", "", @SW_MAXIMIZE)
_IENavigate($oIE, "http://url.com")
_IELoadWait($oIE)
_IEGetObjByName($oIE, "ssousername")
AutoItSetOption("SendKeyDelay", 50)
If @error = 0 Then
enterUserNameAndPassword($userName, $password)
EndIf
Local $oNew = _IEGetObjById($oIE, "New")
_IEAction($oNew, "click")
_IELoadWait($oIE)


func enterUserNameAndPassword( $userName, $password)
Local $oUserId = _IEGetObjByName($oIE, "ssousername")
AutoItSetOption("SendKeyDelay", 50)
_IEAction($oUserId, "focus")
Send($userName)
Send("{TAB}")
Send($password)
Local $oLogin = _IEGetObjById($oIE, "loginButton")
_IEAction($oLogin, "click")
_IELoadWait($oIE)
EndFunc

I just wan to execute the enterUserNameAndPassword function if the get username object was successed and if not I want to continue with the next steps. But when I run the script the lines Send("{TAB}") and Send($password) are being executed and I do not know why. Does anybody know what is going on?

Really appreciate your help!

Thanks,

axy108.

Share this post


Link to post
Share on other sites



You're checking for an error here:

AutoItSetOption("SendKeyDelay", 50)
If @error = 0 Then

Which only checks to see if AutoItSetOption was able to set the option correctly. In this case it's going to work, so @error will equal 0, so it is going to run the function.

You need to check @error directly after the function that you want to check the errors from, because it is reset after every function, so it's not going to work correctly the way you have it.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

#3 ·  Posted (edited)

All that work to use the _IE* functions, and then you don't use them to populate the fields?

This function will save a lot of headaches, rather than the 'send' commands which may be consumed by other apps: _IEFormElementSetValue

Edited by jdelaney

IEbyXPATH-Grab IE DOM objects by XPATH IEscriptRecord-Makings of an IE script recorder ExcelFromXML-Create Excel docs without excel installed GetAllWindowControls-Output all control data on a given window.

Share this post


Link to post
Share on other sites

Thanks BrewManNH I didn't know that the error check worked that way I have been working with AutoIt only for a couple of weeks now. The script is working now :).

And thanks jdelaney, I also didn't know about the function you mentioned but I looked for it in the help and now I am using it and you are right it's a lot much easier.

Thanks again to both of you.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0