Jump to content
Sign in to follow this  
gcue

good way to determine a filecopy is complete?

Recommended Posts

gcue

hello world!

i have seen other examples in the forum where people have come across filecopy's not completing so the next steps fail

i am also coming across this issue with this (doesnt always happen but the file ends up deleting - guess because its in the midst of being replaced then the shellexecute command is called so it interrupts the copy? - not sure)

FileCopy($remote_file, $local_file, 1)

ShellExecute($local_file)

im curious how other people might be addressing this issue - was thinking of approaching it this way...

$copy = FileCopy($remote_file, $local_file, 1)

While 1
     If $copy Then ExitLoop
WEnd

ShellExecute($local_file)

thanks!

Edited by gcue

Share this post


Link to post
Share on other sites
BrewManNH

You have no exit strategy for failure, if the copy fails, it's stuck in the While loop forever.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites
gcue

wont it return 0 if it fails?

maybe im misinterpreting what "if $copy then" means

i thought it meant if $copy has value then

Share this post


Link to post
Share on other sites
BrewManNH

"If $Copy Then" means do whatever is after Then only if $Copy is not zero, it's a boolean check of the variable and you're checking it to be True.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites
gcue

so should i do if $copy = 0 or $copy = 1 then.... ?

Share this post


Link to post
Share on other sites
BrewManNH

FileCopy pauses the script until it is done, the While loop is redundant. You should check to see if it was successful rather than pausing the script and doing the same thing. If it's successful, run the ShellExecute line, if it's not you will need to figure out why it failed.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites
jdelaney

The next line after FileCopy will not execute until it is succesfull, or fails. It seems that you are assuming that the boolean gets set asynchronously, which is not the case. Simple error handling will fix your script

If FileCopy($remote_file, $local_file, 1) Then
ShellExecute($local_file)
Else
MsgBox ( 1,1,"FileCopy failed")
EndIf
Edited by jdelaney

IEbyXPATH-Grab IE DOM objects by XPATH IEscriptRecord-Makings of an IE script recorder ExcelFromXML-Create Excel docs without excel installed GetAllWindowControls-Output all control data on a given window.

Share this post


Link to post
Share on other sites
gcue

im not sure if the copy fails bc the shellexecute happens before the copy completes - its not a rights issue for sure bc it works sometimes. source is on a network file share so im thinking its taking extra long to complete the copy

Share this post


Link to post
Share on other sites
BrewManNH

Filecopy pauses the script until it finishes, either successfully or not. If the ShellExecute is running, then FileCopy has finished, and probably failed. You need to read the return value from the FileCopy to see if it's 0 (fail) or 1 (success), and deal with it from there. Unfortunately FileCopy doesn't tell you why it failed, just that it did.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites
gcue

thanks for the help =)

Share this post


Link to post
Share on other sites
kylomas

gcue,

You will be better off using Yashied's Copy UDF

kylomas


Forum Rules         Procedure for posting code

"I like pigs.  Dogs look up to us.  Cats look down on us.  Pigs treat us as equals."

- Sir Winston Churchill

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

×