Jump to content
Sign in to follow this  
tbcauley

Reading File Line by Line with FileOpenDialog

Recommended Posts

tbcauley

I have a script that will read a source file line by line as long as I dont use the FileOpenDialog to select the source file.  Below is an example of my script.  It will see both the log file and the source file, but it hangs on t he first line of the source file.  Any help would be appreciated.  Thanks.

#include <file.au3>
#include <inet.au3>

Dim $logfile = FileOpenDialog("LogFile Select","C:\PCS\","Comma Separated Value (*.csv)",2+8, "pinglog.csv")
Dim $srcfile = FileOpenDialog("Source File Select","C:\PCS\","Text File (*.txt)",2+8, "IPs.txt")

FileWriteLine($logfile, "Ping Log Started:," & @MDAY & "." & @MON & "." & @YEAR & "_" & @HOUR & ":" & @MIN & ":" & @SEC)
FileWriteLine($logfile, "IP Address,PC Name,Status")

TCPStartup()

While 1
    $pcIP = FileReadLine($srcfile)
    If @error = -1 Then ExitLoop

    $pResult = _TCPIpToName($pcIP,0)

    FileWriteLine($logfile,$pcIP & "," & $pResult)
WEnd

FileClose($logfile)
FileClose($srcfile)

MsgBox(0,Default,"Script is complete.")

Share this post


Link to post
Share on other sites
BrewManNH

You should probably use FileOpen after FileOpenDialog so that FileReadLine will work more efficiently. That way you're using a file handle rather than a file name when you're reading from it.

You should also verify that the variable $srcfile contains what you're expecting it to contain.


If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

×