UBound()

[billshu]

I have this code to process Array elements 2 thru N

For $i = 2 to (UBound($TablePID) - 1)
     ProcessQueueChild( ($i) )

Next

The problem is that one of the functions of ProcessQueueChild() is to ADD, Delete or Modify entries from the table $TablePID. I get arry index out of range errors when ProcessQueueChild() deletes a $TablePID element.

I replaced this with the following code:

   $LocalQueue = 2
   If (UBound($TablePID) > 2) Then
      Do
         ProcessQueueChild($LocalQueue)
         $LocalQueue = $LocalQueue + 1
      until ($LocalQueue > (UBound($TablePID)-1)   )
   Else
      $TMMyString = "No Child Queues to Process "
      FileWrite($hFileOpen, $TMMyString & @CRLF)
   EndIf

This seems to work so far, but is there a cleaner way to process this loop. 

[czardas]

Something like this perhaps? Note - none of the variables have been declared in the posted examples.

;

$iBound = UBound($TablePID)
   If $iBound > 2 Then
       For $LocalQueue = 2 To $iBound -1
           ProcessQueueChild($LocalQueue)
       Next
   Else
      $TMMyString = "No Child Queues to Process "
      FileWrite($hFileOpen, $TMMyString & @CRLF)
   EndIf

Edited August 17, 2014 by czardas

[mikell]

?

For $i = UBound($TablePID)-1 to 2 step -1
     ProcessQueueChild($i) 
Next

[billshu]

 

?

For $i = UBound($TablePID)-1 to 2 step -1
     ProcessQueueChild($i) 
Next

 

Great, I knew there was a cleaner way.  I had not consider processing in reverse order, but I see that is perfect.

Thanks for you help

[czardas]

It's impossible to determine the best solution without seeing the function ProcessQueueChild. Also it's cleaner to only call Ubound once.

Edit

Hmm, I didn't read the first part of the question properly - sorry. I just recoded the example that was meant to be working.

You really should have told me that the solution I posted wasn't working, then I would have looked more closely. Even if my understanding was at fault - it's only polite if someone tries to help you.

Edited August 17, 2014 by czardas

[corgano]

 

?

For $i = UBound($TablePID)-1 to 2 step -1
     ProcessQueueChild($i) 
Next

Simpler than what I was thinking of

For $i = 2 to 2^30
     If $i > (UBound($TablePID) - 1) then exitloop
     ProcessQueueChild( ($i) )
Next

Lol