About ShellExecuteWait

[tonysing]

Hello Guys,

I am try to make a upgrade patch of Adobe FlashPlayer and Reader, but things didn't get really well.

Here is some part of the code

If FileExists($folder) then
   ShellExecuteWait("uninstall_flash_player.exe"," -uninstall")
   ShellExecuteWait("uninstall_flash_player.exe"," /silent")
EndIf
warn(4000)
ShellExecuteWait("msiexec.exe"," /i install_flash_player_14_active_x.msi /norestart /qn")
ShellExecuteWait("msiexec.exe"," /i install_flash_player_14_plugin.msi /norestart /qn")

If $var == "11.0.07" Then   ;The new update require ver. 11.0.07 or later
    ShellExecuteWait("msiexec.exe", "/update AdbeRdrUpd11008.msp /qn /norestart", "",  "open") 
Else
    ShellExecuteWait("msiexec.exe", "/i AdbeRdr11000_en_US.msi TRANSFORMS=AdbeRdr11000_en_US.mst /qn", "",  "open")
    ShellExecuteWait("msiexec.exe", "/update AdbeRdrUpd11007.msp /qn /norestart", "",  "open")
    ShellExecuteWait("msiexec.exe", "/update AdbeRdrUpd11008.msp /qn /norestart", "",  "open")
EndIf

For the flashplayer, after the player is uninstalled, it didn't really reinstall it back.

For the reader, the reader is only updated to 11.0.07 if the reader version is below 11.0.07 at first.

Can anybody tell me what's wrong with my script? Thanks a lot

[bordomavi]

If FileExists($folder) then
   ShellExecuteWait("uninstall_flash_player.exe", '/VERYSILENT /NORESTART')
EndIf
warn(4000)
ShellExecuteWait("install_flash_player_14_active_x.msi", '/qn /norestart')
ShellExecuteWait("install_flash_player_14_plugin.msi", '/qn /norestart')

;

If $var == "11.0.07" Then   ;The new update require ver. 11.0.07 or later
    ShellExecuteWait("update AdbeRdrUpd11008.msp" '/qn /norestart') 
Else
    ShellExecuteWait("AdbeRdr11000_en_US.msi", '/qn /norestart')
    ShellExecuteWait("update AdbeRdrUpd11007.msp", '/qn /norestart')
    ShellExecuteWait("update AdbeRdrUpd11008.msp", '/qn /norestart')
EndIf

it must be work

[tonysing]

Thanks, I will try this by tmr as I am not in the office now

Sorry, it doesn't work at all. It can't even remove flashplayer at first. The program just doing nothing.

Is it work well on your PC?

Edited September 8, 2014 by tonysing

[JLogan3o13]

For the first one, if you say it is uninstalling successfully, have you tried adding a sleep in before you then try installing?

For the second one, why not just go out to Adobe's website and fill out the form (takes 2 minutes) to get a redistributable license? Then you can download the full MSI package with not bloatware (beyond Adobe itself, of course), and install it. You can skip doing all the .msp's this way.