Jump to content

ArraySearch Question


RickB75
 Share

Recommended Posts

Guys,

       Can you guys tell me why I'm getting this error with this script.

"Array variable has incorrect number of subscripts or subscript dimension range exceeded.:"

I'm pretty sure it's because $secondArray is larger than the $firstArray. I didn't think the size of the two seperate arrays mattered though if I'm doing a search. I tell it the position of the data in the 2nd array I want to search the 1st array for. Why does the size of the 1st array matter? Or am I completely not understanding it.  

#include <Array.au3>

Local $firstArray[1] = [1]

Local $secondArray[1] = [1]

For $i = 0 To 50
    _ArrayAdd($firstArray,$i)

Next

_ArrayDisplay($firstArray)

For $i = 0 To 55
    _ArrayAdd($secondArray,$i)

Next

_ArrayDisplay($secondArray)


For $iCt = 0 To UBound($secondArray)

    $aSearch =  _ArraySearch($firstArray,$secondArray[$iCt])

    If @error = 6 Then
        MsgBox(0,"Not Found", "Item not found in firstArray " & $secondArray[$iCt] )

    EndIf

Next
Link to comment
Share on other sites

It's because the array $secondarray has 57 items in it, but they're numbered from 0 to 56, so when you do a UBound($secondarray) that returns with 57. Your For/Next loop counts up to 57, but you only have $secondarray[56] items in the array.

Use For $iCt = 0 To UBound($secondArray) - 1 instead, remove one from the count.

If I posted any code, assume that code was written using the latest release version unless stated otherwise. Also, if it doesn't work on XP I can't help with that because I don't have access to XP, and I'm not going to.
Give a programmer the correct code and he can do his work for a day. Teach a programmer to debug and he can do his work for a lifetime - by Chirag Gude
How to ask questions the smart way!

I hereby grant any person the right to use any code I post, that I am the original author of, on the autoitscript.com forums, unless I've specifically stated otherwise in the code or the thread post. If you do use my code all I ask, as a courtesy, is to make note of where you got it from.

Back up and restore Windows user files _Array.au3 - Modified array functions that include support for 2D arrays.  -  ColorChooser - An add-on for SciTE that pops up a color dialog so you can select and paste a color code into a script.  -  Customizable Splashscreen GUI w/Progress Bar - Create a custom "splash screen" GUI with a progress bar and custom label.  -  _FileGetProperty - Retrieve the properties of a file  -  SciTE Toolbar - A toolbar demo for use with the SciTE editor  -  GUIRegisterMsg demo - Demo script to show how to use the Windows messages to interact with controls and your GUI.  -   Latin Square password generator

Link to comment
Share on other sites

  • Moderators

RickB75,

The problem lies here:

For $iCt = 0 To UBound($secondArray)
As the first element of the array is [0], the highest index is always one less that the number of elements. ;)

Use:

For $iCt = 0 To UBound($secondArray) - 1
and all will be well. :)

M23

Public_Domain.png.2d871819fcb9957cf44f4514551a2935.png Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind

Open spoiler to see my UDFs:

Spoiler

ArrayMultiColSort ---- Sort arrays on multiple columns
ChooseFileFolder ---- Single and multiple selections from specified path treeview listing
Date_Time_Convert -- Easily convert date/time formats, including the language used
ExtMsgBox --------- A highly customisable replacement for MsgBox
GUIExtender -------- Extend and retract multiple sections within a GUI
GUIFrame ---------- Subdivide GUIs into many adjustable frames
GUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView items
GUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeView
Marquee ----------- Scrolling tickertape GUIs
NoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxes
Notify ------------- Small notifications on the edge of the display
Scrollbars ----------Automatically sized scrollbars with a single command
StringSize ---------- Automatically size controls to fit text
Toast -------------- Small GUIs which pop out of the notification area

 

Link to comment
Share on other sites

Thank guys. I knew it was something simple that I was overlooking. By me adding - 1, that shouldn't change any of the data positions in $secondArray I think. It will just reduce the total count (UBound) it loops through. The phrase "Can't see the forest for the trees" is coming to mind right now :)

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...