Button Keeps Flashing

[jazzyjeff]

I have a button that keeps flashing my GUI. If I move the button in the Group that I created, the flashing stops, but the button also stops working. If I move it out of the group, the button works but continuously flashes. I am stuck right now on how to fix this.

Can someone please review my code and see what I have done wrong please?

There is a part of the script at the end of the _Information() function that will disable and enable a button depending on whether a variable is an array or not.

The button is created at the start of the GUI and is called, $btnShowUpdates.

expandcollapse popup

#NoTrayIcon
#include <ButtonConstants.au3>
#include <GUIConstantsEx.au3>
#include <GUIListViewEx.au3>
#include <GUIListBox.au3>
#include <StaticConstants.au3>
#include <WindowsConstants.au3>
#include <SQLite.au3>
#include <SQLite.dll.au3>
#include <Array.au3>
#include <AD.au3>
#include <String.au3>
#include <Misc.au3>

;Global $rUser = $CMDLINE[1]
$rUser = @UserName
Local $iRows, $iColumns, $software ; For SQL Array
Local $listApps, $btnShowUpdates ; GUI Controls
Local $selApp, $selAppReg, $version, $architecture, $restrictions, $limit, $profile, $versionInst, $versionInstChk, $installDate, $publisher, $estimatedSize, $uninstall ;Listview
Local $arrayHKCU_UnInst,$arrayHKLM_Inst,$arrayHKLM_Inst64,$arrayHKLM_UnInst,$arrayHKLM_UnInst64, $arrayUpdates ;Application/registry Arrays
Local $sHKLM_Inst = "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\Userdata\S-1-5-18\Products"
Local $sHKLM_Inst64 = "HKEY_LOCAL_MACHINE64\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\Userdata\S-1-5-18\Products"
Local $sHKLM_UnInst64 = "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\Windows\CurrentVersion\Uninstall"
Local $sHKLM_UnInst = "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall"
Local $sHKCU_UnInst = "HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Uninstall"

#Region ### START Koda GUI section ### Form=
SplashImageOn(" Application Store - Loading...",@ScriptDir & "\logo1_new.JPG",295,175,-1,-1)
$mainForm = GUICreate(" Application Store", 615, 438,-1,-1)
$listApps = _GUICtrlListView_Create($mainForm, "Application", 8, 8, 217, 422)
_GUICtrlListView_SetColumnWidth($listApps, 0, 217)
$listOptions = GUICtrlCreateList("", 232, 268, 121, 162)
$btnExecute = GUICtrlCreateButton("&Execute", 360, 272, 123, 81)
$btnRefresh = GUICtrlCreateButton("&Refresh", 488, 272, 123, 81)
$btnAdmin = GUICtrlCreateButton("&Admin Options", 360, 352, 123, 81)
$btnExit = GUICtrlCreateButton("E&xit", 488, 352, 123, 81)
$btnShowUpdates = GUICtrlCreateButton("Show",488,70,60,15)
GUICtrlSetFont(-1,7)
$groupApp = GUICtrlCreateGroup("Application Information", 232, 8, 233, 145)
$labelInfo = GUICtrlCreateLabel("", 240, 32, 210, 110)
GUICtrlCreateGroup("", -99, -99, 1, 1)
$groupSystem = GUICtrlCreateGroup("System Information", 232, 160, 233, 105)
$labelSystem = GUICtrlCreateLabel("Computer Name: " & @ComputerName & @CRLF & "Username: " & $rUser & @CRLF & "Architecture: " & @OSArch & @CRLF & "Operating System: " & @OSVersion, 240, 182, 210, 80)
GUICtrlCreateGroup("", -99, -99, 1, 1)
$groupStatus = GUICtrlCreateGroup("Application Status", 472, 8, 137, 257)
$labelStatus = GUICtrlCreateLabel("", 488, 32, 108, 210)
GUICtrlCreateGroup("", -99, -99, 1, 1)
#EndRegion ### END Koda GUI section ###
_AD_Open()
$arrayGroups = _AD_RecursiveGetMemberOf($rUser)
_AD_Close()
$arrayGroups = _ArrayToString($arrayGroups,"|")
$arrayGroups = StringSplit($arrayGroups,"|")
$arrayGroups = _ArrayUnique($arrayGroups)
_ArrayDelete($arrayGroups,1)
_ArrayDelete($arrayGroups,0)
_ArrayDelete($arrayGroups,0)
_ArrayInsert($arrayGroups,0,UBound($arrayGroups))
For $i = 1 To $arrayGroups[0]
    If _StringBetween($arrayGroups[$i],"CN=",",")[0] = "Admins" Or _StringBetween($arrayGroups[$i],"CN=",",")[0] = "Enterprise Admins" Or _StringBetween($arrayGroups[$i],"CN=",",")[0] = "tech" Then
        GUICtrlSetState($btnAdmin, $GUI_ENABLE)
        ExitLoop
    Else
        GUICtrlSetState($btnAdmin, $GUI_DISABLE)
    EndIf
Next
_RefreshList()
_User()
GUISetState(@SW_SHOW)
SplashOff()
AdlibRegister("_Information",500)
AdlibRegister("_CheckUpdates",1000)
While 1
    Sleep(50)
    $nMsg = GUIGetMsg()
    Switch $nMsg
        Case $GUI_EVENT_CLOSE
            AdlibUnRegister("_Information")
            AdlibUnRegister("_CheckUpdates")
            Exit
        Case $btnExit
            AdlibUnRegister("_Information")
            AdlibUnRegister("_CheckUpdates")
            Exit
        Case $btnAdmin ; Calls Function _Admin to enable extra options in the $listOptions
            _Admin()
        Case $btnExecute
            _CheckUpdates()
        Case $btnRefresh
            _RefreshList()
        Case $btnShowUpdates
            _ArrayDisplay($arrayUpdates, "Updates available", "", 32)
    EndSwitch
WEnd

Func _RefreshList()
    _SQLite_Startup()
    ;ConsoleWrite("_SQLite_LibVersion=" & _SQLite_LibVersion() & @CRLF)
    $sql = _SQLite_Open(@ScriptDir & "\Software.db")
    $iRVal = _SQLite_GetTable2d($sql, 'SELECT * FROM Software;', $software, $iRows, $iColumns)
    ;_ArrayDisplay($software)
    For $i = 1 To UBound($software) - 1
        _GUICtrlListView_AddItem($listApps, $software[$i][2])
    Next
    _SQLite_Close()
    _SQLite_Shutdown()
EndFunc   ;==>_RefreshList

Func _AppInfo() ; Extract registry sub keys to scan registry for installed software.
    $i = 1
    $sSubKey = ""
    While 2
        $sSubKey = $sSubKey & RegEnumKey($sHKLM_Inst, $i) & "|"
        If @error Then ExitLoop
        ;Msgbox(0,"HKLM_Inst","SubKey #" & $i & " under " & $sHKLM_Inst & "\" & $sSubKey & @CRLF)
        $i += 1
    WEnd
    $arrayHKLM_Inst = $sSubKey
    Do
        If StringRight($arrayHKLM_Inst, 1) = "|" Then
            $arrayHKLM_Inst = StringTrimRight($arrayHKLM_Inst, 1)
        EndIf
    Until StringRight($arrayHKLM_Inst, 1) <> "|"
    $arrayHKLM_Inst = StringSplit($arrayHKLM_Inst, "|")
    ;_ArrayDisplay($arrayHKLM_Inst)
    $i = 1
    $sSubKey = ""
    While 2
        $sSubKey = $sSubKey & RegEnumKey($sHKLM_Inst64, $i) & "|"
        If @error Then ExitLoop
        ;Msgbox(0,"HKLM_Inst64","SubKey #" & $i & " under " & $sHKLM_Inst64 & "\" & $sSubKey & @CRLF)
        $i += 1
    WEnd
    $arrayHKLM_Inst64 = $sSubKey
    Do
        If StringRight($arrayHKLM_Inst64, 1) = "|" Then
            $arrayHKLM_Inst64 = StringTrimRight($arrayHKLM_Inst64, 1)
        EndIf
    Until StringRight($arrayHKLM_Inst64, 1) <> "|"
    $arrayHKLM_Inst64 = StringSplit($arrayHKLM_Inst64, "|")
    ;_ArrayDisplay($arrayHKLM_Inst64)
    $i = 1
    $sSubKey = ""
    While 2
        $sSubKey = $sSubKey & RegEnumKey($sHKLM_UnInst, $i) & "|"
        If @error Then ExitLoop
        ;Msgbox(0,"HKLM_UnInst","SubKey #" & $i & " under " & $sHKLM_UnInst & "\" & $sSubKey & @CRLF)
        $i += 1
    WEnd
    $arrayHKLM_UnInst = $sSubKey
    Do
        If StringRight($arrayHKLM_UnInst, 1) = "|" Then
            $arrayHKLM_UnInst = StringTrimRight($arrayHKLM_UnInst, 1)
        EndIf
    Until StringRight($arrayHKLM_UnInst, 1) <> "|"
    $arrayHKLM_UnInst = StringSplit($arrayHKLM_UnInst, "|")
    ;_ArrayDisplay($arrayHKLM_UnInst)
    $i = 1
    $sSubKey = ""
    While 2
        $sSubKey = $sSubKey & RegEnumKey($sHKLM_UnInst64, $i) & "|"
        If @error Then ExitLoop
        ;Msgbox(0,"HKLM_UnInst64","SubKey #" & $i & " under " & $sHKLM_UnInst64 & "\" & $sSubKey & @CRLF)
        $i += 1
    WEnd
    $arrayHKLM_UnInst64 = $sSubKey
    Do
        If StringRight($arrayHKLM_UnInst64, 1) = "|" Then
            $arrayHKLM_UnInst64 = StringTrimRight($arrayHKLM_UnInst64, 1)
        EndIf
    Until StringRight($arrayHKLM_UnInst64, 1) <> "|"
    $arrayHKLM_UnInst64 = StringSplit($arrayHKLM_UnInst64, "|")
    ;_ArrayDisplay($arrayHKLM_UnInst64)
    $i = 1
    $sSubKey = ""
    While 2
        $sSubKey = $sSubKey & RegEnumKey($sHKCU_UnInst, $i) & "|"
        If @error Then ExitLoop
        ;Msgbox(0,"HKCU_Inst","SubKey #" & $i & " under " & $sHKCU_UnInst & "\" & $sSubKey & @CRLF)
        $i += 1
    WEnd
    $arrayHKCU_UnInst = $sSubKey
    Do
        If StringRight($arrayHKCU_UnInst, 1) = "|" Then
            $arrayHKCU_UnInst = StringTrimRight($arrayHKCU_UnInst, 1)
        EndIf
    Until StringRight($arrayHKCU_UnInst, 1) <> "|"
    $arrayHKCU_UnInst = StringSplit($arrayHKCU_UnInst, "|")
    ;_ArrayDisplay($arrayHKCU_UnInst)
EndFunc   ;==>_AppInfo

Func _Information()
    ;*********** Scan Registry for keys to check ***********
    _AppInfo()
    ;*********** Check which application has been selected ***********
    $iData = _GUICtrlListView_GetItemCount($listApps)
    For $d = 0 To $iData
        If _GUICtrlListView_GetItemSelected($listApps, $d) Then
            $selApp = _GUICtrlListView_GetItemText($listApps,$d)
            ExitLoop
        EndIf
    Next
    ;*********** Read database array for selected application ***********
    For $i = 1 To UBound($software) - 1
        If $software[$i][2] = $selApp Then
            $version = $software[$i][3]
            $architecture = $software[$i][11]
            If $software[$i][6] Or $software[$i][7] <> "" Then
                $restrictions = "Yes"
            Else
                $restrictions = "No"
            EndIf
            $limit = $software[$i][8]
            $profile = $software[$i][9]
            $selAppReg = $software[$i][1]
            ExitLoop
        EndIf
    Next
    ;*********** Scan Registry for selected application information. Set variables accordingly. ***********
    $versionInst = 0
    $installDate = "N/A"
    $publisher = "N/A"
    $estimatedSize = "N/A"
    For $i = 1 To $arrayHKCU_UnInst[0]
        If StringInStr(RegRead($sHKCU_UnInst & "\" & $arrayHKCU_UnInst[$i],"DisplayName"),$selAppReg) Then
            $versionInst = RegRead($sHKCU_UnInst & "\" & $arrayHKCU_UnInst[$i],"DisplayVersion")
            $installDate = RegRead($sHKCU_UnInst & "\" & $arrayHKCU_UnInst[$i],"InstallDate")
            $uninstall = RegRead($sHKCU_UnInst & "\" & $arrayHKCU_UnInst[$i],"UninstallString")
            $publisher = RegRead($sHKCU_UnInst & "\" & $arrayHKCU_UnInst[$i],"Publisher")
            $estimatedSize = RegRead($sHKCU_UnInst & "\" & $arrayHKCU_UnInst[$i],"EstimatedSize"); Value is in KB
        EndIf
    Next
    For $i = 1 To $arrayHKLM_Inst[0]
        If StringInStr(RegRead($sHKLM_Inst & "\" & $arrayHKLM_Inst[$i],"DisplayName"),$selAppReg) Then
            If _VersionCompare(RegRead($sHKLM_Inst & "\" & $arrayHKLM_Inst[$i],"DisplayVersion"),$versionInst) = 1 Then
                $versionInst = RegRead($sHKLM_Inst & "\" & $arrayHKLM_Inst[$i],"DisplayVersion")
                $installDate = RegRead($sHKLM_Inst & "\" & $arrayHKLM_Inst[$i],"InstallDate")
                $uninstall = RegRead($sHKLM_Inst & "\" & $arrayHKLM_Inst[$i],"UninstallString")
                $publisher = RegRead($sHKLM_Inst & "\" & $arrayHKLM_Inst[$i],"Publisher")
                $estimatedSize = RegRead($sHKLM_Inst & "\" & $arrayHKLM_Inst[$i],"EstimatedSize"); Value is in KB
            EndIf
        EndIf
    Next
    For $i = 1 To $arrayHKLM_Inst64[0]
        If StringInStr(RegRead($sHKLM_Inst64 & "\" & $arrayHKLM_Inst64[$i],"DisplayName"),$selAppReg) Then
            If _VersionCompare(RegRead($sHKLM_Inst64 & "\" & $arrayHKLM_Inst64[$i],"DisplayVersion"),$versionInst) = 1 Then
                $versionInst = RegRead($sHKLM_Inst64 & "\" & $arrayHKLM_Inst64[$i],"DisplayVersion")
                $installDate = RegRead($sHKLM_Inst64 & "\" & $arrayHKLM_Inst64[$i],"InstallDate")
                $uninstall = RegRead($sHKLM_Inst64 & "\" & $arrayHKLM_Inst64[$i],"UninstallString")
                $publisher = RegRead($sHKLM_Inst64 & "\" & $arrayHKLM_Inst64[$i],"Publisher")
                $estimatedSize = RegRead($sHKLM_Inst64 & "\" & $arrayHKLM_Inst64[$i],"EstimatedSize"); Value is in KB
            EndIf
        EndIf
    Next
    For $i = 1 To $arrayHKLM_UnInst[0]
        If StringInStr(RegRead($sHKLM_UnInst & "\" & $arrayHKLM_UnInst[$i],"DisplayName"),$selAppReg) Then
            If _VersionCompare(RegRead($sHKLM_UnInst & "\" & $arrayHKLM_UnInst[$i],"DisplayVersion"),$versionInst) = 1 Then
                $versionInst = RegRead($sHKLM_UnInst & "\" & $arrayHKLM_UnInst[$i],"DisplayVersion")
                $installDate = RegRead($sHKLM_UnInst & "\" & $arrayHKLM_UnInst[$i],"InstallDate")
                $uninstall = RegRead($sHKLM_UnInst & "\" & $arrayHKLM_UnInst[$i],"UninstallString")
                $publisher = RegRead($sHKLM_UnInst & "\" & $arrayHKLM_UnInst[$i],"Publisher")
                $estimatedSize = RegRead($sHKLM_UnInst & "\" & $arrayHKLM_UnInst[$i],"EstimatedSize"); Value is in KB
            EndIf
        EndIf
    Next
    For $i = 1 To $arrayHKLM_UnInst64[0]
        If StringInStr(RegRead($sHKLM_UnInst64 & "\" & $arrayHKLM_UnInst64[$i],"DisplayName"),$selAppReg) Then
            If _VersionCompare(RegRead($sHKLM_UnInst64 & "\" & $arrayHKLM_UnInst64[$i],"DisplayVersion"),$versionInst) = 1 Then
                $versionInst = RegRead($sHKLM_UnInst64 & "\" & $arrayHKLM_UnInst64[$i],"DisplayVersion")
                $installDate = RegRead($sHKLM_UnInst64 & "\" & $arrayHKLM_UnInst64[$i],"InstallDate")
                $uninstall = RegRead($sHKLM_UnInst64 & "\" & $arrayHKLM_UnInst64[$i],"UninstallString")
                $publisher = RegRead($sHKLM_UnInst64 & "\" & $arrayHKLM_UnInst64[$i],"Publisher")
                $estimatedSize = RegRead($sHKLM_UnInst64 & "\" & $arrayHKLM_UnInst64[$i],"EstimatedSize"); Value is in KB
            EndIf
        EndIf
    Next
    If $versionInst = 0 Then
        $versionInst = "Not installed"
        $installDate = "N/A"
        $publisher = "N/A"
        $estimatedSize = "N/A"
    EndIf
    ;*********** Check application update requirements ***********
    ;_CheckUpdates()
    ;*********** Set labels with system and application information ***********
    GUICtrlSetData($labelInfo,"Application Name: " & @CR & "Installed Version: " & @CR & "Available Version: " & @CR & "Architecture: " & @CR & "Restrictions: " & @CR & "Install Limit: " & @CR & "Profile Application: ")
    GUICtrlSetData($labelInfo,"Application Name: " & $selApp & @CR & "Installed Version: " & $versionInst & @CR & "Available Version: " & $version & @CR & "Architecture: " & $architecture & @CR & "Restrictions: " & $restrictions & @CR & "Install Limit: " & $limit & @CR & "Profile Application: " & $profile)
    Select
        Case IsArray($arrayUpdates)
            ;Sleep(250)
            GUICtrlSetState($btnShowUpdates,$GUI_ENABLE)
            GUICtrlSetData($labelStatus,"Updates available: " & @CR & @CR & @CR & "List updates: " & @CR & @CR)
            GUICtrlSetData($labelStatus,"Updates available: " & @CR & $arrayUpdates[0] & @CR & "List updates: " & @CR)
        Case Not IsArray($arrayUpdates)
            ;Sleep(250)
            GUICtrlSetState($btnShowUpdates,$GUI_DISABLE)
            GUICtrlSetData($labelStatus,"Updates available: " & @CR & @CR & @CR & "List updates: " & @CR & @CR)
            GUICtrlSetData($labelStatus,"Updates available: " & @CR & "No updates required" & @CR & "List updates: " & @CR)

    EndSelect

EndFunc

Func _CheckUpdates() ; Checks system to see what applications are out of date.
    #cs *************** For testing array *****************
    If IsArray($software) Then
        MsgBox(0,"","Check updates initiated")
        _ArrayDisplay($software)
    Else
        MsgBox(0,"","Software not an array")
    EndIf
    #ce
    $arrayUpdates = ""
    For $a = 1 To Ubound($software) -1
        ;MsgBox(0,"Loop: " & $a, $software[$a][2])
        $versionInstChk = 0
        For $i = 1 To $arrayHKCU_UnInst[0]
            If StringInStr(RegRead($sHKCU_UnInst & "\" & $arrayHKCU_UnInst[$i],"DisplayName"),$software[$a][1]) Then
                $versionInstChk = RegRead($sHKCU_UnInst & "\" & $arrayHKCU_UnInst[$i],"DisplayVersion")
            EndIf
        Next
        For $i = 1 To $arrayHKLM_Inst[0]
            If StringInStr(RegRead($sHKLM_Inst & "\" & $arrayHKLM_Inst[$i],"DisplayName"),$software[$a][1]) Then
                If _VersionCompare(RegRead($sHKLM_Inst & "\" & $arrayHKLM_Inst[$i],"DisplayVersion"),$versionInstChk) = 1 Then
                    $versionInstChk = RegRead($sHKLM_Inst & "\" & $arrayHKLM_Inst[$i],"DisplayVersion")
                EndIf
            EndIf
        Next
        For $i = 1 To $arrayHKLM_Inst64[0]
            If StringInStr(RegRead($sHKLM_Inst64 & "\" & $arrayHKLM_Inst64[$i],"DisplayName"),$software[$a][1]) Then
                If _VersionCompare(RegRead($sHKLM_Inst64 & "\" & $arrayHKLM_Inst64[$i],"DisplayVersion"),$versionInstChk) = 1 Then
                    $versionInstChk = RegRead($sHKLM_Inst64 & "\" & $arrayHKLM_Inst64[$i],"DisplayVersion")
                EndIf
            EndIf
        Next
        For $i = 1 To $arrayHKLM_UnInst[0]
            If StringInStr(RegRead($sHKLM_UnInst & "\" & $arrayHKLM_UnInst[$i],"DisplayName"),$software[$a][1]) Then
                If _VersionCompare(RegRead($sHKLM_UnInst & "\" & $arrayHKLM_UnInst[$i],"DisplayVersion"),$versionInstChk) = 1 Then
                    $versionInstChk = RegRead($sHKLM_UnInst & "\" & $arrayHKLM_UnInst[$i],"DisplayVersion")
                EndIf
            EndIf
        Next
        For $i = 1 To $arrayHKLM_UnInst64[0]
            If StringInStr(RegRead($sHKLM_UnInst64 & "\" & $arrayHKLM_UnInst64[$i],"DisplayName"),$software[$a][1]) Then
                If _VersionCompare(RegRead($sHKLM_UnInst64 & "\" & $arrayHKLM_UnInst64[$i],"DisplayVersion"),$versionInstChk) = 1 Then
                    $versionInstChk = RegRead($sHKLM_UnInst64 & "\" & $arrayHKLM_UnInst64[$i],"DisplayVersion")
                EndIf
            EndIf
        Next
        If _VersionCompare($versionInstChk,$software[$a][3]) = -1 And $versionInstChk <> 0 Then
            $arrayUpdates = $arrayUpdates & $software[$a][2] & "|"
        EndIf
        ;MsgBox(0,"","This version number: " & $versionInstChk & @CR & "Has to be less than: " & $software[$a][3] & @CR & "Result: " &  _VersionCompare($versionInstChk,$software[$a][3]) & @CR & "String so far: " & $arrayUpdates)
    Next
    Do
        If StringRight($arrayUpdates,1) = "|" Then
            $arrayUpdates = StringTrimRight($arrayUpdates,1)
        EndIf
    Until StringRight($arrayUpdates,1) <> "|"
    If $arrayUpdates <> "" Then
        $arrayUpdates = StringSplit($arrayUpdates,"|")
    EndIf
    ;_ArrayDisplay($arrayUpdates, "Updates available", "", 32)
EndFunc

Func _Admin()
    GUICtrlSetData($listOptions,"")
    GUICtrlSetData($listOptions,"Add App|Remove App|Install|Uninstall|Update All")
EndFunc   ;==>_Admin

Func _User()
    GUICtrlSetData($listOptions,"Install|Uninstall|Update All")
EndFunc   ;==>_User

Thanks for any help and advice.

[Bert]

can you chop out all the stuff that is not needed in your script and just have the part that is the problem? That is a long script and most people won't look at it & help because of it. Thanks.

[Melba23]

jazzyjeff,

Your GUI is flickering because you are updating the labels every 500ms via the _Information function - you need to check if anything has changed and only update then.

Your button is not working because it overlaps with the label behind it - AutoIt gets confused as it does not know which control you want to action and so does nothing. The solution is to resize the label so there is no overlap - or remove the default $SS_NOTIFY style from the label, which you can do by applying only the $SS_LEFT style on creation.

Implementing both of those changes should cure the problems you are seeing.

M23

[jazzyjeff]

Thanks Melba23.  I tried the $SS_LEFT style, but this did not resolve the issue. I ended up creating 2 labels and placing the button in between these labels and I alos followed your advice on checking changes to the variable, so the controls wouldn't constantly try and refresh.

Thanks for all your help.

[Melba23]

jazzyjeff,

Given that I could not run most of the script I am just delighted that my hunches turned out to be correct - the last crystal ball service was obviously worth the money!

Glad you got it working.

M23