poolcat Posted November 11, 2014 Share Posted November 11, 2014 Hi, i found and corrected a little bug in _StringRepeat. The function is not working correctly with 0 repetitions... The source is optimized to the core but starting at bit 1 and adding the source later on is not the best option to take. So here is my change if you get in trouble with the same issue. Cheers. ; #FUNCTION# ==================================================================================================================== ; Author ........: Jeremy Landes <jlandes at landeserve dot com> ; Modified.......: guinness - Removed Select...EndSelect statement and replaced with an If...EndIf as well as optimised the code. ; =============================================================================================================================== Func _StringRepeat($sString, $iRepeatCount) ; Casting Int() takes care of String/Int, Numbers. $iRepeatCount = Int($iRepeatCount) ; Zero is a valid repeat integer. If StringLen($sString) < 1 Or $iRepeatCount < 0 Then Return SetError(1, 0, "") Local $sResult = "" While $iRepeatCount > 0 If BitAND($iRepeatCount, 1) Then $sResult &= $sString $sString &= $sString $iRepeatCount = BitShift($iRepeatCount, 1) WEnd Return $sResult EndFunc ;==>_StringRepeat Link to comment Share on other sites More sharing options...
Moderators Solution Melba23 Posted November 11, 2014 Moderators Solution Share Posted November 11, 2014 poolcat,Reported and fixed #2841 a few months ago - but thanks anyway. M23 Any of my own code posted anywhere on the forum is available for use by others without any restriction of any kind Open spoiler to see my UDFs: Spoiler ArrayMultiColSort ---- Sort arrays on multiple columnsChooseFileFolder ---- Single and multiple selections from specified path treeview listingDate_Time_Convert -- Easily convert date/time formats, including the language usedExtMsgBox --------- A highly customisable replacement for MsgBoxGUIExtender -------- Extend and retract multiple sections within a GUIGUIFrame ---------- Subdivide GUIs into many adjustable framesGUIListViewEx ------- Insert, delete, move, drag, sort, edit and colour ListView itemsGUITreeViewEx ------ Check/clear parent and child checkboxes in a TreeViewMarquee ----------- Scrolling tickertape GUIsNoFocusLines ------- Remove the dotted focus lines from buttons, sliders, radios and checkboxesNotify ------------- Small notifications on the edge of the displayScrollbars ----------Automatically sized scrollbars with a single commandStringSize ---------- Automatically size controls to fit textToast -------------- Small GUIs which pop out of the notification area Link to comment Share on other sites More sharing options...
poolcat Posted November 11, 2014 Author Share Posted November 11, 2014 (edited) damn it I should get used to the bug tracker... Ah well, now you got a second solution Thanks Melba! Edited November 11, 2014 by poolcat Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now